DPDK patches and discussions
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: hemant.agrawal@nxp.com, ferruh.yigit@intel.com,
	cristian.dumitrescu@intel.com, harry.van.haaren@intel.com,
	jerin.jacob@caviumnetworks.com, thomas.monjalon@6wind.com,
	dev@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] build: remove unused map symbols
Date: Mon, 12 Feb 2018 12:41:54 -0500	[thread overview]
Message-ID: <20180212174153.GF21383@hmswarspite.think-freely.org> (raw)
In-Reply-To: <20180212142305.18557-1-pbhagavatula@caviumnetworks.com>

On Mon, Feb 12, 2018 at 07:53:05PM +0530, Pavan Nikhilesh wrote:
> Remove some unused map symbol.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
>  drivers/bus/fslmc/rte_bus_fslmc_version.map       | 2 --
>  drivers/mempool/dpaa/rte_mempool_dpaa_version.map | 1 -
>  lib/librte_eal/rte_eal_version.map                | 1 -
>  lib/librte_ether/rte_ethdev_version.map           | 1 -
>  lib/librte_ring/rte_ring_version.map              | 1 -
>  5 files changed, 6 deletions(-)
> 
> diff --git a/drivers/bus/fslmc/rte_bus_fslmc_version.map b/drivers/bus/fslmc/rte_bus_fslmc_version.map
> index 3f1ba130c..b7db07414 100644
> --- a/drivers/bus/fslmc/rte_bus_fslmc_version.map
> +++ b/drivers/bus/fslmc/rte_bus_fslmc_version.map
> @@ -28,7 +28,6 @@ DPDK_17.05 {
>  	qbman_eq_desc_set_no_orp;
>  	qbman_eq_desc_set_qd;
>  	qbman_eq_desc_set_response;
> -	qbman_get_version;
>  	qbman_pull_desc_clear;
>  	qbman_pull_desc_set_fq;
>  	qbman_pull_desc_set_numframes;
> @@ -41,7 +40,6 @@ DPDK_17.05 {
>  	qbman_swp_acquire;
>  	qbman_swp_pull;
>  	qbman_swp_release;
> -	qbman_swp_send_multiple;
>  	rte_fslmc_driver_register;
>  	rte_fslmc_driver_unregister;
>  	rte_fslmc_vfio_dmamap;
> diff --git a/drivers/mempool/dpaa/rte_mempool_dpaa_version.map b/drivers/mempool/dpaa/rte_mempool_dpaa_version.map
> index cc635c736..d05f274d0 100644
> --- a/drivers/mempool/dpaa/rte_mempool_dpaa_version.map
> +++ b/drivers/mempool/dpaa/rte_mempool_dpaa_version.map
> @@ -2,7 +2,6 @@ DPDK_17.11 {
>  	global:
>  
>  	rte_dpaa_bpid_info;
> -	rte_dpaa_pool_table;
>  
>  	local: *;
>  };
> diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
> index 2e6cbe96e..d12360235 100644
> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -248,7 +248,6 @@ EXPERIMENTAL {
>  	rte_service_map_lcore_get;
>  	rte_service_map_lcore_set;
>  	rte_service_probe_capability;
> -	rte_service_reset;
>  	rte_service_run_iter_on_app_lcore;
>  	rte_service_runstate_get;
>  	rte_service_runstate_set;
> diff --git a/lib/librte_ether/rte_ethdev_version.map b/lib/librte_ether/rte_ethdev_version.map
> index a5cb372b1..87f02fb74 100644
> --- a/lib/librte_ether/rte_ethdev_version.map
> +++ b/lib/librte_ether/rte_ethdev_version.map
> @@ -156,7 +156,6 @@ DPDK_17.08 {
>  	rte_flow_copy;
>  	rte_flow_isolate;
>  	rte_tm_capabilities_get;
> -	rte_tm_get_leaf_nodes;
>  	rte_tm_hierarchy_commit;
>  	rte_tm_level_capabilities_get;
>  	rte_tm_mark_ip_dscp;
> diff --git a/lib/librte_ring/rte_ring_version.map b/lib/librte_ring/rte_ring_version.map
> index 5474b985e..d935efd0d 100644
> --- a/lib/librte_ring/rte_ring_version.map
> +++ b/lib/librte_ring/rte_ring_version.map
> @@ -7,7 +7,6 @@ DPDK_2.0 {
>  	rte_ring_init;
>  	rte_ring_list_dump;
>  	rte_ring_lookup;
> -	rte_ring_set_water_mark;
>  
>  	local: *;
>  };
> -- 
> 2.16.1
> 
> 
Acked-by: Neil Horman <nhorman@tuxdriver.com>

Though we should probably figure out a check to catch these getting left behind
when their corresponding symbols are removed
Neil

  reply	other threads:[~2018-02-12 17:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12 14:23 Pavan Nikhilesh
2018-02-12 17:41 ` Neil Horman [this message]
2018-02-12 18:07   ` Pavan Nikhilesh
2018-02-13 13:43   ` Thomas Monjalon
2018-02-13  3:46 ` Hemant Agrawal
2018-02-13  4:56   ` Hemant Agrawal
2018-02-13 11:18     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180212174153.GF21383@hmswarspite.think-freely.org \
    --to=nhorman@tuxdriver.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=harry.van.haaren@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=pbhagavatula@caviumnetworks.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).