From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id CF5E61B2C3 for ; Tue, 13 Feb 2018 13:40:20 +0100 (CET) Received: by mail-wm0-f67.google.com with SMTP id a84so4457745wmi.5 for ; Tue, 13 Feb 2018 04:40:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=poz0i8Lfcmb6ZU1F9K9NTAtooTqIT9d8R8ozwv4K0m4=; b=Wytnxx3vFvLm7cdQEoqaYVpGlPsxmWziAWp2PNOuYy55gIxAudX0b6SFzjvtzjCDr9 iku1gu0ov1w1U/HlKt5oV9qhkfBjjHI03DlSfiVFKkL/DWdNn7IRN6Y7L29tju6cgTrS RmL8keq2jg5sgCSgeG7EoDFketgA61xU+XA/g7ASvxuleLv3WZMugdjS8s9Sf3vyFRJH BQySik3oVP6VwbccVZa6KBFXSdyc+cubkqbKrXgBZDytPhbzpFgAsU88ADlE851Q+gL5 Kk7nFoJfbwtsKjOiYhsXhSBQqxpM3onk1DF4fbSQaPW6HWBebNbpBexlQsBSsGmCnyit EZmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=poz0i8Lfcmb6ZU1F9K9NTAtooTqIT9d8R8ozwv4K0m4=; b=TcqmF8giZsRkB6Hx0CIVviB61p07lCq2GfYQCxOk82wDnmzCPOvwpGaKnKoEgQCLu+ xeS9aabXykkOvoE9Svx6Nv6ouUleX0huwz2R1Ak77Rhbw9BgBkjrbtlmf3I4W+G7gi6J 0IrbApJ+Oa5DDx44mhUxKYlz8qjWUe8ENCZiH6D+8BVA4Fhg975XhyX0o21hSDDXKeNu f1zsiA6+3McBEQ4iJMTwB0EufXJHLJVzR3Tv2ZNltvdMSor3noJREhakVZVhRCyvV+JO FfXBUGbFYUxhtuxl3rrRy1G7sDiDVPXRp5WTh6Kz3dHIinDzy+mQy7f4UxntadF5LM7C j75A== X-Gm-Message-State: APf1xPBCvjMkrubZcLNfu+EqOQLVHpKmfxqX48b8kQrysognMu+rZ2Ya /HIaIjvyUhVZH+egq/E6eDcr X-Google-Smtp-Source: AH8x224QIOG/0XhJbZ6EYM6/soIacS5RlH5mj8ZpPC7J3tp8Wv2D4tfiGfygfZ7EQ5Sj1+CKWNGDDQ== X-Received: by 10.28.6.69 with SMTP id 66mr1165839wmg.67.1518525620410; Tue, 13 Feb 2018 04:40:20 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z74sm8863463wmz.21.2018.02.13.04.40.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Feb 2018 04:40:19 -0800 (PST) Date: Tue, 13 Feb 2018 13:41:04 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Shahaf Shuler Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, thomas@monjalon.net, dev@dpdk.org, rasland@mellanox.com, stable@dpdk.org Message-ID: <20180213124104.x4qjimmomzmivxmb@laranjeiro-vm.dev.6wind.com> References: <20180213123155.44183-1-shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180213123155.44183-1-shahafs@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: revert multicast rule Verbs flow type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 12:40:20 -0000 On Tue, Feb 13, 2018 at 02:31:55PM +0200, Shahaf Shuler wrote: > This is to revert the following commits: > commit da646bd93888 ("net/mlx5: fix all multi verification code position") > commit 0a40a1363a4d ("net/mlx5: fix flow type for allmulti rules") > > The last one introduced a bug in the following diff: > @ -1262,6 +1274,7 @@ struct ibv_spec_header { > eth.val.ether_type &= eth.mask.ether_type; > } > mlx5_flow_create_copy(parser, ð, eth_size); > + parser->allmulti = eth.val.dst_mac[0] & 1; > return 0; > } > > As broadcast rules will be considered of type allmulti as well. > > The patch was originally intended to enable VF to receive all multicast > traffic by using the IBV_FLOW_ATTR_MC_DEFAULT flow type. > Since the support was removed from the kernel there is no point with > fixing this issue, hence the revert. > > Cc: nelio.laranjeiro@6wind.com > Cc: rasland@mellanox.com > Cc: stable@dpdk.org > > Signed-off-by: Shahaf Shuler Acked-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_flow.c | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index f88ece123..323dab723 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -391,7 +391,6 @@ static const struct mlx5_flow_items mlx5_flow_items[] = { > /** Structure to pass to the conversion function. */ > struct mlx5_flow_parse { > uint32_t inner; /**< Set once VXLAN is encountered. */ > - uint32_t allmulti:1; /**< Set once allmulti dst MAC is encountered. */ > uint32_t create:1; > /**< Whether resources should remain after a validate. */ > uint32_t drop:1; /**< Target is a drop queue. */ > @@ -1128,17 +1127,6 @@ priv_flow_convert(struct priv *priv, > attr->priority + > hash_rxq_init[parser->layer].flow_priority; > } > - if (parser->allmulti && > - parser->layer == HASH_RXQ_ETH) { > - for (i = 0; i != hash_rxq_init_n; ++i) { > - if (!parser->queue[i].ibv_attr) > - continue; > - if (parser->queue[i].ibv_attr->num_of_specs != 1) > - break; > - parser->queue[i].ibv_attr->type = > - IBV_FLOW_ATTR_MC_DEFAULT; > - } > - } > exit_free: > /* Only verification is expected, all resources should be released. */ > if (!parser->create) { > @@ -1246,7 +1234,6 @@ mlx5_flow_create_eth(const struct rte_flow_item *item, > eth.val.ether_type &= eth.mask.ether_type; > } > mlx5_flow_create_copy(parser, ð, eth_size); > - parser->allmulti = eth.val.dst_mac[0] & 1; > return 0; > } > > -- > 2.12.0 > -- Nélio Laranjeiro 6WIND