From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 9FA931B290 for ; Tue, 13 Feb 2018 14:12:21 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1AA6021719; Tue, 13 Feb 2018 08:12:21 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 13 Feb 2018 08:12:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=xtxuecobhUHdssnZe+Of1aXG9C19pnpWPDzY5PnqogM=; b=rYTnHMlV qgi8kF03Fxwwy7QpUXGXfLl71kE2F4kE2Kp+ZQjbEKx58YkthzmFZCbI6jX0QfYa JT4APLJpqxOzuiLdy3xO/q3oeNTr6m9r+XmBn7OVxqPVOYSJ32HZuYmKrb7ZDmo6 kz6XPGcDONCsTjxSxI+fvm0ERa6pFARReZmGO/GE8ildG6PYAgyKwiumzUX2MQXo muUf8/z2S8wzYfYUDkO7ZvTVdkq3V9gNrYn6cp3Lw9g+F4Hp6LMQEXDhO9Cib/Kt sL5OHqHC/o1/eYPrOzqILRuDewRvrrxuRbVMdYs+mrot6AQKa2eytiofSc0Lm094 FPVSR0q7MbBVvg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=xtxuecobhUHdssnZe+Of1aXG9C19p npWPDzY5PnqogM=; b=E/8zzZMeeAHq9EB2R4LJQQK1oQcPhV2DBqKFsjCQweu0y ggGKwC15jqZp2nDd/0BRjHXd2vdta8XXOs++0dWyOVdhjqqjHSNYFzrqN46ACbfC vFCGgcFpNpewhq3KwjEOrJl63K6ARudALZ0az14ynp02DulLacl4jKBKHQHDkFDy JMC1MsG+SHjFi6BzUTURsfqEDuSBEI8bejGcEyZBlJJLzEArDA5u9U2ccwVc3UmI 6Q2qVvAY8l3cWGAMzQAl6g+4MsCgYE2pnfothOhmt1OtujNs9J1zkIl3jTBvt1Cn L464jPt2VUSZQ6iyoamamsQ9cg5X/AXF1msmtZVzw== X-ME-Sender: Received: from yliu-mob (unknown [115.150.27.48]) by mail.messagingengine.com (Postfix) with ESMTPA id D62EE7E4B2; Tue, 13 Feb 2018 08:12:19 -0500 (EST) Date: Tue, 13 Feb 2018 21:12:16 +0800 From: Yuanhan Liu To: Ferruh Yigit Cc: Stephen Hemminger , Bruce Richardson , DPDK , Thomas Monjalon Message-ID: <20180213131216.GH2156@yliu-mob> References: <1452671929-29617-1-git-send-email-yuanhan.liu@linux.intel.com> <20160113150708.GD7756@bricha3-MOBL3> <20160113084959.797beea5@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH] doc: coding style: use linux kernel style for indentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 13:12:21 -0000 On Tue, Feb 13, 2018 at 12:51:57PM +0000, Ferruh Yigit wrote: > On 1/13/2016 4:49 PM, stephen at networkplumber.org (Stephen Hemminger) wrote: > > On Wed, 13 Jan 2016 15:07:08 +0000 > > Bruce Richardson wrote: > > > >> So, while the two-tab indent may look "a bit weird" it does solve the two issues > >> above. I believe practical benefits should override initial impressions. [It took > >> me a while to get used to also, but now I very much like it as a style.] > > > > I don't think that deviating from kernel style for this case is justified. > > This is very old patch still sitting in patchwork, re-visiting it mainly to be > able to clean the patchwork. Just drop it, there is no reason to revisit it. --yliu > > This is a syntax change request and although I have my personal preferences I > would be OK with whatever decided. > > Currently there is already a decided syntax, changing it after this point will > cause either mixed usage or a big syntax cleanup patch. I think both are not good. > > I am for continue whatever documented in current DPDK coding style doc, hence > NAK from my side. > > Thanks, > ferruh