DPDK patches and discussions
 help / color / mirror / Atom feed
From: Chas Williams <3chas3@gmail.com>
To: dev@dpdk.org
Cc: wenzhuo.lu@intel.com, konstantin.ananyev@intel.com,
	"Charles (Chas) Williams" <chas3@att.com>
Subject: [dpdk-dev] [PATCH] net/ixgbe: update data->eth_link status on start
Date: Tue, 13 Feb 2018 17:56:18 -0500	[thread overview]
Message-ID: <20180213225618.15693-1-3chas3@gmail.com> (raw)

From: "Charles (Chas) Williams" <chas3@att.com>

dev->data->eth_link isn't updated until the first interrupt.  If a
link is carrier down, then this interrupt may never happen.  Before we
finished starting the PMD, call ixgbe_dev_link_update() to ensure we
have a valid status.

Signed-off-by: Chas Williams <chas3@att.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 37eb668..27d29dc 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -2666,6 +2666,8 @@ ixgbe_dev_start(struct rte_eth_dev *dev)
 	if (err)
 		goto error;
 
+	ixgbe_dev_link_update(dev, 0);
+
 skip_link_setup:
 
 	if (rte_intr_allow_others(intr_handle)) {
@@ -5033,6 +5035,8 @@ ixgbevf_dev_start(struct rte_eth_dev *dev)
 
 	ixgbevf_dev_rxtx_start(dev);
 
+	ixgbevf_dev_link_update(dev, 0);
+
 	/* check and configure queue intr-vector mapping */
 	if (rte_intr_cap_multiple(intr_handle) &&
 	    dev->data->dev_conf.intr_conf.rxq) {
-- 
2.9.5

             reply	other threads:[~2018-02-13 22:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-13 22:56 Chas Williams [this message]
2018-03-30 16:30 ` Zhang, Helin
2018-03-30 17:21   ` Chas Williams
2018-04-02 12:40     ` Zhang, Qi Z
2018-04-02 13:38       ` Chas Williams
2018-04-02 13:45         ` Zhang, Qi Z
2018-04-02 13:57           ` Chas Williams
2018-04-02 14:34             ` Zhang, Qi Z
2018-04-04 13:53               ` Dai, Wei
2018-04-06 14:52             ` Zhang, Helin
2018-04-06 14:59               ` Chas Williams
2018-04-06 15:59               ` Zhang, Qi Z
2018-04-08  2:05 ` Zhang, Qi Z
2018-04-08 16:08   ` Zhang, Helin
2023-12-15 13:11 Riyadi Selamat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180213225618.15693-1-3chas3@gmail.com \
    --to=3chas3@gmail.com \
    --cc=chas3@att.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).