From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id B8DC71B308 for ; Wed, 14 Feb 2018 16:00:27 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id v123so22520293wmd.5 for ; Wed, 14 Feb 2018 07:00:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=1kEBKFcS/1Kawsy3f+1XfvSVuWye6hUXNDmhWlcM14Y=; b=Aod988WFfG0GMMV2XL0rxDGJDMVoGRc+ofupe5C7mUTrwn4VX6Ud3YgCTQp/rvF2xt IiY0ib/WzQAU4pIhNUp88nBSyp84cR9kc3Gq2yCH8PWQ32B+atQCg07HXYU5FAi91W70 EmViq2T1tDf1SSyd9ugP0fsxXf4yHfbHBhWeD8lqwNPa0dUmJP7wZ+yf9aYg8ocxAHr+ RwMZC7GJ8HkaEWlc9klZXSCWZjAdPjO8yg7rA5a3cHFVtuR/DZLgQLb4AGKwldZ9IHgt qSxV4ZXPA8u3Hv0Z0+h8FSHzy+Av6i2acOKCmJiD7aCGCLpqZAclGw9BCpurUWwT5byU MsAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=1kEBKFcS/1Kawsy3f+1XfvSVuWye6hUXNDmhWlcM14Y=; b=CX/UxJjPPBulCiW/T5FJE6WJctkaZ+21AOApNVKmYMm4Ayz/b2NZEzlMVTNDyagS8M vyIwNJ3WKXhF5OKgQIFzDi4T/kUkjJTVbRPuTn8g7qg34nCs0PDKajh8Tilm5ccxYSdy Qqig7YXdqubf3sR0YnPUoRh938wXwXa4nso5oAr9oD/4P5N8/4wqbmUZro2h2di8jv0/ ZeW/z7roKlXJUCN0bQ/IHvswgFxFpABHKwMV6IcUmzjxYcUpZ+L7YmbSagvKRvOjJAFE Sa73gGvpasMqxAYxPUIddruCph0Ftp4svLpzUMvcnnTlmYH2OKVOeIAvzjXqz5yb4dmC rsow== X-Gm-Message-State: APf1xPD0EKwBvS6YKM/eQwamdNvoOJQwsZZbjVA8IQcgTtRXDW+b3nLT HUFpgrinsZ3YT3Rbc/mHnj4DtQ== X-Google-Smtp-Source: AH8x2246lgYd1bFPSCz4MMDpGucIXSA6x87KMKfhcLmNh6M6q9oNiNh6XL5dL50wouS9SnvjCOIOWw== X-Received: by 10.28.31.133 with SMTP id f127mr4782700wmf.140.1518620427170; Wed, 14 Feb 2018 07:00:27 -0800 (PST) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id y42sm12918087wry.87.2018.02.14.07.00.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Feb 2018 07:00:26 -0800 (PST) Date: Wed, 14 Feb 2018 16:00:13 +0100 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Matan Azrad Cc: dev@dpdk.org Message-ID: <20180214150013.qejbi426ajglhuua@bidouze.vm.6wind.com> References: <1518562772-29823-1-git-send-email-matan@mellanox.com> <1518619646-23990-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1518619646-23990-1-git-send-email-matan@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2] net/failsafe: fix Rx interrupt reinstallation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Feb 2018 15:00:27 -0000 On Wed, Feb 14, 2018 at 02:47:26PM +0000, Matan Azrad wrote: > Fail-safe dev_start() operation can be called by both the application > and the hot-plug alarm mechanism. > > The installation of Rx interrupt are triggered from dev_start() in any > time it is called while actually the Rx interrupt should be installed > only by the application calls. > > So, each plug-in event causes reinstallation which causes memory leak > and spoils the fail-safe Rx interrupt mechanism. > > Trigger the Rx interrupt installation only when it does not exist. > > Fixes: 9e0360aebf23 ("net/failsafe: register as Rx interrupt mode") > > Signed-off-by: Matan Azrad Acked-by: Gaetan Rivet -- Gaëtan Rivet 6WIND