From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f174.google.com (mail-wr0-f174.google.com [209.85.128.174]) by dpdk.org (Postfix) with ESMTP id 759041B1C3 for ; Wed, 14 Feb 2018 16:01:44 +0100 (CET) Received: by mail-wr0-f174.google.com with SMTP id l43so258862wrc.2 for ; Wed, 14 Feb 2018 07:01:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=AKb2iIcmN9J0/YVnmLTEFHDHGGX2ILTkdySJTcrbB+c=; b=R0tXfWn3Y2rhUxvCXifJlpPHFZHai1siDLq+Sl5Sp0IaWqtj1/XRealEYCr1NeS7yK 4kIZ6XOwr7EEElWDmqOpGebBMIUbEZXy4g1www+u08E/VrqZicCQK78Kv9/AYA5idOIc ZwEusN8gqJZ6F+bEk0QR6PsI6M5LvPd7lcgyQ7OOo0Vqa9T5FsNg6wVLAVhtOa07gtOt 7nA8V2ct9RYauNlmteQGeY5qbX+MMpADr5SGKhH3ZvcT03ypoQkBfbXVjmFwZ1AdNB+/ NnPm9SoDJRx35++8yZWCauPuQCOs/mzKs7zzXOGJ7oK0xKGFdxVAiaDktRD6DYLYoN1i n5uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=AKb2iIcmN9J0/YVnmLTEFHDHGGX2ILTkdySJTcrbB+c=; b=dBkjSnNvZrkRoy5Xt3v9NS5oGPFZg5t3yiApaM6pgMEZqiAWcmXDELUu1wEIagVmWi bIuufnm0KaMjRMEfInalH1SR46kHpdVqrtveJ2Uhz1w198DTTTQD+dlsOcUKQU3WSIXg YvFTS80jets/lycnWoi5fODFA0B/cqL4LUTqDfDfzDxYQpMZxdxa4xndEp268xsAfGPI OZl8uDmZgmyPeeVZZ5XTyuaC0DaXYqzHoZqre++QNNXHW+nIhtXynDRqwtXBhMaWEDD1 3KJ7lA437zy4RuBKlgvJhu8WRsiE46VGV2SPdp7YWo0n2j96iesR50S9BEMxG6VKzPdX BVFA== X-Gm-Message-State: APf1xPCkmyokx0hceI/s9VLOijwz1Kj8h9gtb9iM3H9/kGAy7L6AiPrb tVx9saSFEqoVAfBAkpIrg/xDyw== X-Google-Smtp-Source: AH8x2268vCI8vXG9oBYJUP7/loI05sEaoTBLrcTjkLI6cnuZ2U3NDOW2tchSlzQo0iE+o5AIt18naw== X-Received: by 10.223.187.68 with SMTP id x4mr266997wrg.80.1518620503022; Wed, 14 Feb 2018 07:01:43 -0800 (PST) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id t4sm10890736wmt.16.2018.02.14.07.01.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Feb 2018 07:01:42 -0800 (PST) Date: Wed, 14 Feb 2018 16:01:29 +0100 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Matan Azrad Cc: dev@dpdk.org Message-ID: <20180214150129.ajvb2otj5xogpn3i@bidouze.vm.6wind.com> References: <1518562772-29823-1-git-send-email-matan@mellanox.com> <1518619646-23990-1-git-send-email-matan@mellanox.com> <20180214150013.qejbi426ajglhuua@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180214150013.qejbi426ajglhuua@bidouze.vm.6wind.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2] net/failsafe: fix Rx interrupt reinstallation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Feb 2018 15:01:44 -0000 On Wed, Feb 14, 2018 at 04:00:13PM +0100, Gaëtan Rivet wrote: > On Wed, Feb 14, 2018 at 02:47:26PM +0000, Matan Azrad wrote: > > Fail-safe dev_start() operation can be called by both the application > > and the hot-plug alarm mechanism. > > > > The installation of Rx interrupt are triggered from dev_start() in any > > time it is called while actually the Rx interrupt should be installed > > only by the application calls. > > > > So, each plug-in event causes reinstallation which causes memory leak > > and spoils the fail-safe Rx interrupt mechanism. > > > > Trigger the Rx interrupt installation only when it does not exist. > > > > Fixes: 9e0360aebf23 ("net/failsafe: register as Rx interrupt mode") > > > > Signed-off-by: Matan Azrad > > Acked-by: Gaetan Rivet Actually no! There is a mistake in the patch, you disabled the uninstall, instead of the installation. -- Gaëtan Rivet 6WIND