From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f67.google.com (mail-pg0-f67.google.com [74.125.83.67]) by dpdk.org (Postfix) with ESMTP id 31F551B1BD for ; Thu, 15 Feb 2018 22:56:03 +0100 (CET) Received: by mail-pg0-f67.google.com with SMTP id m19so863034pgn.1 for ; Thu, 15 Feb 2018 13:56:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dXrQwQP586hC7a038tKtK4SXkx6v1kZ0cRuyX+tA+WA=; b=xntF+JzlwE9PGf7Usk3waHQgxJAH6QXHp5iys16g1k9yupZSA6hjMhGX2TypNpnR7U x3xanQdyfqC4bOdqkuFOaU+rTCRiaexqai5PTP1NARxtGTmqPr+eLDWcap79qX6yDVxj q3QI+8gZurwKt54dRmNfXMBRGvRk5kyN30HKgw1gNEaOel+urY3FDQOF7TEHrZYFBuWn JulH+6UrJF6Qgg8G0qmsfrlXZVOzIwPHg8O9yj913wDGSDkgGMe5vAcaXm1w65+sEE8s 6Xu8qSc+BCP+HPHAX7gwTAbqjNJxjaRfjvMDxDD9PvKN6ybGhF4jZBBt3DIs1ZLCu63l pBZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dXrQwQP586hC7a038tKtK4SXkx6v1kZ0cRuyX+tA+WA=; b=DNj7m5TF4o9G0x2X0s8UTuKbXPv3H8HQx0zOCvyV+cgvxcSapG32akKysOmCRAMx4d B1s50TngNRNvrNe99e9jt81SB8hOLHOtiGQaPvG8AHe81qv/+Ofcaovqfscp6OqaJe+z LdPkm6K0eoo210o6GHumdqA5N4ua7L9A67vCFGloeitqaDDByP11fE0YlhpVK+YpL1Ip c6G2b9bxIY9e0gADkZETPa08HZ352Hv0MumLA8dza+334CsROlBEFCINlULcBiiZzDet B8e3HqyyVErkTVTubW301uu8RpjSCB4VMWKXOZqwjuwqUK3zNo8N1nX9W8+KxXuyj4kq F9Bw== X-Gm-Message-State: APf1xPB5R5Waz3pymH0gaxsjVU02YJcmBm0EiMS2LFI+97H6awmNrVtX okXxvvqKh0/MVfUWwpQy/8fD9g== X-Google-Smtp-Source: AH8x2250ScU+Q6/uDEAev7fSgXGLxdhHJDroG2TraNGWTblLJ6plwdc0+FbwCBT0aHbKKCkE55ivwA== X-Received: by 10.98.37.198 with SMTP id l189mr4006022pfl.103.1518731762222; Thu, 15 Feb 2018 13:56:02 -0800 (PST) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id 125sm38638228pff.19.2018.02.15.13.56.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Feb 2018 13:56:01 -0800 (PST) Date: Thu, 15 Feb 2018 13:55:58 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: Ophir Munk , dev@dpdk.org, Pascal Mazon , Olga Shern , stable@dpdk.org Message-ID: <20180215135558.78f2e0ca@xeon-e3> In-Reply-To: <4788233.rokdTfvtAd@xps> References: <1518509665-12171-1-git-send-email-ophirmu@mellanox.com> <4788233.rokdTfvtAd@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/tap: add CRC stripping capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Feb 2018 21:56:03 -0000 On Tue, 13 Feb 2018 17:35:20 +0100 Thomas Monjalon wrote: > 13/02/2018 09:14, Ophir Munk: > > CRC stripping is executed in the kernel outside of TAP PMD scope. > > There is no prevention that the TAP PMD will report on Rx CRC > > stripping capability. > > In the corrupted code, TAP PMD did not report on this capability. > > The fix enables TAP PMD to report that Rx CRC stripping is supported. > > > > Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") > > Cc: stable@dpdk.org > > > > Signed-off-by: Ophir Munk > > Applied, thanks > The whole CRC strip flag notion is backwards. It really should of been a bit set if driver allows preserving CRC. Since changing the ABI is not possible right now; the ethdev core ought to log a warning whenever driver is registered without CRC_STRIP flag. Or is lack of CRC_STRIP in offload flags implying that driver can do strip and not stripping?