From: Remy Horton <remy.horton@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v1] metrics: fix potential missing NULL termination
Date: Tue, 20 Feb 2018 14:50:01 +0000 [thread overview]
Message-ID: <20180220145001.18442-1-remy.horton@intel.com> (raw)
Fixes a potential memory overrun detected by Coverity.
This overrun cannot currently happen in practice because
rte_metrics_reg_names() explicitly forces the last name
character to be a NULL terminator. This patch adds the
same enforcement to rte_metrics_get_names() in order to
correct the warning.
Coverity issue: 143434
Fixes: 349950ddb9c5 ("metrics: add information metrics library")
Signed-off-by: Remy Horton <remy.horton@intel.com>
---
lib/librte_metrics/rte_metrics.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/lib/librte_metrics/rte_metrics.c b/lib/librte_metrics/rte_metrics.c
index 556ae1b..958ef3d 100644
--- a/lib/librte_metrics/rte_metrics.c
+++ b/lib/librte_metrics/rte_metrics.c
@@ -214,10 +214,15 @@ rte_metrics_get_names(struct rte_metric_name *names,
rte_spinlock_unlock(&stats->lock);
return return_value;
}
- for (idx_name = 0; idx_name < stats->cnt_stats; idx_name++)
+ for (idx_name = 0; idx_name < stats->cnt_stats; idx_name++) {
strncpy(names[idx_name].name,
stats->metadata[idx_name].name,
RTE_METRICS_MAX_NAME_LEN);
+ /* Enforce NULL-termination. The source string should already
+ * be NULL-terminated, so this is to quieten lint checks..
+ */
+ names[idx_name].name[RTE_METRICS_MAX_NAME_LEN - 1] = '\0';
+ }
}
return_value = stats->cnt_stats;
rte_spinlock_unlock(&stats->lock);
--
2.9.5
next reply other threads:[~2018-02-20 14:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 14:50 Remy Horton [this message]
2018-02-20 15:11 ` Bruce Richardson
2018-02-20 15:32 ` Remy Horton
2018-02-20 16:05 ` [dpdk-dev] [PATCH v2] " Remy Horton
2018-03-22 10:33 ` Ferruh Yigit
2018-04-04 14:09 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220145001.18442-1-remy.horton@intel.com \
--to=remy.horton@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).