From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f179.google.com (mail-pf0-f179.google.com [209.85.192.179]) by dpdk.org (Postfix) with ESMTP id 6FF2911D4 for ; Wed, 21 Feb 2018 02:16:16 +0100 (CET) Received: by mail-pf0-f179.google.com with SMTP id c143so18174pfb.6 for ; Tue, 20 Feb 2018 17:16:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:mime-version :content-transfer-encoding; bh=BiRp+jjTMeOSdcQO85WFxVpyCHeIPbDSEbWoRLC2e8Y=; b=0od9FJypke0NvPQepbVZuu2ZsNB+vjYjsmR9TxkpabiZhqwqkCQUHqsUNC0MVbjd7N FmCIYddAYtnLlOTT6rRzZjRR0SiACfjrjhB7Si1T1i8iieP+hwm2VAFgecSRuO6yO3vG dY69lFx3acjnLferkL9rsJP2sD7Qk2EQrkS8ccxVlaF81SQAuulmqjg5JRpJtcMfc9MP IX904m5sxy5k/UqgCWk0BcLRReVXxZnEvceP2JfOiaUYuh5qUBlU/nYuGeWg5EnWbO8A 50/wPu97KosrgFHYwpc75oQktP5mZvYUEOLH6mmi1Kle/l90Zv/xqgtnJwQmJuPKDRO2 Wb/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-transfer-encoding; bh=BiRp+jjTMeOSdcQO85WFxVpyCHeIPbDSEbWoRLC2e8Y=; b=mVJK/9/9RHc4h0J4/CRf5u1NZydnz5cnZzyeHNql971ebz0WwvTX024yWUGvIMzStf dNMmD6eg2hx1m1GhauiV++2oBnJ+Vn6fK1CHNyn9BJsA+TGWl1YdCxEJQUVtSwmnEhJC TC0XWPFHLWZaLWp0QyVjoE7vvML32bu3PMw59OjSTk7j6I8DYUMwpGt8yhUfZKRLV5N5 GuZcxYGPo0OeuAux+CvNfpZHjzygI6uK7PGNXdD7WTwbqiZOqCZYJT0Dcu9i00qNK8S5 z4evh987zKpKndJ2bNEzIuTlxEIYN7iFe57wxy8VhfWXIXfvKWEoTQyTCbrSuMMMAMJn Bfgg== X-Gm-Message-State: APf1xPCmL6c9cBbyLKs3x8a6ocmOdvvM8YCuP/VILgvxsxWSAG8bksSJ br7ueYl6Rdrc71O852nCjBHhDM5qrqM= X-Google-Smtp-Source: AH8x225Grm38fxGMEjf6ZpW2dyf0zPMNlLqcWHOwNZeh1CLGRtyimqotgRyfG4sAJGc0GtHUDyNYmw== X-Received: by 10.101.90.130 with SMTP id c2mr1264554pgt.310.1519175775139; Tue, 20 Feb 2018 17:16:15 -0800 (PST) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id 186sm59456760pfe.2.2018.02.20.17.16.14 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Feb 2018 17:16:15 -0800 (PST) Date: Tue, 20 Feb 2018 17:16:11 -0800 From: Stephen Hemminger To: dev@dpdk.org Message-ID: <20180220171611.7a430046@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [dpdk-dev] dynamic log level syntax X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Feb 2018 01:16:16 -0000 After using dynamic logging for a while, I think there was a poor design choice on using regular expressions to match logging string. The naming policy looks like a hierarchy and the matching is with regular expressions. For most other applications where a hierarchy is implied, a globbing rather than regular expression match is used. Instead of current regex based --log-level="pmd\.net\.i40e\..*" Globbing would use --log-level="pmd.net.i40e.*" Part of the problem as well with current choice is that seperator (period) is also the regular expression match any character value. Glibc doesn't have an easy to use version of this matching. The only close function is fnmatch and it wants slash for separator. Unfortunately, changing the syntax now would be an API nuisance. Some of the examples in the current documentation are unclear or incorrect on this.