From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix tunnel offloads cap query
Date: Mon, 26 Feb 2018 09:12:34 +0100 [thread overview]
Message-ID: <20180226081234.4e4c7res6g3ccyca@laranjeiro-vm.dev.6wind.com> (raw)
In-Reply-To: <20180225072837.85663-1-shahafs@mellanox.com>
On Sun, Feb 25, 2018 at 09:28:37AM +0200, Shahaf Shuler wrote:
> The query for the tunnel stateless offloads is wrongly implemented
> because of:
>
> 1. It was using the device id to query for the offloads.
> 2. It was using a compilation flag for Verbs which no longer exits.
>
> The main reason was lack of proper API from Verbs.
>
> Fixing the query to use rdma-core API. The capability returned from
> rdma-core refer to both Tx and Rx sides.
> Eventhough there is a separate cap for GRE and VXLAN, implementation merge
> them into a single flag in order to simplify the checks on the data
> path.
>
> Fixes: 43e9d9794cde ("net/mlx5: support upstream rdma-core")
> Fixes: f5fde5205101 ("net/mlx5: add hardware checksum offload for tunnel packets")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
> Acked-by: Xueming Li <xuemingl@mellanox.com>
>[...]
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2018-02-26 8:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-25 7:28 Shahaf Shuler
2018-02-26 8:12 ` Nélio Laranjeiro [this message]
2018-02-28 8:22 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226081234.4e4c7res6g3ccyca@laranjeiro-vm.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).