From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f182.google.com (mail-wr0-f182.google.com [209.85.128.182]) by dpdk.org (Postfix) with ESMTP id 9148F19F5 for ; Mon, 26 Feb 2018 09:13:15 +0100 (CET) Received: by mail-wr0-f182.google.com with SMTP id f14so20154614wre.8 for ; Mon, 26 Feb 2018 00:13:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=a6/wcL8ADevUECkCuAUYjqntQv94LhTE81eb3wMQay4=; b=gUeheuzEJivq8dOl6uKE440zK2jnrriA3KdtUL0q9L9ne/lNjNALz4cPNMtL6+MniN VENqyEjKQI4qKzidO+HslCdmV1a4TRySHpp3OzSla+NTL3YTD++YNkFKMLeHCj802Nlp p9kTJM7NU0BRRZHHYIxp8dA4AzUs6J1YlK1uPSbSHvB832xmGLJtOvLUrJjwuiWRRaSB /gvejiuxh2IpMBJCREUMZJmQGXVNgMJVbR4CM9PXd1lpqSfq6067xUS3vIe9C702ic54 Vj0zqBzyZojU9nyqKMLlUzD/La51uj6m905i1zslhWOPumSBU6+OfolCA+gvAQtJ+96w nkTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=a6/wcL8ADevUECkCuAUYjqntQv94LhTE81eb3wMQay4=; b=jbAEOZtIIwnuBQeyspsFjyY/LpWsj3dK6+DLH0ZTeLk92X71oM24S0PpKRh4GDXq/c TEeamEZYWEKGRHq9858NAeEHqZoDVSVb2sZKafe0U0AaOg4GfJ/B3lU5bSJF8d0j4pH4 2GcV7E+F1zJwLjJg0woXAng5IEe3Nj1hHkMimWnjm6mahQmreBJ6ysdmdnyXC1P9h6i7 NDwtctCOcLNp5F0nK1U008wP5sbmkKUQsghI0pLAHOnutNxOSjYYOGRns6iXd6ZwEmDa uV7BBQqwmYxeGXbSAqn/L2xYNPA87rXxL/uVTh+zovOk2UKh9E2SvQi2n0YkpjsfWO+h UCZQ== X-Gm-Message-State: APf1xPBCzkuVgMnursHI3yAgA5NzZNkR8MfXSpXEQJ210emoCwgHxuXs Xtm/6eXNTckk7hT292JEC5+v X-Google-Smtp-Source: AH8x2263vxZlRGLTMSQ9XngLrJ3iuGktABy1AL8IJoHqhWkRXQBc440DeXq9CNCVpom9H1IV/sPLyw== X-Received: by 10.223.169.229 with SMTP id b92mr8372223wrd.244.1519632795353; Mon, 26 Feb 2018 00:13:15 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id c1sm8271966wrf.31.2018.02.26.00.13.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Feb 2018 00:13:14 -0800 (PST) Date: Mon, 26 Feb 2018 09:12:34 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Shahaf Shuler Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20180226081234.4e4c7res6g3ccyca@laranjeiro-vm.dev.6wind.com> References: <20180225072837.85663-1-shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180225072837.85663-1-shahafs@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix tunnel offloads cap query X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Feb 2018 08:13:15 -0000 On Sun, Feb 25, 2018 at 09:28:37AM +0200, Shahaf Shuler wrote: > The query for the tunnel stateless offloads is wrongly implemented > because of: > > 1. It was using the device id to query for the offloads. > 2. It was using a compilation flag for Verbs which no longer exits. > > The main reason was lack of proper API from Verbs. > > Fixing the query to use rdma-core API. The capability returned from > rdma-core refer to both Tx and Rx sides. > Eventhough there is a separate cap for GRE and VXLAN, implementation merge > them into a single flag in order to simplify the checks on the data > path. > > Fixes: 43e9d9794cde ("net/mlx5: support upstream rdma-core") > Fixes: f5fde5205101 ("net/mlx5: add hardware checksum offload for tunnel packets") > Cc: stable@dpdk.org > > Signed-off-by: Shahaf Shuler > Acked-by: Yongseok Koh > Acked-by: Xueming Li >[...] Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND