From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: adrien.mazarguil@6wind.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix disabling Tx packet inlining
Date: Tue, 27 Feb 2018 08:50:42 +0100 [thread overview]
Message-ID: <20180227075042.nmjaif4rgnx2eoka@laranjeiro-vm.dev.6wind.com> (raw)
In-Reply-To: <20180226175057.27565-1-yskoh@mellanox.com>
On Mon, Feb 26, 2018 at 09:50:57AM -0800, Yongseok Koh wrote:
> Adding 'txq_inline=0' to PMD parameter should disable Tx packet inlining
> but it doesn't work properly for Enhanced Multi-Packet Send.
>
> Fixes: 6ce84bd88919 ("net/mlx5: add enhanced multi-packet send for ConnectX-5")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
> drivers/net/mlx5/mlx5_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index dc4ead934..049f7e6c1 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -1382,7 +1382,7 @@ txq_burst_empw(struct mlx5_txq_data *txq, struct rte_mbuf **pkts,
> (!txq->mpw_hdr_dseg ||
> mpw.total_len >= MLX5_WQE_SIZE);
> }
> - if (do_inline) {
> + if (max_inline && do_inline) {
> /* Inline packet into WQE. */
> unsigned int max;
>
> --
> 2.11.0
>
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2018-02-27 7:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 17:50 Yongseok Koh
2018-02-27 7:50 ` Nélio Laranjeiro [this message]
2018-03-11 13:19 ` [dpdk-dev] [dpdk-stable] " Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227075042.nmjaif4rgnx2eoka@laranjeiro-vm.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).