From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f50.google.com (mail-pg0-f50.google.com [74.125.83.50]) by dpdk.org (Postfix) with ESMTP id D004F2A5E for ; Thu, 1 Mar 2018 00:42:20 +0100 (CET) Received: by mail-pg0-f50.google.com with SMTP id l4so1568418pgp.11 for ; Wed, 28 Feb 2018 15:42:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=a0PWRdTJkHM3eojW00ZUQjVTTnNs8R0cLXa/7j2EDss=; b=yq/VLYJbgOVGLZ02MysrfAfDkct+FuNacez35TIDoj9XpI+5GcprZVeiSzQPwybCDf UzZDR2mFcCnA6UrVZEGDF+2ahw8NECZTBLsVdc3c3lo9pXY46NhSdzSrYwq4TqYHqWhB IGvEYpwLGe4V/ml8JLGHbxt8MLSJSOmSWvRzaECAGiMytowdGQUbKIbpkE57hBD2QU+m 4VxsDv56fcGZYypuwwaUaDjucps5Dx/SrslYIQiGZAm6rxdgiWZzejl7lPScWrd2+M8k nXcLBnBXD3cOEDZGfvoz9uTmkDfpTSmUTFzSq5odiqtcW9GW/qEkuEWWNcGJn8GYVBIq itUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=a0PWRdTJkHM3eojW00ZUQjVTTnNs8R0cLXa/7j2EDss=; b=EW/CW3Mh+gx2lkoS1Ma6C7p1aNZ9/BQ+wDgyPeVwzg2XcMfspYNWINjBRfOo2xjW9I NqWq8B/ywcupRVMrPjj1nVAEWK+QU0A4bsMkBOtmM/4Z7J9SjuIUWd3s+s/f7v2c3pWY omtz3JvklKjct1CvfvNjqM7eIzzPssL5cSRVjp4aKJeQXFQs4t4FUkhEkhA17dW3vm4n McCN9Xlr9MYY8CNiHJcMu2Q0/8pGeIDPpbHexR8KHzDSUCq5xKaygzQQZJmMTFgLyqLX BGn2kiPOk+XpQuL15kNlXZpUf2mQPoBSVIKYgSSL5v48v2rllRLVaSzFwglQ9LHRcqUE ElrA== X-Gm-Message-State: APf1xPB/XVoHjAFM0uLZsBU1Xe0/OyAZiblfifWcl/H6asgpqU8gpKkN 2nsV6TqHkUa1rB2A2FpgnUEVvkZjskA= X-Google-Smtp-Source: AG47ELtTKsNDOxP1q/TwwSM9dk/Bq0JAxA3GYrFdL/iAB9Zbk3re3+tBI5ITHtJz31G3v/lg+uhLOg== X-Received: by 10.101.83.199 with SMTP id z7mr10290730pgr.105.1519861339993; Wed, 28 Feb 2018 15:42:19 -0800 (PST) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id x9sm4706417pgc.81.2018.02.28.15.42.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Feb 2018 15:42:19 -0800 (PST) Date: Wed, 28 Feb 2018 15:42:17 -0800 From: Stephen Hemminger To: Qi Zhang Cc: dev@dpdk.org, magnus.karlsson@intei.com, bjorn.topel@intel.com Message-ID: <20180228154217.4aff5095@xeon-e3> In-Reply-To: <20180227093306.23854-2-qi.z.zhang@intel.com> References: <20180227093306.23854-1-qi.z.zhang@intel.com> <20180227093306.23854-2-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC 1/7] net/af_xdp: new PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Feb 2018 23:42:21 -0000 On Tue, 27 Feb 2018 17:33:00 +0800 Qi Zhang wrote: > struct pmd_internals { > + int sfd; > + int if_index; > + char if_name[0x100]; why not IFNAMSIZ? > + struct ether_addr eth_addr; > + struct xdp_queue rx; > + struct xdp_queue tx; > + struct xdp_umem *umem; > + struct rte_mempool *mb_pool; > + > + unsigned long rx_pkts; > + unsigned long rx_bytes; > + unsigned long rx_dropped; > + > + unsigned long tx_pkts; > + unsigned long err_pkts; > + unsigned long tx_bytes; why not per-queue stats? per-port stats are expensive > + uint16_t port_id; > + uint16_t queue_idx; > + int ring_size; > + struct rte_ring *buf_ring; > +};