From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0082.outbound.protection.outlook.com [104.47.40.82]) by dpdk.org (Postfix) with ESMTP id A313E4CBB for ; Thu, 8 Mar 2018 11:18:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=BqmFuFmSuDDcVaTbg3g66ibJ+wKinmDMbCN+flPAgAc=; b=iUxRQEobMuxn3T5tTfIUVbXzwwfJCOLZFGw61S24Al9OoIlopxCKZVv5edlkoutP4QwXuec0YLFL3EV64g4xOo4XkHzCNkXsx8xXicyUg1hYG8N6Wxl9N0uPSF/QTwJ9+JdkT8rIEMmmTCBL7PLDGK69FHh55vnNtV8xMn4pWrA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from ltp-pvn (111.93.218.67) by CY4PR07MB3464.namprd07.prod.outlook.com (2603:10b6:910:75::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.567.14; Thu, 8 Mar 2018 10:18:29 +0000 Date: Thu, 8 Mar 2018 15:48:06 +0530 From: Pavan Nikhilesh To: Anatoly Burakov , keith.wiles@intel.com, jianfeng.tan@intel.com, andras.kovacs@ericsson.com, laszlo.vadkeri@ericsson.com, benjamin.walker@intel.com, bruce.richardson@intel.com, thomas@monjalon.net, konstantin.ananyev@intel.com, kuralamudhan.ramakrishnan@intel.com, louise.m.daly@intel.com, nelio.laranjeiro@6wind.com, yskoh@mellanox.com, pepperjo@japf.ch, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, olivier.matz@6wind.com Cc: dev@dpdk.org Message-ID: <20180308101805.GA9526@ltp-pvn> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.3 (2018-01-21) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR01CA0089.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1::29) To CY4PR07MB3464.namprd07.prod.outlook.com (2603:10b6:910:75::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5b7c585d-df24-4807-59a8-08d584ddf3aa X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:CY4PR07MB3464; X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 3:43Kk+w8j1x+LXBaSMpXF9TK/D//3KmUkY1na1Pvsq+7nUX5qn2EhWTu5ldbRDGuOTonxmn72Ls3LQP53iKOTkgUP0rMYaZ8K51CWuViU7GwhfqjC2NeKNcPINLJDC4YeyGWJd90dRYER1U6e8JSIh/z2K0HsF41SwhEduPWnKtPhpRPEj7cD3xrlq93srQ7hukKStNhwRh1b/M6d6Qg9MRkraXRdtiieiJLsaZasFvKGn5bhyaqlFWe/QUk5MT2x; 25:wZxkRIxWZuF6dirxUDnzY9hG+5qXfu/TquRlD39JtTPQPMrImDjsadcZT/u65MQVdJg1RoS85xdNzMHKhatxV5ovrQYJ5gYCTvKyHIZcnc2Px/rWcjsoyCSDHvUZD2PH/gCLZ33pleJgy6jNarCopfQemKlPAJODwNpkaOCyKCGruLr5ytWAq3yqzQL4Px6XK5/XHi7rQv0RTexHwJbTb/gpeVAGcHTB/BJSQHVV8Yye6PEGjmacACNR3Mf7U1e3nRPrfqtdqKO7tDi141texlGC4qWmDYbhrroA6vcfVmBDbabj2cxFpyDSVp3j0OP+kSGbpRB8MOybsWOeW/w8/w==; 31:UEB3rDcVLdSOsI4gVMx2mXsb2y+at1SGVmOutrCeJHaMYUJKLwmlnxqzhYz0QjY09SAagZJNAH4GYscy2pBGm4fzXfCLt4ohNCIrOWRjX6jw2TWKHhMWTL/lDEU/9zQRgSkCvwUXjrH8zCDV3K4GxmOo/pBeLwxX3JDayK0i/r1bdphBHQEuAfICpTuiiNko7/u/Xj6cWEg/N4kDfJNU9THijw+tSe/9UXPNcriZYR0= X-MS-TrafficTypeDiagnostic: CY4PR07MB3464: X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 20:aQLKRqsqIDbZteZRpVI3mTjQlb/pZBPOlQEOqYWq1YsFx8x8XcJSN/m22QoIeyeCcAth34T7R8joWvAShAJSAcCScXkTxMWYAiju9swoW7Lg3oOV9oonWOYyPtDecPrO1c0druHkUJi+vrHy1+veyk1U7N0MXhyPror0ePFXyJB6epV0TAa3+E0ECiGxuhbI4FoB4AuS61EgAB20Jqi6vVmYgofbOiP1O5/Up5eUlhGB8bimTsHummv0ipdrZhT83EMURSMqfqzffYlZyGOrPvEu29f3LRfFxb2d82+W6r3orz2KZhUVyZiIMauYVxtODWCz85BNwOAW9obiVYz9HgRUepTJXPribEMcqafVC06xdCv68ajuu+QEtblO1IbL+ZIIXa26H8X2GfmI6U3kaUU9bFCnyG6JMWjK1om6ee2/LwYq3WmVMF6WHIXvnyiAZAQ9gl477KQXschRPYYtkIuSW6qpzeJoik+Fnltwpr2zyYI1L7rnbzgOmOdn0R9ePF2s4qjydA5BoOeyZcdHOJG99LLMduoysTV8Z8EbJOB/BA8ZgOh1KvSrr7WBi5B/xTgmtMGkiE21zgrNRlHtZ8PHpQ6ofmlBBE5V3clX8wI=; 4:aTUMerkK4M70KQPwMaTiGU8eRjLgOgWMp6pZxqmhRiiSAsidYJkc0LqH1mhq3o7BEGtNAd9TLOC2eZlMUc8HUaUcuIdYkxxl60bj3oPbxwfVlvFpuW+zo10o/8Bpj1r03glqbWG9GgS5kJbTWes6mFzU11uB3VH/jwIjfX1JGN+6L8rb2m7JuqfsuIjXizRoSrlhapkHuMgQz2+UFu0+NjeoLZ1RKVooCDaPq4kkNbrK9sAq8WQWae49aZcb201UcNQmPVLH3miRPdo9VNUK+w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(8121501046)(5005006)(3002001)(3231220)(944501244)(52105095)(93006095)(10201501046)(6041288)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011); SRVR:CY4PR07MB3464; BCL:0; PCL:0; RULEID:; SRVR:CY4PR07MB3464; X-Forefront-PRVS: 060503E79B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(346002)(376002)(396003)(39380400002)(199004)(189003)(33896004)(6306002)(9686003)(8656006)(2906002)(53376002)(8676002)(53936002)(76176011)(50466002)(66066001)(316002)(42882007)(52116002)(106356001)(305945005)(23726003)(6246003)(1076002)(6496006)(7416002)(58126008)(6116002)(3846002)(575784001)(55016002)(81166006)(81156014)(97736004)(16586007)(229853002)(966005)(8936002)(33656002)(72206003)(16526019)(5009440100003)(386003)(26005)(478600001)(6666003)(2950100002)(5660300001)(4326008)(25786009)(47776003)(33716001)(59450400001)(7736002)(186003)(5890100001)(68736007)(105586002)(18370500001)(921003)(107986001)(42262002)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3464; H:ltp-pvn; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR07MB3464; 23:dcoYf68lBq+LRgqyMTSRLdx/3HSM/ciUNG5z7yM5V?= =?us-ascii?Q?9nLv3qciLga3chTnlvggSO2DYLATgnl/v16WvEaLTUBJrq/uwOZz8AGNIJJu?= =?us-ascii?Q?nsc84fkrpTwsMjNbRXQHVHhhFWMJHniVkFSQr1SWT79Em3o0qvm1mFcc9Cbl?= =?us-ascii?Q?mXPPWHRy/l/kjhrBW6SgEvMj6QjeHsKZI5uP/qZT6iSzxewekeddpHI8e0ZK?= =?us-ascii?Q?HP23gATK1izO+LKPKTLjLTUljRQQH1KXW62PAjprmsbe1PZJYmY8EYzghAAO?= =?us-ascii?Q?HxVwkn7Qm/gc5DGElTjusfz61ouHexSHTqcX+P/CNZrK/Q08apjcMKCUX3Vu?= =?us-ascii?Q?0Vr3KnTh4uNWVoE15nu4nungU/a4u4pF/767m2p7HS66TXCgpYRCt2Dpuw1o?= =?us-ascii?Q?jyvJ82qJtsJ91d9qeRPI4aypdmQAMVWkfzL79LfKVTcDxKabmzkuLAXAmJ4K?= =?us-ascii?Q?zk6F7WFXBRQVOj8E2mnaIrAEWQcFQqYbG4RGEG6O7E+7p0/yX5t+P9GvUual?= =?us-ascii?Q?30Ybt1zsbnVfoaMwjsfFz9+lkB3IGiSmsIpeqqhOby9wMWvbO7kbbX5g8Jrs?= =?us-ascii?Q?QkiftmCCxxAK+Xz5NKvWHxTSq7TeOc3E3VxZeuwhTOjNyItRby8BtDyGquoi?= =?us-ascii?Q?O+50DIRMPcv3Dp/8mLYFDcKsFtEuccqcVB1j2wSuON0eII787rG4PrrKpBr2?= =?us-ascii?Q?PjsHMQLwI1Q8xnYHh3i9ooIHUycGMRpn4YE56zwbg1kwP+XlupPcPxVZw2ZH?= =?us-ascii?Q?bsmasYDTOi/UtJXKjOsohJAPN0BngrOPSnkVdin09pg8P55tITMNQT3pJ4xd?= =?us-ascii?Q?bOSnHxf8Qj/gPb8XBs8fWRSFnRXAVR4FFtU3qfx7oPv2gqrRb7XN9m7TgM/n?= =?us-ascii?Q?7t0dzxz5y2s2uBF4o8+6e2iP4XfaQXGWklG0dRsGmmkGfFRKGlnbpYjC+V2A?= =?us-ascii?Q?6KuK/ODqqyi1W7BSQThhr7zAJBCRPyT92/2rbywUcOaEsoGtIGwmJDtWO0FU?= =?us-ascii?Q?5YhXAr7UHMammf8sWube9VGcnKe0aISuybDZpBHeiWLFx8qv07YaPp5n0v6N?= =?us-ascii?Q?Vi7caUJbz0k5z9So4EAsPh8ar7cdoMIFLbyYU49It+L/zgR95ESj6egvQSaC?= =?us-ascii?Q?oX5k1jwOS33HRJZdT4oCw5pqBOaCSpBbBhJk1bgL6u0mGtgPv36CpNA/VsrI?= =?us-ascii?Q?KwoM0xlFa5r5HRUlu5QaRjwS3hSRpnOVpTrKeXDf8OXKtfBIiaqP/gHkGeSn?= =?us-ascii?Q?zzY7oHBW/3IbZO0uSyKjRkfblQ5ULHVNeqMZncc0CNTNcNbkzuccnMbVlSxb?= =?us-ascii?Q?0GuqGneUnZ4rFOywqM7ByJ4HDQ9EHxnU242FKn7nc9sBSiFW4+XUoOD38j0S?= =?us-ascii?Q?NNrrEDf5N9rlFQbVaBQWIxTzM20ubz4UjsotIjidWh4GKdlQjHUXUnUNJwS8?= =?us-ascii?Q?HUZM6NX4ogxvoT2HdmwJ2kWmzRX+jDmuQhf61/y0L8hdoErAohTNaOX84MvX?= =?us-ascii?Q?RgsgcogXPYaa+lpz0qm1Tx4TPv2WDPQw5U=3D?= X-Microsoft-Antispam-Message-Info: h4aa9rlykE5m9TI8SE1l/b8ZXJ1EcKi/xxBdcrkE14GVWdwWc8abj++oj8b2+Vxx569AQbLF836IjZ/pVHhmOISKo/CvpHfp2LXXcJfpFJkli6IKY1KoY9lnkYT2R5XXJiV5ySjXRIAdgcrXLS+9bz93OXaXBwAUiA66Mc8ld03H7RnEfhpYfZJ0piTNjp1o X-Microsoft-Exchange-Diagnostics: 1; CY4PR07MB3464; 6:hwU2F7+rEMjlUDhJpjxXLRbBqKCRSf97btqqWr+qgEjlCrSThh5DpHtvxmLS4zH2rF7/lPWGXmfKCOz/iHKRQQuO5BEWhvd+aqWCeKCxhdq1NgPH7AuoiVR5hF8DBpdpk17AIy+msVRwOX0EoRCFvf+0DJfXV7/MaeltjPXCKDauRJtMKH3C/F2KvVkyxI7c5OPwXpTfzjCxxrVmkkulIrjC6w4GLeezjUUcpEukAozZuU6UMXioiQuIx0OkB/89BBCaSLkePvI9YqDUvjSadILNkLc/C5PIJiQo4k8mr117FMJ/0wX6jGd5wSt/eC2ENxm2SUAQbivvHTwEHK/OL6dcY/Y+369T/OYO6x+7on0=; 5:JTk0I9r66XDOrB46vX95JzKCcpXNejiK1pkIw5Q964HWNYpu0T1ReGvaIb+SZquUjqeEYWMCBDwTPpl8xyxTzZ+PlSdRWyP3c5nrxYQIMBbuFLLcEDVqXgs1hUMaXTYfdLfVxIAxa2HdiOJG7Tc+t2NEl2wK5XcjDxugmU9hmjI=; 24:qRg0TNhs/p/F+q2H7ADct9BbhoGILSvohkzgo0WgJiQDA+zQ4cD1RyqgXkWFAdhbPAx9RivaLvCTwBBwnWRifGGA8z1hcSM0hIe0eefDA2I=; 7:C/t5nEdMhjrE0FEUr5KLW6flDVSbHx66F5DqWzZwRMKCfUZfwO5jMJTNI7mWAQ6Ke+GAF/8QfQeoNAIXAxNX/vVc2Ru1IC3PZLnpbRcK1QnXBALW6dP5BKo/UvmMGikfPzcfqo7HmBIVXgew2LvZwS1+i57kXGr5eGmJOijgpzPla6UJ9oALbMprZas4Qyup9asNakIvIdSJPof+bZJ7axvMKsg8furq5Yh6199sQqFvRIS8beVM++XD3uLHte9T SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2018 10:18:29.7678 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5b7c585d-df24-4807-59a8-08d584ddf3aa X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR07MB3464 Subject: Re: [dpdk-dev] [PATCH v2 00/41] Memory Hotplug for DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Mar 2018 10:18:39 -0000 Hi Anatoly, I am trying to verify this patchset and have encountered few issues. Few -Werror=maybe-uninitialized errors in eal_memalloc.c/eal_memory.c/ eal_common_memzone.c files. diff --git a/lib/librte_eal/common/eal_common_memzone.c b/lib/librte_eal/common/eal_common_memzone.c index a7cfdaf03..ad4413507 100644 --- a/lib/librte_eal/common/eal_common_memzone.c +++ b/lib/librte_eal/common/eal_common_memzone.c @@ -321,7 +321,7 @@ rte_memzone_free(const struct rte_memzone *mz) struct rte_fbarray *arr; struct rte_memzone *found_mz; int ret = 0; - void *addr; + void *addr = NULL; unsigned idx; if (mz == NULL) diff --git a/lib/librte_eal/linuxapp/eal/eal_memalloc.c b/lib/librte_eal/linuxapp/eal/eal_memalloc.c index 1008faed6..32b0d5133 100644 --- a/lib/librte_eal/linuxapp/eal/eal_memalloc.c +++ b/lib/librte_eal/linuxapp/eal/eal_memalloc.c @@ -570,7 +570,7 @@ eal_memalloc_alloc_page_bulk(struct rte_memseg **ms, int n, unsigned int msl_idx; int cur_idx, start_idx, end_idx, i, j, ret = -1; #ifdef RTE_EAL_NUMA_AWARE_HUGEPAGES - bool have_numa; + bool have_numa = false; int oldpolicy; struct bitmask *oldmask = numa_allocate_nodemask(); #endif diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c index f74291fb6..d37b4a59b 100644 --- a/lib/librte_eal/linuxapp/eal/eal_memory.c +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c @@ -1386,9 +1386,9 @@ eal_legacy_hugepage_attach(void) struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config; struct hugepage_file *hp = NULL; unsigned int num_hp = 0; - unsigned int i; + unsigned int i = 0; int ms_idx, msl_idx; - unsigned int cur_seg, max_seg; + unsigned int cur_seg, max_seg = 0; off_t size = 0; int fd, fd_hugepage = -1; @Hemanth Also, this patchset breaks dpaa/dpaa2 bus drivers (they rely on `rte_eal_get_physmem_layout` that is depricated http://dpdk.org/dev/patchwork/patch/34002/) So, generic arm64 linuxapp build is broken. Regards, Pavan. On Wed, Mar 07, 2018 at 04:56:28PM +0000, Anatoly Burakov wrote: > This patchset introduces dynamic memory allocation for DPDK (aka memory > hotplug). Based upon RFC submitted in December [1]. > > Dependencies (to be applied in specified order): > - IPC bugfixes patchset [2] > - IPC improvements patchset [3] > - IPC asynchronous request API patch [4] > - Function to return number of sockets [5] > -- > 2.7.4