From: Bruce Richardson <bruce.richardson@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 18.05 v4] eal: add function to return number of detected sockets
Date: Thu, 8 Mar 2018 12:12:29 +0000 [thread overview]
Message-ID: <20180308121229.GA8660@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <eb142226e1e62abe5a95bb135468732131580b71.1517925320.git.anatoly.burakov@intel.com>
On Wed, Feb 07, 2018 at 09:58:36AM +0000, Anatoly Burakov wrote:
> During lcore scan, find maximum socket ID and store it. This will
> break the ABI, so bump ABI version.
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>
> Notes:
> v4:
> - Remove backwards ABI compatibility, bump ABI instead
>
> v3:
> - Added ABI compatibility
>
> v2:
> - checkpatch changes
> - check socket before deciding if the core is not to be used
>
> lib/librte_eal/bsdapp/eal/Makefile | 2 +-
> lib/librte_eal/common/eal_common_lcore.c | 37 +++++++++++++++++++++----------
> lib/librte_eal/common/include/rte_eal.h | 1 +
> lib/librte_eal/common/include/rte_lcore.h | 8 +++++++
> lib/librte_eal/linuxapp/eal/Makefile | 2 +-
> lib/librte_eal/rte_eal_version.map | 9 +++++++-
> 6 files changed, 44 insertions(+), 15 deletions(-)
>
Breaking the ABI is the best way to implement this change, and given the
deprecation was previously announced I'm ok with that.
Question: we are ok assuming that the socket numbers are sequential, or
nearly so, and knowing the maximum socket number seen is a good
approximation of the actual physical sockets? I know in terms of cores
on a system, the core id's often jump - are there systems where the
socket numbers do too?
/Bruce
next prev parent reply other threads:[~2018-03-08 12:12 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 11:58 [dpdk-dev] [PATCH] " Anatoly Burakov
2017-12-22 12:41 ` [dpdk-dev] [PATCH v2] " Anatoly Burakov
2018-01-11 22:20 ` Thomas Monjalon
2018-01-12 11:44 ` Burakov, Anatoly
2018-01-12 11:50 ` Thomas Monjalon
2018-01-16 11:56 ` Burakov, Anatoly
2018-01-16 12:20 ` Thomas Monjalon
2018-01-16 15:05 ` Burakov, Anatoly
2018-01-16 17:34 ` Thomas Monjalon
2018-01-16 17:38 ` Burakov, Anatoly
2018-01-16 18:26 ` Thomas Monjalon
2018-01-16 17:53 ` [dpdk-dev] [PATCH] doc: add ABI change notice for numa_node_count in eal Anatoly Burakov
2018-01-23 10:39 ` Mcnamara, John
2018-02-07 10:10 ` Jerin Jacob
2018-02-09 14:42 ` Bruce Richardson
2018-02-14 0:04 ` Thomas Monjalon
2018-02-14 14:25 ` Thomas Monjalon
2018-02-12 16:00 ` Jonas Pfefferle
[not found] ` <cover.1517848624.git.anatoly.burakov@intel.com>
2018-02-05 16:37 ` [dpdk-dev] [PATCH v3] eal: add function to return number of detected sockets Anatoly Burakov
2018-02-05 17:39 ` Burakov, Anatoly
2018-02-05 22:45 ` Thomas Monjalon
2018-02-06 9:28 ` Burakov, Anatoly
2018-02-06 9:47 ` Thomas Monjalon
2018-02-07 9:58 ` [dpdk-dev] [PATCH 18.05 v4] Add " Anatoly Burakov
2018-02-07 9:58 ` [dpdk-dev] [PATCH 18.05 v4] eal: add " Anatoly Burakov
2018-03-08 12:12 ` Bruce Richardson [this message]
2018-03-08 14:38 ` Burakov, Anatoly
2018-03-09 16:32 ` Bruce Richardson
2018-03-20 22:43 ` Thomas Monjalon
2018-03-21 4:59 ` gowrishankar muthukrishnan
2018-03-21 10:24 ` Burakov, Anatoly
2018-03-22 5:16 ` gowrishankar muthukrishnan
2018-03-22 9:04 ` Burakov, Anatoly
2018-03-22 10:58 ` [dpdk-dev] [PATCH v5] eal: provide API for querying valid socket id's Anatoly Burakov
2018-03-22 11:45 ` Burakov, Anatoly
2018-03-22 12:36 ` [dpdk-dev] [PATCH v6] " Anatoly Burakov
2018-03-22 17:07 ` gowrishankar muthukrishnan
2018-03-27 16:24 ` Thomas Monjalon
2018-03-31 13:35 ` Burakov, Anatoly
2018-04-02 15:27 ` Thomas Monjalon
2018-03-31 17:08 ` [dpdk-dev] [PATCH v7] " Anatoly Burakov
2018-04-04 22:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308121229.GA8660@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).