From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 638064C79 for ; Thu, 8 Mar 2018 13:12:34 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Mar 2018 04:12:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,440,1515484800"; d="scan'208";a="40232811" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.36]) by orsmga002.jf.intel.com with SMTP; 08 Mar 2018 04:12:31 -0800 Received: by (sSMTP sendmail emulation); Thu, 08 Mar 2018 12:12:30 +0000 Date: Thu, 8 Mar 2018 12:12:29 +0000 From: Bruce Richardson To: Anatoly Burakov Cc: dev@dpdk.org Message-ID: <20180308121229.GA8660@bricha3-MOBL3.ger.corp.intel.com> References: <750e30c6dcc7a22a87df9c56fb824042b1db984f.1517848624.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.3 (2018-01-21) Subject: Re: [dpdk-dev] [PATCH 18.05 v4] eal: add function to return number of detected sockets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Mar 2018 12:12:34 -0000 On Wed, Feb 07, 2018 at 09:58:36AM +0000, Anatoly Burakov wrote: > During lcore scan, find maximum socket ID and store it. This will > break the ABI, so bump ABI version. > > Signed-off-by: Anatoly Burakov > --- > > Notes: > v4: > - Remove backwards ABI compatibility, bump ABI instead > > v3: > - Added ABI compatibility > > v2: > - checkpatch changes > - check socket before deciding if the core is not to be used > > lib/librte_eal/bsdapp/eal/Makefile | 2 +- > lib/librte_eal/common/eal_common_lcore.c | 37 +++++++++++++++++++++---------- > lib/librte_eal/common/include/rte_eal.h | 1 + > lib/librte_eal/common/include/rte_lcore.h | 8 +++++++ > lib/librte_eal/linuxapp/eal/Makefile | 2 +- > lib/librte_eal/rte_eal_version.map | 9 +++++++- > 6 files changed, 44 insertions(+), 15 deletions(-) > Breaking the ABI is the best way to implement this change, and given the deprecation was previously announced I'm ok with that. Question: we are ok assuming that the socket numbers are sequential, or nearly so, and knowing the maximum socket number seen is a good approximation of the actual physical sockets? I know in terms of cores on a system, the core id's often jump - are there systems where the socket numbers do too? /Bruce