DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tomasz Duszynski <tdu@semihalf.com>
To: dev@dpdk.org
Cc: pablo.de.lara.guarch@intel.com, declan.doherty@intel.com,
	bruce.richardson@intel.com, Tomasz Duszynski <tdu@semihalf.com>,
	stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] crypto/mrvl: add MRVL to hash test cases
Date: Thu, 8 Mar 2018 14:27:17 +0100	[thread overview]
Message-ID: <20180308132717.GB22443@sh> (raw)
In-Reply-To: <1519829633-32295-1-git-send-email-tdu@semihalf.com>

This patch has been here for a while already. Should I respin it?

On Wed, Feb 28, 2018 at 03:53:53PM +0100, Tomasz Duszynski wrote:
> MRVL Crypto PMD supports most of the hash algorithms covered
> by test suites thus specific bits should be set in pmd_masks.
>
> Otherwise blockcipher authonly test returns success even though no
> real tests have been executed.
>
> Fixes: 84e0ded38ac5 ("test/crypto: add mrvl crypto unit tests")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> ---
>  test/test/test_cryptodev_hash_test_vectors.h | 66 ++++++++++++++++++----------
>  1 file changed, 44 insertions(+), 22 deletions(-)
>
> diff --git a/test/test/test_cryptodev_hash_test_vectors.h b/test/test/test_cryptodev_hash_test_vectors.h
> index 93dacb7..df9202f 100644
> --- a/test/test/test_cryptodev_hash_test_vectors.h
> +++ b/test/test/test_cryptodev_hash_test_vectors.h
> @@ -324,13 +324,15 @@ static const struct blockcipher_test_case hash_test_cases[] = {
>  		.test_descr = "MD5 Digest",
>  		.test_data = &md5_test_vector,
>  		.op_mask = BLOCKCIPHER_TEST_OP_AUTH_GEN,
> -		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL
> +		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
> +			    BLOCKCIPHER_TEST_TARGET_PMD_MRVL
>  	},
>  	{
>  		.test_descr = "MD5 Digest Verify",
>  		.test_data = &md5_test_vector,
>  		.op_mask = BLOCKCIPHER_TEST_OP_AUTH_VERIFY,
> -		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL
> +		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
> +			    BLOCKCIPHER_TEST_TARGET_PMD_MRVL
>  	},
>  	{
>  		.test_descr = "HMAC-MD5 Digest",
> @@ -341,7 +343,8 @@ static const struct blockcipher_test_case hash_test_cases[] = {
>  			BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
>  			BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |
>  			BLOCKCIPHER_TEST_TARGET_PMD_DPAA_SEC |
> -			BLOCKCIPHER_TEST_TARGET_PMD_QAT
> +			BLOCKCIPHER_TEST_TARGET_PMD_QAT |
> +			BLOCKCIPHER_TEST_TARGET_PMD_MRVL
>  	},
>  	{
>  		.test_descr = "HMAC-MD5 Digest Verify",
> @@ -352,19 +355,22 @@ static const struct blockcipher_test_case hash_test_cases[] = {
>  			BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
>  			BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |
>  			BLOCKCIPHER_TEST_TARGET_PMD_DPAA_SEC |
> -			BLOCKCIPHER_TEST_TARGET_PMD_QAT
> +			BLOCKCIPHER_TEST_TARGET_PMD_QAT |
> +			BLOCKCIPHER_TEST_TARGET_PMD_MRVL
>  	},
>  	{
>  		.test_descr = "SHA1 Digest",
>  		.test_data = &sha1_test_vector,
>  		.op_mask = BLOCKCIPHER_TEST_OP_AUTH_GEN,
> -		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL
> +		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
> +			    BLOCKCIPHER_TEST_TARGET_PMD_MRVL
>  	},
>  	{
>  		.test_descr = "SHA1 Digest Verify",
>  		.test_data = &sha1_test_vector,
>  		.op_mask = BLOCKCIPHER_TEST_OP_AUTH_VERIFY,
> -		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL
> +		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
> +			    BLOCKCIPHER_TEST_TARGET_PMD_MRVL
>  	},
>  	{
>  		.test_descr = "HMAC-SHA1 Digest",
> @@ -375,7 +381,8 @@ static const struct blockcipher_test_case hash_test_cases[] = {
>  			BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
>  			BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |
>  			BLOCKCIPHER_TEST_TARGET_PMD_DPAA_SEC |
> -			BLOCKCIPHER_TEST_TARGET_PMD_QAT
> +			BLOCKCIPHER_TEST_TARGET_PMD_QAT |
> +			BLOCKCIPHER_TEST_TARGET_PMD_MRVL
>  	},
>  	{
>  		.test_descr = "HMAC-SHA1 Digest Scatter Gather",
> @@ -394,7 +401,8 @@ static const struct blockcipher_test_case hash_test_cases[] = {
>  			BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
>  			BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |
>  			BLOCKCIPHER_TEST_TARGET_PMD_DPAA_SEC |
> -			BLOCKCIPHER_TEST_TARGET_PMD_QAT
> +			BLOCKCIPHER_TEST_TARGET_PMD_QAT |
> +			BLOCKCIPHER_TEST_TARGET_PMD_MRVL
>  	},
>  	{
>  		.test_descr = "HMAC-SHA1 Digest Verify Scatter Gather",
> @@ -408,13 +416,15 @@ static const struct blockcipher_test_case hash_test_cases[] = {
>  		.test_descr = "SHA224 Digest",
>  		.test_data = &sha224_test_vector,
>  		.op_mask = BLOCKCIPHER_TEST_OP_AUTH_GEN,
> -		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL
> +		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
> +			    BLOCKCIPHER_TEST_TARGET_PMD_MRVL
>  	},
>  	{
>  		.test_descr = "SHA224 Digest Verify",
>  		.test_data = &sha224_test_vector,
>  		.op_mask = BLOCKCIPHER_TEST_OP_AUTH_VERIFY,
> -		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL
> +		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
> +			    BLOCKCIPHER_TEST_TARGET_PMD_MRVL
>  	},
>  	{
>  		.test_descr = "HMAC-SHA224 Digest",
> @@ -442,13 +452,15 @@ static const struct blockcipher_test_case hash_test_cases[] = {
>  		.test_descr = "SHA256 Digest",
>  		.test_data = &sha256_test_vector,
>  		.op_mask = BLOCKCIPHER_TEST_OP_AUTH_GEN,
> -		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL
> +		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
> +			    BLOCKCIPHER_TEST_TARGET_PMD_MRVL
>  	},
>  	{
>  		.test_descr = "SHA256 Digest Verify",
>  		.test_data = &sha256_test_vector,
>  		.op_mask = BLOCKCIPHER_TEST_OP_AUTH_VERIFY,
> -		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL
> +		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
> +			    BLOCKCIPHER_TEST_TARGET_PMD_MRVL
>  	},
>  	{
>  		.test_descr = "HMAC-SHA256 Digest",
> @@ -459,7 +471,8 @@ static const struct blockcipher_test_case hash_test_cases[] = {
>  			BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
>  			BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |
>  			BLOCKCIPHER_TEST_TARGET_PMD_DPAA_SEC |
> -			BLOCKCIPHER_TEST_TARGET_PMD_QAT
> +			BLOCKCIPHER_TEST_TARGET_PMD_QAT |
> +			BLOCKCIPHER_TEST_TARGET_PMD_MRVL
>  	},
>  	{
>  		.test_descr = "HMAC-SHA256 Digest Verify",
> @@ -470,19 +483,22 @@ static const struct blockcipher_test_case hash_test_cases[] = {
>  			BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
>  			BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |
>  			BLOCKCIPHER_TEST_TARGET_PMD_DPAA_SEC |
> -			BLOCKCIPHER_TEST_TARGET_PMD_QAT
> +			BLOCKCIPHER_TEST_TARGET_PMD_QAT |
> +			BLOCKCIPHER_TEST_TARGET_PMD_MRVL
>  	},
>  	{
>  		.test_descr = "SHA384 Digest",
>  		.test_data = &sha384_test_vector,
>  		.op_mask = BLOCKCIPHER_TEST_OP_AUTH_GEN,
> -		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL
> +		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
> +			    BLOCKCIPHER_TEST_TARGET_PMD_MRVL
>  	},
>  	{
>  		.test_descr = "SHA384 Digest Verify",
>  		.test_data = &sha384_test_vector,
>  		.op_mask = BLOCKCIPHER_TEST_OP_AUTH_VERIFY,
> -		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL
> +		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
> +			    BLOCKCIPHER_TEST_TARGET_PMD_MRVL
>  	},
>  	{
>  		.test_descr = "HMAC-SHA384 Digest",
> @@ -493,7 +509,8 @@ static const struct blockcipher_test_case hash_test_cases[] = {
>  			BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
>  			BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |
>  			BLOCKCIPHER_TEST_TARGET_PMD_DPAA_SEC |
> -			BLOCKCIPHER_TEST_TARGET_PMD_QAT
> +			BLOCKCIPHER_TEST_TARGET_PMD_QAT |
> +			BLOCKCIPHER_TEST_TARGET_PMD_MRVL
>  	},
>  	{
>  		.test_descr = "HMAC-SHA384 Digest Verify",
> @@ -504,19 +521,22 @@ static const struct blockcipher_test_case hash_test_cases[] = {
>  			BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
>  			BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |
>  			BLOCKCIPHER_TEST_TARGET_PMD_DPAA_SEC |
> -			BLOCKCIPHER_TEST_TARGET_PMD_QAT
> +			BLOCKCIPHER_TEST_TARGET_PMD_QAT |
> +			BLOCKCIPHER_TEST_TARGET_PMD_MRVL
>  	},
>  	{
>  		.test_descr = "SHA512 Digest",
>  		.test_data = &sha512_test_vector,
>  		.op_mask = BLOCKCIPHER_TEST_OP_AUTH_GEN,
> -		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL
> +		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
> +			    BLOCKCIPHER_TEST_TARGET_PMD_MRVL
>  	},
>  	{
>  		.test_descr = "SHA512 Digest Verify",
>  		.test_data = &sha512_test_vector,
>  		.op_mask = BLOCKCIPHER_TEST_OP_AUTH_VERIFY,
> -		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL
> +		.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
> +			    BLOCKCIPHER_TEST_TARGET_PMD_MRVL
>  	},
>  	{
>  		.test_descr = "HMAC-SHA512 Digest",
> @@ -527,7 +547,8 @@ static const struct blockcipher_test_case hash_test_cases[] = {
>  			BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
>  			BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |
>  			BLOCKCIPHER_TEST_TARGET_PMD_DPAA_SEC |
> -			BLOCKCIPHER_TEST_TARGET_PMD_QAT
> +			BLOCKCIPHER_TEST_TARGET_PMD_QAT |
> +			BLOCKCIPHER_TEST_TARGET_PMD_MRVL
>  	},
>  	{
>  		.test_descr = "HMAC-SHA512 Digest Verify",
> @@ -538,7 +559,8 @@ static const struct blockcipher_test_case hash_test_cases[] = {
>  			BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
>  			BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |
>  			BLOCKCIPHER_TEST_TARGET_PMD_DPAA_SEC |
> -			BLOCKCIPHER_TEST_TARGET_PMD_QAT
> +			BLOCKCIPHER_TEST_TARGET_PMD_QAT |
> +			BLOCKCIPHER_TEST_TARGET_PMD_MRVL
>  	},
>  };
>
> --
> 2.7.4
>

--
- Tomasz Duszyński

  reply	other threads:[~2018-03-08 13:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-28 14:53 Tomasz Duszynski
2018-03-08 13:27 ` Tomasz Duszynski [this message]
2018-03-13  9:32   ` De Lara Guarch, Pablo
2018-03-14 10:13   ` De Lara Guarch, Pablo
2018-03-14 10:29     ` Tomasz Duszynski
2018-03-14 12:03       ` De Lara Guarch, Pablo
2018-03-14 13:12 ` [dpdk-dev] [PATCH v2] test/crypto: " Tomasz Duszynski
2018-03-26  8:28   ` De Lara Guarch, Pablo
2018-03-26  8:57   ` De Lara Guarch, Pablo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180308132717.GB22443@sh \
    --to=tdu@semihalf.com \
    --cc=bruce.richardson@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).