From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0043.outbound.protection.outlook.com [104.47.33.43]) by dpdk.org (Postfix) with ESMTP id 123305F22 for ; Thu, 8 Mar 2018 14:37:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=/n/d7OakumjUwoByb54S7fVtlPaKlbTNZZfICJTq3Vo=; b=I+3ZpzS2D4gLDaHLJIaYBNElaU86kwQzlC004W9ICbzLiWgDtkGt8BnXxOb4Y6n17JVtZvpQLMfYtdxbBoGbmRMZUsg7WD2Fwmw3VwZBPk5kVstdzFtsxwfTqiZfbRTdWGdKVwrdI1WksZCevIcdeZrjqFJID0DRk7KSxL+2zgM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from ltp-pvn (111.93.218.67) by DM5PR07MB3466.namprd07.prod.outlook.com (2603:10b6:4:67::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Thu, 8 Mar 2018 13:37:13 +0000 Date: Thu, 8 Mar 2018 19:06:13 +0530 From: Pavan Nikhilesh To: "Burakov, Anatoly" , keith.wiles@intel.com, jianfeng.tan@intel.com, andras.kovacs@ericsson.com, laszlo.vadkeri@ericsson.com, benjamin.walker@intel.com, bruce.richardson@intel.com, thomas@monjalon.net, konstantin.ananyev@intel.com, kuralamudhan.ramakrishnan@intel.com, louise.m.daly@intel.com, nelio.laranjeiro@6wind.com, yskoh@mellanox.com, pepperjo@japf.ch, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, olivier.matz@6wind.com Cc: dev@dpdk.org Message-ID: <20180308133612.GA16647@ltp-pvn> References: <20180308101805.GA9526@ltp-pvn> <20180308111337.GA11638@ltp-pvn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180308111337.GA11638@ltp-pvn> User-Agent: Mutt/1.9.3 (2018-01-21) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: PN1PR01CA0116.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::32) To DM5PR07MB3466.namprd07.prod.outlook.com (2603:10b6:4:67::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 01359cfa-cbe9-416f-b41c-08d584f9b692 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DM5PR07MB3466; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3466; 3:06ixNhvkI3tzGE2mlt4NekxI/nQWSwO9BeycVeQaGpnq0Idp/KNMfl0Zw1m4JE4sAroTMMw+EHL0lF0Xi3bhoWlNSsPCWtO5rRwm3u5BeaSJuzEltVPzBZKy6aW/OAah5anD2DRjKjPO2xdMfdormxQJNKcH2ZWwi2eFEVKADFsmEnRzBqcJcg4H8ggMXJythC4PT40yo7ZpeXfkMtFwtsVRrQyHGFcVF2hcCl0Ff8DdYN5G3WMK65ZZZvYf/fx5; 25:r/Y3HCsjTFWKYLdu8hUV73xwDwL3EG2QUNpHhgd4E34UiesrArSEMcyLOwGQYUFq8g+DaN1mQN/5u+T1Qsq/G0TmtG53DjxIm/mFhnUdDDbRgPFYlMHExB1ji4zUX+qbgfowS6KHC+htOz07+2CgTeXvp83SA3rtQD0bF525e88LrppyI6gvRINSaDwbrildQZtFbKq6tsbNQfqsatqw64eBpawXbePjO0WppM7DNblpfI9vSVDGuogIbK38NDbDgVN4C2K5/pSSZKBUgtqJo1Hx3uLdSebcYrr+/gdQmKZWu1Xj2BT55RC61D4d+F2crDgVQh9SJWGSNbuKQWddZw==; 31:CdsPgYpuVq3EhVGv1KnugSsstFcw6g9rWUOYtyVxEvgZFgYr24EBekCJ2W51uIU6Ilqu1bfDtdTmn48A/BTx4dCe7eTopU/LPNFc/ySrcMfHgceu9W2oX7ZuBWUEerTSJVjQlY9qkz1IFgwGPRz1wS25iK7oehgnmd4AJXN+GqoKGQ/HZ1cLO8QqB1dX+5H01a4i9X/fc1Oc9iyYEcKQQZDiphL59dXC1PBKztfJsDo= X-MS-TrafficTypeDiagnostic: DM5PR07MB3466: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3466; 20:gWKsoUUKUaYV1oBzDfoJJw28U6njWKxix8lTEq8I+l8h00Wp/rweF/6bpXVsLnEI345TISeRXJjR6ooSopcDEGkb93frNpXBw7SlmgkegYjFwExnI93Rm91hoH4YtIQ15LN9X4uKATOPE5obsjiLLaDMpRnYn6oROUwEKE/3EKXdnUS/F1M7lzCgUCWqMO3GXIBQELgMCKBdT4Pl+lnneaq1ZoKxbZEfRq92A98/Xq0YSGajy2CRxDc5lllcDKKUqHz1wJYcoJSVXVxNdBVrMOWJFhRq0Nrj4kBx0E48o5w8GBHYBAgHmKJWns1w2/cpG4DoQTkgcmZC585/Bs0VprJb0U1UNY4FokmpxQTPUpQMfxatGBgpNqgGI9hRf/CElTH5LtL1D/xHaAARpz3fGB/9EN86h13tp7MB32JYwqdZGngH0Z9fJoK+yjiAHGN4C89/UqFKF73oTHuRXMWjWF/vyWMcgacnne+LzlLutb34cqQ518z1D18M1zI6qce5G5KwvQgmTOR0jpPWpFB3htzOHnfVOXRQio53Ve+KrRLk7FhJOWxi6ErvsdwToBwnV2tjYxjb2TkNFXYsBn1GprFpYbmxwFt+LO/NviOO1dg=; 4:It5nZdsscdZ8pRqSwcPysPFcgSDslg3u+HMZMRdNZS3BlOEwR4G6BSp7r4ExUyhbK7g3gsxW000jcTngCEU9RLpAmct6skmJE/cKblgKBKvAmtTCfAk+O824J4AhbA1OefgUfmPuw0o2k0+2i3RIyCyOrF6PK5zPXLrBMDpNCxIgGTTKARxldaHbrDHhUlVWJvl8zpCMmdGHK07N34UftMH6KJoI75ZA+jiRsg/X1XwHTVPtUbdAeAYPTPjtRd90sd9w3Ts4kI5fEyx+RULugw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231220)(944501244)(52105095)(93006095)(6041288)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(6072148)(201708071742011); SRVR:DM5PR07MB3466; BCL:0; PCL:0; RULEID:; SRVR:DM5PR07MB3466; X-Forefront-PRVS: 060503E79B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(39380400002)(346002)(376002)(366004)(51914003)(189003)(199004)(66066001)(81166006)(8676002)(8936002)(81156014)(47776003)(106356001)(33716001)(16586007)(93886005)(59450400001)(53546011)(386003)(58126008)(68736007)(5009440100003)(316002)(76176011)(26005)(2950100002)(186003)(229853002)(6496006)(575784001)(16526019)(50466002)(33896004)(8656006)(42882007)(52116002)(33656002)(6306002)(966005)(72206003)(105586002)(4326008)(55016002)(1076002)(5890100001)(5660300001)(2906002)(23726003)(7416002)(478600001)(7736002)(25786009)(305945005)(97736004)(6246003)(53936002)(6116002)(9686003)(3846002)(53376002)(18370500001)(107986001)(921003)(42262002)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3466; H:ltp-pvn; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB3466; 23:n8hSXVVuO7mWIHZcLe4WXZzrfNwwp2bIFJCCLP71p?= =?us-ascii?Q?APsGUTKhLak8QNVS+2Ir7oFPN7u2VVwYSQi+AzCibMOifPZlVr6g5uc3aXLL?= =?us-ascii?Q?E/Z3U2tV0mFcGlccUE7M9x8/fSDtjxzY+x66b/AATBIqRiGJGk4jbKx4/m4d?= =?us-ascii?Q?Q60p5b+Xp1sIx25MXV4lycDnE3c+kJIfI0cCw/XtafOjC0/8mOqqrGpDtXNa?= =?us-ascii?Q?syLCY+jK+EX9ZAVRwuCSu6yWjjfTfhBzo8LhM+GaFyoDhKx7Sj415aWjUfEZ?= =?us-ascii?Q?wWmuUyWuLjeickqOVS8jRyEDknTi1PgUPZy3xvHd8OsSsm+aLMrc4WMUUYQL?= =?us-ascii?Q?zLWmyd3FWyqePugJFq+0BgD0bO99aWYlWeZOx/R5q3VX11ZyyOaS4jPRnrSY?= =?us-ascii?Q?0oEtdqcKiyzQc/DOIHS/PFhIiTWWDwyJwSfPcSXA8Hfp2mvGE2t1/wy2/W1A?= =?us-ascii?Q?kg0WgHIHh3hZg9Rf+McXXotgoVgJJEL30DCPTvJ/1hX8iJELICNqO8vL2cI3?= =?us-ascii?Q?D6EVOTlmUXpNwWi1Dk+IQATKXcOcOB+1W3TE4r+T291QArLQCuxysbESeEKS?= =?us-ascii?Q?XYjoGMTYJTE4HqSmySGP3nbjeRDMggk55g5MEqgi9qKqrZrUpyvTjDpFx4ms?= =?us-ascii?Q?QwHITii8xZNL9OPbBG/qse2AYle5UvF/iWvHoYIKL5u6iqXlMmDdfDAZGzv0?= =?us-ascii?Q?SfUPN+/tk4o5Wt9OrviaaiZzoI6mvvtxuPsQ7r+Pkp8Imy5xNGhHurZEq8FB?= =?us-ascii?Q?BAuqRZj1T4XKHOZlDFjYDyx+N9EwGhFB8K7ZWLoqlpT6VYBQ+BR5UW4cCpGV?= =?us-ascii?Q?6t59sor5ijb6Tqm1toJW8QQjQPh8oWzbSab5v5ZxjcQtw2I0irllGmmZvSXm?= =?us-ascii?Q?mSVYAvocELTdAZtH9pAQbYbdYoyc8HMidAmEQl9RwjgWO1knAkmz/oaAuwiO?= =?us-ascii?Q?4eAtJ6N98c9u1q/guo/n/+4thB6TS5CBA4dHYGp3zKrxCQtWPazjxeDuqtDN?= =?us-ascii?Q?taU++NBLm61OxocDykrJQS5FWmOUdxiLSod4f2u0e1CGvgQtkjZjZH4C0sTG?= =?us-ascii?Q?PbIbv/ea/Huz+HOCyx7Yfuft6cIKJfigLmPNWUpzLt1yzHJ47eiNNROMN+cw?= =?us-ascii?Q?ALp4zNKNn/RSTt+1iB/5sKCo3MLkcBxxthOzE7lahfJ1Gu/JkcR4klEMCB4X?= =?us-ascii?Q?B1reDolGMBrQmYbDlkAoXY71dlrOPjvFLZN/B+oxvZ0HtOIVvDSh5qGMq7Qs?= =?us-ascii?Q?VyQSVAxW9cFcR0WlV9F0a+uLFpJrcQ3uB/QtfWH6+2KqLaezjLQz2h+bOPB3?= =?us-ascii?Q?7qx8UeVQWv0mgrhdaxuefE5HS9gA1Tlg/MAYnmX95trOIn0d9jYHmUFfHz53?= =?us-ascii?Q?IVAF7pZCXU2uM8v6bDw2Kv/D1rj2Cnub74tAmA7nEDK2n/+aPCKALHhqNiIK?= =?us-ascii?Q?QmXC3MRah1hn4CXZgPoBaOtYuY+ZBPVxqxorQojIiPQ6vPBj0Uvc3lUqkjen?= =?us-ascii?Q?3qlL0slh+DOEBe4ZTcXUlElUqDC3diEXMjvWtA9kjrfUrTFlBGDcOxGKFiIZ?= =?us-ascii?Q?rgWeaTOxqCbpwyM1A=3D=3D?= X-Microsoft-Antispam-Message-Info: rH8+G/9JhlYGCksF5xm8FlEIJk/UxsgA5Hsc+Pv1Y8Z3/cjJg0C8fvp8EZYm12XRJ+aDsgca3CCC9xoA9Da3gaAi8MtZKX2pGB/DKRfrIZ1gTRMYjd52TDiV76eO3QS1oV58uUmUJlQknleW1fibzL13RAglgMUHFbCF3g9i2sfykKf+B7O8R5bWfFnf3/8Z X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3466; 6:jdFDT/VJPkkeY4NdJ01wQXObMwDBYwSCMaaQnMfItcDoDknDcea4xYCZz2Bm6cDH3DFuwk/oOlVmlLpzds9Eu86u1aAYLctgMps4uxC/6z9m/dEAJueErudLet/lQP/kv7sItIFJNwUF4sZcUsdEjkqTE/QY5b/7vIZ4ekxm/qTuzItcuhMLPyRTeDJVzwSwLH7N8mqsJiXYUmKmkmTR/IWeLy2xQqoG7QiMkDMbrvppqJKDhF9fSJf6JL4Ipkvuj72eC6j+ZwIR4pznWSEtAIWg+gYeZsNHY+xXBPQrNjTeNxYrQOfH4uB2Rz3dWuagilu+U9NLWBr043zc3QVe8V2PnTDChOUxwsPWMMsV1tQ=; 5:3DBsVt21GT2vkdTPjWXSsM39N164IuXD12Awu990oNHpiqE8vV1ROMAYu77m5l89xCUQQDads2pbeUNACrW5qM/+JS8pZIiz6cgWfFiBuznI+vOPu5PC0OATuMZmX1khAPdAgsmtItOhF9NMn/Vy3ll+Hp4PABpCct4156Kgyt8=; 24:BdN0mbRYxeACzz19ecDkuRKIblnpbmfTHdcbTC9iI1aPCZ2jdS0uRa+mpS1rotS39G+vNayaZ1rMwQFH8PX9s0w1M5+DCxdY6OJ33sjh0DQ=; 7:EHiBkwECQHCwq38FyBm3dXXzLUEaL4Qvih53qdmBnkImqZMazjXJUxalJhoBeXvA1KPPDOU0nTrYmK32ndRIDMwJ00xm44X9g0R34GCqDbzDBNifBbs2n0J/lSnXd9cyVrzjTDIcDzA6yFFOeQbBS0cimIFJL1dct2LukcZUE1WOqeIdCGkVDHulTfEK5Odu+EWq2Dqcmov71pAfMTd0MTmb1hH9tvpPbD9ODYkv8SEfL10RfTrTPrZp13FzQ7rW SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2018 13:37:13.3833 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 01359cfa-cbe9-416f-b41c-08d584f9b692 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3466 Subject: Re: [dpdk-dev] [PATCH v2 00/41] Memory Hotplug for DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Mar 2018 13:37:22 -0000 Hi Anatoly, We are currently facing issues with running testpmd on thunderx platform. The issue seems to be with vfio EAL: Detected 24 lcore(s) EAL: Detected 1 NUMA nodes EAL: No free hugepages reported in hugepages-2048kB EAL: Multi-process socket /var/run/.rte_unix EAL: Probing VFIO support... EAL: VFIO support initialized EAL: VFIO support not initialized EAL: probe driver: 177d:a053 octeontx_fpavf EAL: PCI device 0001:01:00.1 on NUMA socket 0 EAL: probe driver: 177d:a034 net_thunderx EAL: using IOMMU type 1 (Type 1) EAL: cannot set up DMA remapping, error 22 (Invalid argument) EAL: 0001:01:00.1 DMA remapping failed, error 22 (Invalid argument) EAL: Requested device 0001:01:00.1 cannot be used EAL: PCI device 0001:01:00.2 on NUMA socket 0 testpmd: No probed ethernet devices testpmd: create a new mbuf pool : n=251456, size=2176, socket=0 testpmd: preferred mempool ops selected: ring_mp_mc EAL: VFIO support not initialized EAL: VFIO support not initialized EAL: VFIO support not initialized Done This is because rte_service_init() calls rte_calloc() before rte_bus_probe() and vfio_dma_mem_map fails because iommu type is not set. Call stack: gdb) bt #0 vfio_dma_mem_map (vaddr=281439006359552, iova=11274289152, len=536870912, do_map=1) at /root/clean/dpdk/lib/librte_eal/linuxapp/eal/eal_vfio.c:967 #1 0x00000000004fd974 in rte_vfio_dma_map (vaddr=281439006359552, iova=11274289152, len=536870912) at /root/clean/dpdk/lib/librte_eal/linuxapp/eal/eal_vfio.c:988 #2 0x00000000004fbe78 in vfio_mem_event_callback (type=RTE_MEM_EVENT_ALLOC, addr=0xfff7a0000000, len=536870912) at /root/clean/dpdk/lib/librte_eal/linuxapp/eal/eal_vfio.c:240 #3 0x00000000005070ac in eal_memalloc_notify (event=RTE_MEM_EVENT_ALLOC, start=0xfff7a0000000, len=536870912) at /root/clean/dpdk/lib/librte_eal/common/eal_common_memalloc.c:177 #4 0x0000000000515c98 in try_expand_heap_primary (heap=0xffffb7fb167c, pg_sz=536870912, elt_size=8192, socket=0, flags=0, align=128, bound=0, contig=false) at /root/clean/dpdk/lib/librte_eal/common/malloc_heap.c:247 #5 0x0000000000515e94 in try_expand_heap (heap=0xffffb7fb167c, pg_sz=536870912, elt_size=8192, socket=0, flags=0, align=128, bound=0, contig=false) at /root/clean/dpdk/lib/librte_eal/common/malloc_heap.c:327 #6 0x00000000005163a0 in alloc_more_mem_on_socket (heap=0xffffb7fb167c, size=8192, socket=0, flags=0, align=128, bound=0, contig=false) at /root/clean/dpdk/lib/librte_eal/common/malloc_heap.c:455 #7 0x0000000000516514 in heap_alloc_on_socket (type=0x85bf90 "rte_services", size=8192, socket=0, flags=0, align=128, bound=0, contig=false) at /root/clean/dpdk/lib/librte_eal/common/malloc_heap.c:491 #8 0x0000000000516664 in malloc_heap_alloc (type=0x85bf90 "rte_services", size=8192, socket_arg=-1, flags=0, align=128, bound=0, contig=false) at /root/clean/dpdk/lib/librte_eal/common/malloc_heap.c:527 #9 0x0000000000513b54 in rte_malloc_socket (type=0x85bf90 "rte_services", size=8192, align=128, socket_arg=-1) at /root/clean/dpdk/lib/librte_eal/common/rte_malloc.c:54 #10 0x0000000000513bc8 in rte_zmalloc_socket (type=0x85bf90 "rte_services", size=8192, align=128, socket=-1) at /root/clean/dpdk/lib/librte_eal/common/rte_malloc.c:72 #11 0x0000000000513c00 in rte_zmalloc (type=0x85bf90 "rte_services", size=8192, align=128) at /root/clean/dpdk/lib/librte_eal/common/rte_malloc.c:81 #12 0x0000000000513c90 in rte_calloc (type=0x85bf90 "rte_services", num=64, size=128, align=128) at /root/clean/dpdk/lib/librte_eal/common/rte_malloc.c:99 #13 0x0000000000518cec in rte_service_init () at /root/clean/dpdk/lib/librte_eal/common/rte_service.c:81 #14 0x00000000004f55f4 in rte_eal_init (argc=3, argv=0xfffffffff488) at /root/clean/dpdk/lib/librte_eal/linuxapp/eal/eal.c:959 #15 0x000000000045af5c in main (argc=3, argv=0xfffffffff488) at /root/clean/dpdk/app/test-pmd/testpmd.c:2483 Also, I have tried running with --legacy-mem but I'm stuck in `pci_find_max_end_va` loop because `rte_fbarray_find_next_used` always return 0. HugePages_Total: 15 HugePages_Free: 11 HugePages_Rsvd: 0 HugePages_Surp: 0 Hugepagesize: 524288 kB Call Stack: (gdb) bt #0 find_next (arr=0xffffb7fb009c, start=0, used=true) at /root/clean/dpdk/lib/librte_eal/common/eal_common_fbarray.c:248 #1 0x00000000005132a8 in rte_fbarray_find_next_used (arr=0xffffb7fb009c, start=0) at /root/clean/dpdk/lib/librte_eal/common/eal_common_fbarray.c:700 #2 0x000000000052d030 in pci_find_max_end_va () at /root/clean/dpdk/drivers/bus/pci/linux/pci.c:138 #3 0x0000000000530ab8 in pci_vfio_map_resource_primary (dev=0xeae700) at /root/clean/dpdk/drivers/bus/pci/linux/pci_vfio.c:499 #4 0x0000000000530ffc in pci_vfio_map_resource (dev=0xeae700) at /root/clean/dpdk/drivers/bus/pci/linux/pci_vfio.c:601 #5 0x000000000052ce90 in rte_pci_map_device (dev=0xeae700) at /root/clean/dpdk/drivers/bus/pci/linux/pci.c:75 #6 0x0000000000531a20 in rte_pci_probe_one_driver (dr=0x997e20 , dev=0xeae700) at /root/clean/dpdk/drivers/bus/pci/pci_common.c:164 #7 0x0000000000531c68 in pci_probe_all_drivers (dev=0xeae700) at /root/clean/dpdk/drivers/bus/pci/pci_common.c:249 #8 0x0000000000531f68 in rte_pci_probe () at /root/clean/dpdk/drivers/bus/pci/pci_common.c:359 #9 0x000000000050a140 in rte_bus_probe () at /root/clean/dpdk/lib/librte_eal/common/eal_common_bus.c:98 #10 0x00000000004f55f4 in rte_eal_init (argc=1, argv=0xfffffffff498) at /root/clean/dpdk/lib/librte_eal/linuxapp/eal/eal.c:967 #11 0x000000000045af5c in main (argc=1, argv=0xfffffffff498) at /root/clean/dpdk/app/test-pmd/testpmd.c:2483 Am I missing something here? Thanks, Pavan. On Thu, Mar 08, 2018 at 04:43:38PM +0530, Pavan Nikhilesh wrote: > On Thu, Mar 08, 2018 at 10:46:46AM +0000, Burakov, Anatoly wrote: > > On 08-Mar-18 10:18 AM, Pavan Nikhilesh wrote: > > > Hi Anatoly, > > > > > > I am trying to verify this patchset and have encountered few issues. > > > > > > Few -Werror=maybe-uninitialized errors in eal_memalloc.c/eal_memory.c/ > > > eal_common_memzone.c files. > > > > Thanks for the heads up, i'll fix those in the next revision. Out of > > curiousity, which compiler version are you using? > > I'm using gcc 5.3.0. > > > > > > > > > diff --git a/lib/librte_eal/common/eal_common_memzone.c b/lib/librte_eal/common/eal_common_memzone.c > > > index a7cfdaf03..ad4413507 100644 > > > --- a/lib/librte_eal/common/eal_common_memzone.c > > > +++ b/lib/librte_eal/common/eal_common_memzone.c > > > @@ -321,7 +321,7 @@ rte_memzone_free(const struct rte_memzone *mz) > > > struct rte_fbarray *arr; > > > struct rte_memzone *found_mz; > > > int ret = 0; > > > - void *addr; > > > + void *addr = NULL; > > > unsigned idx; > > > > > > if (mz == NULL) > > > diff --git a/lib/librte_eal/linuxapp/eal/eal_memalloc.c b/lib/librte_eal/linuxapp/eal/eal_memalloc.c > > > index 1008faed6..32b0d5133 100644 > > > --- a/lib/librte_eal/linuxapp/eal/eal_memalloc.c > > > +++ b/lib/librte_eal/linuxapp/eal/eal_memalloc.c > > > @@ -570,7 +570,7 @@ eal_memalloc_alloc_page_bulk(struct rte_memseg **ms, int n, > > > unsigned int msl_idx; > > > int cur_idx, start_idx, end_idx, i, j, ret = -1; > > > #ifdef RTE_EAL_NUMA_AWARE_HUGEPAGES > > > - bool have_numa; > > > + bool have_numa = false; > > > int oldpolicy; > > > struct bitmask *oldmask = numa_allocate_nodemask(); > > > #endif > > > diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c > > > index f74291fb6..d37b4a59b 100644 > > > --- a/lib/librte_eal/linuxapp/eal/eal_memory.c > > > +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c > > > @@ -1386,9 +1386,9 @@ eal_legacy_hugepage_attach(void) > > > struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config; > > > struct hugepage_file *hp = NULL; > > > unsigned int num_hp = 0; > > > - unsigned int i; > > > + unsigned int i = 0; > > > int ms_idx, msl_idx; > > > - unsigned int cur_seg, max_seg; > > > + unsigned int cur_seg, max_seg = 0; > > > off_t size = 0; > > > int fd, fd_hugepage = -1; > > > > > > > > > > > > @Hemanth > > > Also, this patchset breaks dpaa/dpaa2 bus drivers (they rely on > > > `rte_eal_get_physmem_layout` that is depricated > > > http://dpdk.org/dev/patchwork/patch/34002/) > > > So, generic arm64 linuxapp build is broken. > > > > Should the deprecation notice have been accompanied with marking that > > function as __rte_deprecated? > > Yup that's the general sequence. > > > > > > > > > Regards, > > > Pavan. > > > > > > On Wed, Mar 07, 2018 at 04:56:28PM +0000, Anatoly Burakov wrote: > > > > This patchset introduces dynamic memory allocation for DPDK (aka memory > > > > hotplug). Based upon RFC submitted in December [1]. > > > > > > > > Dependencies (to be applied in specified order): > > > > - IPC bugfixes patchset [2] > > > > - IPC improvements patchset [3] > > > > - IPC asynchronous request API patch [4] > > > > - Function to return number of sockets [5] > > > > > > > > > > -- > > > > 2.7.4 > > > > > > > > > -- > > Thanks, > > Anatoly