From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f66.google.com (mail-pl0-f66.google.com [209.85.160.66]) by dpdk.org (Postfix) with ESMTP id BEA345F65 for ; Thu, 8 Mar 2018 23:14:29 +0100 (CET) Received: by mail-pl0-f66.google.com with SMTP id 93-v6so4106021plc.9 for ; Thu, 08 Mar 2018 14:14:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6DfjPHx7LBm5G9+Tckfc1U3LtuU3fX4ZqVaPO9kZw8s=; b=UIBxZFY0Ivmb/vU8OcU1eQkPoANukA/Mq+lu0/s5CDdEudVl6toxKg/7QKpkB5l+L4 uRJ79Vc047F6zf8j/5/lyBqndbi9066KeGjITItYZvnLgRFVSBmr165MuhDXlqArr44E IB6iL6ThKyW5Fpt2ATvyEusKPAQHP6Phl9G/vdN5vAXnuxdywnlNm7BVPnPOz1dQom1x rDBwWR4nhmY0IQlgUpMNu7EwYcVSfBoSuSjCeFDTKuyisBceqPu6QJA0RKn8tafiWk/w sQoxKKI4wLurgHyOWxeWJaLTijo8jRJSpBwzBIyk7R8W0qk2iZLnwfJMLhaFWzhUo+LN nJdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6DfjPHx7LBm5G9+Tckfc1U3LtuU3fX4ZqVaPO9kZw8s=; b=mAc0Zrivo61fM/Xb5JpQrUmAms/dkCY3EzdcRkKmySZ96Sg8qsNiWyItfsgtyfA2vX 6bLqXzvFKJIfdp48JYSSbio4dPTE/soTivRziINRIXUsGc/tYR0WYrtC1XuoKkBF8gUL /3IpXANqJnPzFbzxFV5sjd6RWgtIORuyiHppEWnlkti7MfsRXQ1+Ai/Fx689rvX3FYu2 Lc8sOLIzbGi3bZrWYgOvjDI2fvnW3iEfZxsAfJxK8TXDUnWP5+S5KnazIb/aYBgoux3i TuT8PhLPv/uUm6rhkxg7gPJt1VLPWjJj5xVyDixxTM3fuePTzbh/XlVLEciDTRcGUgRX lw1A== X-Gm-Message-State: APf1xPBINX0Nl2g++m/vyPaRr6YXlu+N0ZMpHKrJjqLhSzQdhtT20Y/r t4XLaBSa35C4Ix436lP9xy9UM6jZke4= X-Google-Smtp-Source: AG47ELvEQcH0qmla+1qxrH40QfZAvnY09GMUwb6PGvkbjsVAL0dPlu1RwWgvAZe4semBFrL7vd8EJg== X-Received: by 2002:a17:902:b903:: with SMTP id bf3-v6mr25765819plb.316.1520547268950; Thu, 08 Mar 2018 14:14:28 -0800 (PST) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id z28sm34977008pgc.69.2018.03.08.14.14.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Mar 2018 14:14:28 -0800 (PST) Date: Thu, 8 Mar 2018 14:14:27 -0800 From: Stephen Hemminger To: John Daley Cc: ferruh.yigit@intel.com, dev@dpdk.org, Hyong Youb Kim Message-ID: <20180308141427.08475f17@xeon-e3> In-Reply-To: <20180308024702.25974-9-johndale@cisco.com> References: <20180306014634.28398-2-johndale@cisco.com> <20180308024702.25974-1-johndale@cisco.com> <20180308024702.25974-9-johndale@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 08/10] doc: describe Rx bytes counter behavior for enic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Mar 2018 22:14:30 -0000 On Wed, 7 Mar 2018 18:47:00 -0800 John Daley wrote: > 'catch-all' filters should be added last. > > +- **Statistics** > + > + - ``rx_good_bytes`` (ibytes) always includes VLAN header (4B) and CRC bytes (4B). > + - When the NIC drops a packet because the Rx queue has no free buffers, > + ``rx_good_bytes`` still increments by 4B if the packet is not VLAN tagged or > + VLAN stripping is disabled, or by 8B if the packet is VLAN tagged and stripping > + is enabled. All drivers must provide consistent statistics! That means do NOT include CRC in the rx byte counts. Yes, several drivers in DPDK are already broken for this. Otherwise there are cases like packets being forwarded from HW NIC to virtio and the counts differ and customers think data is lots.