From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 0774E5F1A; Fri, 9 Mar 2018 18:56:41 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Mar 2018 09:56:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,446,1515484800"; d="scan'208";a="210288463" Received: from silpixa00399777.ir.intel.com (HELO silpixa00399777.ger.corp.intel.com) ([10.237.222.236]) by fmsmga006.fm.intel.com with ESMTP; 09 Mar 2018 09:56:37 -0800 From: Ferruh Yigit To: Jingjing Wu , Wenzhuo Lu Cc: dev@dpdk.org, Ferruh Yigit , stable@dpdk.org Date: Fri, 9 Mar 2018 17:56:31 +0000 Message-Id: <20180309175631.242976-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.13.6 Subject: [dpdk-dev] [PATCH] net/avf: fix link autoneg value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Mar 2018 17:56:42 -0000 Intention of the logic is: If ETH_LINK_SPEED_FIXED is set in dev_conf, set link_autoneg to ETH_LINK_FIXED, else set it to ETH_LINK_AUTONEG ETH_LINK_SPEED_FIXED value is 1, and ETH_LINK_FIXED is 0; Current logic is broken, fix it according above values. Fixes: 48de41ca11f0 ("net/avf: enable link status update") Cc: jingjing.wu@intel.com Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit --- drivers/net/avf/avf_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c index 4df661705..4442c3cd8 100644 --- a/drivers/net/avf/avf_ethdev.c +++ b/drivers/net/avf/avf_ethdev.c @@ -608,7 +608,7 @@ avf_dev_link_update(struct rte_eth_dev *dev, new_link.link_duplex = ETH_LINK_FULL_DUPLEX; new_link.link_status = vf->link_up ? ETH_LINK_UP : ETH_LINK_DOWN; - new_link.link_autoneg = !!(dev->data->dev_conf.link_speeds & + new_link.link_autoneg = !(dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED); if (rte_atomic64_cmpset((uint64_t *)&dev->data->dev_link, -- 2.13.6