From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f67.google.com (mail-pg0-f67.google.com [74.125.83.67]) by dpdk.org (Postfix) with ESMTP id 154065F36 for ; Tue, 13 Mar 2018 22:20:34 +0100 (CET) Received: by mail-pg0-f67.google.com with SMTP id x2so427741pgo.9 for ; Tue, 13 Mar 2018 14:20:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Et1bKqi5kpcgFCccLaSRHFbQeRYcqqyNtTnhwKMTDVc=; b=qnQCqzFqWRsjwV+LNjXL1ur3PToyKHq2NZ4YRg5Rsio2UhfEteYnBLcuKDV8A180Er uIa6yWOqV6wI1TgY1veF2/7gw2QbgoIpTMhy6QeAW0O41qRg3EvlcxXrHk0xWLLVZcvC yFsM3njjk5/f6XLs9Eo6TprxTwNxDV3w+4RfAh+z+GLI22zSUd8TkNsWjqACnUyolL6G zz85+n9BqlHyuHYUnGjrEA0guOJ3WoQW2ukGUPbfEwDsnSAwpnDo19k5U9TaKoRcP7wb E/pzN8ceV0NjpIoAHDVAEh5cd/5IHBATO83/LvjCutAN22rbwoaZD3HGgYmM5U5cWkfi mUhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Et1bKqi5kpcgFCccLaSRHFbQeRYcqqyNtTnhwKMTDVc=; b=Ols82j3lEo/w/3l0cuZjE6JAxoO8slFDcpJGHD+0Wqm9By6lxfDB8RaepW+/juyvr1 OM06h2xe9bCRFEGYptsEpXxeLDp2jV7v91Syoto2vDHI5PRRwMzsAA/a1piNnw/4Ab4H 5uRT0Mhfp6W5giuUmrrWqFgIS53KxvTMVTzZq6zpC1odPTpPBPlBKVTIA+NjZ8JcfRt4 l7ZBH1CGxfOPsXJuH8qj96Euo2Afrr0Fg/o+ObEk5fX2Kzd9sZemwPkjLCPnMRExSjWi b9982SEyDawAeh2VATT8oXTitj0jyVlyVTIWLboJvSCZyyV9NGEtEGYc9jkLBf3TjauT qbgg== X-Gm-Message-State: AElRT7GC5g2fvOuqttRZgKUeA8igCCytaF0vMnA5SCqzL7TKBxBrsRHY yY9KqoWe4uGfFe9Ss4YzwJ6eMrrWQWg= X-Google-Smtp-Source: AG47ELupvLpHbf6vIJf6N3VQN4POKBUXP5C84ARhSNF8U1Kx4sfv4ctBNXCFgkdx37tU14gceviWjQ== X-Received: by 10.101.86.138 with SMTP id v10mr1609784pgs.353.1520976033093; Tue, 13 Mar 2018 14:20:33 -0700 (PDT) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id l12sm1908575pfb.35.2018.03.13.14.20.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Mar 2018 14:20:33 -0700 (PDT) Date: Tue, 13 Mar 2018 14:20:31 -0700 From: Stephen Hemminger To: Nelio Laranjeiro Cc: Pascal Mazon , dev@dpdk.org Message-ID: <20180313142031.3fd01cbc@xeon-e3> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/2] lib: move Netlink wrapper to lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Mar 2018 21:20:34 -0000 On Tue, 13 Mar 2018 13:28:25 +0100 Nelio Laranjeiro wrote: > TAP PMD uses a wrapper to communicate with Netlink through a socket. This > wrapper can be useful for other PMD which may need to communicate also with > the Linux kernel via Netlink. > > This series moves this wrapper to the lib level to let any PMD implement use > it when necessary. > > Nelio Laranjeiro (2): > lib: move Netlink code into a common library > lib: add request Netlink messages > > MAINTAINERS | 3 + > config/common_base | 6 ++ > config/common_linuxapp | 1 + > drivers/net/tap/Makefile | 3 +- > drivers/net/tap/rte_eth_tap.c | 16 +-- > drivers/net/tap/tap_flow.c | 118 ++++++++++----------- > drivers/net/tap/tap_netlink.h | 42 -------- > drivers/net/tap/tap_tcmsgs.c | 28 ++--- > drivers/net/tap/tap_tcmsgs.h | 2 +- > lib/Makefile | 2 + > lib/librte_netlink/Makefile | 26 +++++ > lib/librte_netlink/meson.build | 13 +++ > .../librte_netlink/rte_netlink.c | 87 +++++++++++---- > lib/librte_netlink/rte_netlink.h | 43 ++++++++ > lib/librte_netlink/rte_netlink_version.map | 18 ++++ > lib/meson.build | 2 +- > mk/rte.app.mk | 1 + > 17 files changed, 263 insertions(+), 148 deletions(-) > delete mode 100644 drivers/net/tap/tap_netlink.h > create mode 100644 lib/librte_netlink/Makefile > create mode 100644 lib/librte_netlink/meson.build > rename drivers/net/tap/tap_netlink.c => lib/librte_netlink/rte_netlink.c (77%) > create mode 100644 lib/librte_netlink/rte_netlink.h > create mode 100644 lib/librte_netlink/rte_netlink_version.map > I might have raised this before; but having yet another netlink library is not a great advantage. It would be much better to use a common external library libmnl which is already available on every distribution.