From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f49.google.com (mail-lf0-f49.google.com [209.85.215.49]) by dpdk.org (Postfix) with ESMTP id 2D6445F65 for ; Wed, 14 Mar 2018 11:29:54 +0100 (CET) Received: by mail-lf0-f49.google.com with SMTP id u21-v6so3973688lfc.7 for ; Wed, 14 Mar 2018 03:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=rvwd4sMbojEqAimZwc4//kkKz7Dz1T0OKSX+x/mgUJg=; b=LPxK9AV7VQDk+7Pq58VBttvwRdkg/ZLCZzjBbuYBiI6uxI/pUiVBuYAuyCqc7g2+al ooN6RAZi10FfacllGSGkWAAZkIehBsShsjMyHl7T1X09bbWCWCAWSiD1Ucu2Y3jiPETw ofgE1Iht/N2hBMBL/y2DVaozPDa1ZOp/twKVsAPJiBRD01ucLGOx9EJ4LyIDX6GoQsRb nzj2ApPB4bYILRZWkmoiyRCmKMgZV6D4O4bHFuEAXJEZWUIa6uOFfTuBET3l8hyuJ1h2 cftrhabmqZwsB09SVv0MoaclarCJbTYZY6hxIh0czRykd9JyifPB4NcGpdgQluKNvMzi UWFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=rvwd4sMbojEqAimZwc4//kkKz7Dz1T0OKSX+x/mgUJg=; b=jHdySMmDE2d07ikXl3bh9iuDqFB2RV4SXBDgvvz5+xDneJ7ydWoKr8B6olmZKKd7/X FuVJgspA3sWhSXZ9BGxLqNqzZxyqMUQ8auV+C0VfaqlHZjRjspJ3Cj8IVaaAQ8Pqy3s8 tJl8c+dQDNPp8oO4PxHm9RixRfrNq0XXmhBLAUwOIlCtRy2c0RQv8xKIX7VUHCpvaW6E AyPUcRKlU1fMutuQxXqjAYNMbKV+/rnRJyMJgNP2bh0gFSh5PbzOEK7ySKc1+yrVM4sV LFFO428HvyvbUu762BuuVG2wMJct4D+gBrCmD6UrYKSMvIyuYqWLviDWDo8ptRDe7RXc Xn4g== X-Gm-Message-State: AElRT7E3YkZhgI9YGYIWFEBsGH3uuD9t0YvjqDfOqT5LFQNPgdJZlAlb rXLm0Q/1uBVOh9g+nXZh9TYI8w== X-Google-Smtp-Source: AG47ELsRFbVMNdUbGPAz7n0m7ANEvlXdyIFZKFgsDuVj4Q7XEnk5HZbuDthz96/XIKUbSIQiPRBCSg== X-Received: by 10.46.86.1 with SMTP id k1mr2868604ljb.28.1521023393766; Wed, 14 Mar 2018 03:29:53 -0700 (PDT) Received: from localhost (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id g64sm361325ljf.69.2018.03.14.03.29.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Mar 2018 03:29:52 -0700 (PDT) Date: Wed, 14 Mar 2018 11:29:52 +0100 From: Tomasz Duszynski To: "De Lara Guarch, Pablo" Cc: Tomasz Duszynski , "dev@dpdk.org" , "Doherty, Declan" , "Richardson, Bruce" , "stable@dpdk.org" Message-ID: <20180314102952.GA8527@sh> References: <1519829633-32295-1-git-send-email-tdu@semihalf.com> <20180308132717.GB22443@sh> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: User-Agent: Mutt/1.5.23.1 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] crypto/mrvl: add MRVL to hash test cases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 10:29:55 -0000 On Wed, Mar 14, 2018 at 10:13:58AM +0000, De Lara Guarch, Pablo wrote: > Hi Tomasz, > > > -----Original Message----- > > From: Tomasz Duszynski [mailto:tdu@semihalf.com] > > Sent: Thursday, March 8, 2018 1:27 PM > > To: dev@dpdk.org > > Cc: De Lara Guarch, Pablo ; Doherty, > > Declan ; Richardson, Bruce > > ; Tomasz Duszynski ; > > stable@dpdk.org > > Subject: Re: [PATCH] crypto/mrvl: add MRVL to hash test cases > > > > This is targetting the crypto tests, so title should be "test/crypto: ...= " Ack. > > > > This patch has been here for a while already. Should I respin it? > > > > On Wed, Feb 28, 2018 at 03:53:53PM +0100, Tomasz Duszynski wrote: > > > MRVL Crypto PMD supports most of the hash algorithms covered by test > > > suites thus specific bits should be set in pmd_masks. > > > > > > Otherwise blockcipher authonly test returns success even though no > > > real tests have been executed. > > > > > > > Fixes: 84e0ded38ac5 ("test/crypto: add mrvl crypto unit tests") > > > Cc: stable@dpdk.org > > I don't think this is a fix, so I would remove the fixes and CC stable li= nes. Why? I think this should have been here since introduction on mrvl/cryto. If you take a look at 84e0ded38ac5 there is test called: test_authonly_mrvl_all() which runs blockcipher tests with BLKCIPHER_AUTHONLY_TYPE flag. Since MRVL pmd flag was missing from pmd_mask in blockcipher_test_case_hash_test_cases table tests were not run. Moreover overall_status variable was not touched thus test suite completed without errors. > > Thanks, > Pablo > > > > > > > Signed-off-by: Tomasz Duszynski > -- - Tomasz Duszy=C5=84ski