DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: Liron Himi <lironh@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] Sharing Common libs between PMDs
Date: Wed, 14 Mar 2018 15:04:31 +0000	[thread overview]
Message-ID: <20180314150431.GA7196@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20180314145538.GA2482@jerin>

On Wed, Mar 14, 2018 at 08:25:45PM +0530, Jerin Jacob wrote:
> -----Original Message-----
> > Date: Wed, 14 Mar 2018 09:34:40 +0000
> > From: Liron Himi <lironh@marvell.com>
> > To: "dev@dpdk.org" <dev@dpdk.org>
> > CC: Liron Himi <lironh@marvell.com>
> > Subject: [dpdk-dev] Sharing Common libs between PMDs
> > 
> > Hi,
> > 
> > We have several PMDs in DPDK that are using the same underlying common libraries.
> > In addition, we have plans to add some new common service into DPDK that already introduces too much complexity with the way that the code is written now.
> > Therefore, we would like to move all our common functions calls into one shared/common folder in DPDK and we need to find proper place for this purpose.
> > 
> > Can you suggest on such a place?
> 
> There was an attempt to create "driver/common" but latter the common code
> for NXP HW device got moved to drivers/bus/dpaa/. Linux kernel has
> something called "driver/soc", I think, "driver/soc" may be more appropriate.
> 
> Currently DPDK's driver build dependency is in the following order
> (bus, mempool, net, crypto, event).
> Other than driver/common or driver/soc, one option could be to
> - Move the common code to bus or mempool
> and
> - Across the drivers, include the header files through CFLAGS if the common code
>   is in header file
> http://dpdk.org/browse/dpdk/tree/drivers/event/octeontx/Makefile#n13
> 
Given that this seems to be a recurring problem, I think having a
drivers/common folder may not be a bad thing.

/Bruce

  reply	other threads:[~2018-03-14 15:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-14  9:34 Liron Himi
2018-03-14 14:55 ` Jerin Jacob
2018-03-14 15:04   ` Bruce Richardson [this message]
2018-03-14 16:11     ` Trahe, Fiona
2018-03-14 17:38       ` Shreyansh Jain
2018-03-14 17:50         ` Jerin Jacob
2018-03-14 18:13           ` Trahe, Fiona
2018-03-15  6:58             ` Hemant Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180314150431.GA7196@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=lironh@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).