From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 681355681 for ; Wed, 14 Mar 2018 16:04:38 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2018 08:04:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,470,1515484800"; d="scan'208";a="34974561" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.118]) by orsmga003.jf.intel.com with SMTP; 14 Mar 2018 08:04:35 -0700 Received: by (sSMTP sendmail emulation); Wed, 14 Mar 2018 15:04:31 +0000 Date: Wed, 14 Mar 2018 15:04:31 +0000 From: Bruce Richardson To: Jerin Jacob Cc: Liron Himi , "dev@dpdk.org" Message-ID: <20180314150431.GA7196@bricha3-MOBL.ger.corp.intel.com> References: <20180314145538.GA2482@jerin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180314145538.GA2482@jerin> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] Sharing Common libs between PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 15:04:39 -0000 On Wed, Mar 14, 2018 at 08:25:45PM +0530, Jerin Jacob wrote: > -----Original Message----- > > Date: Wed, 14 Mar 2018 09:34:40 +0000 > > From: Liron Himi > > To: "dev@dpdk.org" > > CC: Liron Himi > > Subject: [dpdk-dev] Sharing Common libs between PMDs > > > > Hi, > > > > We have several PMDs in DPDK that are using the same underlying common libraries. > > In addition, we have plans to add some new common service into DPDK that already introduces too much complexity with the way that the code is written now. > > Therefore, we would like to move all our common functions calls into one shared/common folder in DPDK and we need to find proper place for this purpose. > > > > Can you suggest on such a place? > > There was an attempt to create "driver/common" but latter the common code > for NXP HW device got moved to drivers/bus/dpaa/. Linux kernel has > something called "driver/soc", I think, "driver/soc" may be more appropriate. > > Currently DPDK's driver build dependency is in the following order > (bus, mempool, net, crypto, event). > Other than driver/common or driver/soc, one option could be to > - Move the common code to bus or mempool > and > - Across the drivers, include the header files through CFLAGS if the common code > is in header file > http://dpdk.org/browse/dpdk/tree/drivers/event/octeontx/Makefile#n13 > Given that this seems to be a recurring problem, I think having a drivers/common folder may not be a bad thing. /Bruce