From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0055.outbound.protection.outlook.com [104.47.37.55]) by dpdk.org (Postfix) with ESMTP id 89761A486 for ; Wed, 14 Mar 2018 18:50:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=7bhxVbIseO9GUWi4aJAVkZbIQhsuTJETWagy017TMxU=; b=RBBOgI0qlXvFcfcEGMEgB3wcJMm55YzQgNyVOYA+1xZHolkxwWYenCihOdjcJnmFGTyv3ZsXmVyQfG0TUEhcNgS00cakz1BoisjfiBR1N1qcJM7EULtn0Bt//Vk97dgnHuW8EdE3vv4M/Q0kzTmPIr3Tbi6gHLhtmrSlVrD5AFc= Received: from jerin (171.76.92.136) by CO2PR07MB2518.namprd07.prod.outlook.com (10.166.200.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Wed, 14 Mar 2018 17:50:15 +0000 Date: Wed, 14 Mar 2018 23:20:01 +0530 From: Jerin Jacob To: Shreyansh Jain Cc: "Trahe, Fiona" , "Richardson, Bruce" , Liron Himi , "dev@dpdk.org" , "Jozwiak, TomaszX" Message-ID: <20180314175000.GA15532@jerin> References: <20180314145538.GA2482@jerin> <20180314150431.GA7196@bricha3-MOBL.ger.corp.intel.com> <348A99DA5F5B7549AA880327E580B4358934B1C5@IRSMSX101.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [171.76.92.136] X-ClientProxiedBy: PN1PR01CA0079.INDPRD01.PROD.OUTLOOK.COM (10.174.144.147) To CO2PR07MB2518.namprd07.prod.outlook.com (10.166.200.152) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9b2654b7-6ecc-4555-1330-08d589d40cb8 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:CO2PR07MB2518; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 3:iFUjgphGHIaFm35C6cnmrGvE3C3liXs47zFGPaVM2DCKXlI3O0EeXWkj1ri4ZU2cGYw+2hZLvXplOXO35zPZOwHMCYbC08+J/jlgW6sKdeZlJ9FV04sMdz2AaUOeIV7PC2UYvFTMfd/kvPykfyFJzPnKKFSW1nPi3EmJVPB3XQfQOcbd2Bnts3/FnmR6BkMk/hzd4vRFXNY5JoPbFTPyfUMwFsP06A4+Z3CD851ZUgDeb4p2nR2HMKrbxnBLFCYm; 25:F1I91UAKHl5SfTltquNVL3JkRfqgG3CKOFY7NSM2hF09UDYteK/BLRHeTn6yjSStYh4/DTTKkR0HbwKCosQ3Hly3sTlDZdJlnlBkAMNJNnNReaJL4KkfqNOqt9xNV20mQu/uv5T88I+3xVbGIonekGpOvSdi9IRYU7JFwuccefENLOyeDo8svETC4C3YuwvbnR0DudKLEyPexOccMQdGOYLn4rUTuFb5xOnJc06O7GOtgw8WmaqGP2pqA2r1MKzy3FVeJguUWhhFg9VUb7MkSp/JTmrI+gp3YlW+k07fjtZ2u2g6mceme6/ZrbgcffGWIS00746HgrUDp+B8hM8YwA==; 31:XOoSb7uvfKBUaWS+xgUj7j8+Jt0h8BXK13Ilrsgc+sBkwtA540WcHihTjbbIZf5cdzASpcXVrHVCaFKuOfdXu7sSBPrpAXS+1pEwnjlsrh6s3ZprJunTf0N2Q5IAggsiWp+ncaRoH92IL4LGvwpO83CRrAKH3r59lnn7Pwqh/YAfwwlUT/jqXglCWYga725DsWQm9puG62Xtn+Jiqm1L0wmOa6dtq2UWo0uiXyka73E= X-MS-TrafficTypeDiagnostic: CO2PR07MB2518: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 20:IGvqj6fzrBYnZCxbsGaMTC7WVFPfpMDSEVhCryybnznqJpFnY1DYoBsQJU/ZPCv566UjxYXvvx9TDH2W2bWS77P4awcR8tC+4pzXAiCagn/HokSPP1pIjtE/GoBCsdXeUINxuIUsm6GpWPOVwhZq5IawtcEaUNrpRf//61ZfD5Ydtef//oIuJyvRrEKWezCBAhLx+n34Ey0K3tPy6JaE+buWsn5WadKvELp/zN6wcaytzg0FSk1SeA+MWnq6HlaNg2vvUW8OlHrsUJb0dcA7XA7K9JChYtQkCrvYT7JoC53po9kO3HiIH7zV0H8OqI0wzNeAWwbWRCnR5GCFybFRUsv7gysA5bE5oY+mawDDR2x07KGJ+LAQrawGtxUAbRVD7QF4pA8pVhBVb2eGyr99N8qkLMZc/3WaIo7aBqnJj+nZlMIh+4aJbZzRPOcnJG7yihjI8j97fgZllGDOZBc7bCBUD029NJ16XH3fbah7/Bk+fsxhsWvJBq4Yi1ESRDw0HFO5mSsmnixNC+yu3BMDLdrf9LAkLYyPnNcrlENigEVkfhKrP7bbpOvGqFHrZ480k8/g9wScqM9cFcO2m2oAUbjoHdhLGTVJQR7u9HEsP2Q= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(189930954265078)(185117386973197)(45079756050767)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(3231221)(944501244)(52105095)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:CO2PR07MB2518; BCL:0; PCL:0; RULEID:; SRVR:CO2PR07MB2518; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 4:Mn4awKwlTFhnTsrcTxAb/Cjt0ckqwZrXfuFTbPWAXrSa+Ros9NjtyVYRktencqyjgdzr8k/u1ENetwYNzKwDTcnH4jX4OypnvarfzLL7O60xoWe71d1CLT8JLdii9qbVRNpENeJvGcXNLBJVLxyPccHURSuBUjpxnqyCQBkcVAtS0NZMLW2AFL/WIrXrUCNFdfLxljtQeL3u0vkg00O4SWTDc6DMc8qyFuA0pgNe1GB7goxQ+fAKVEltB27cS1WjgsZQWvfupfWuRfU6NWHQ8/qsBf98S5Q1l6aND9lUx2s0uQ5oq/wH57rivGm35ymtDj3QxVjXn4TmpxYqIrl19PKRPB1dxJM4ipY0Uelw0xbZRoq5ECZ7UPRTS6bvdeF1LBEwPDPpjscT9IC6eBykLEdsbInQeo3c84nKiYfkKXQ= X-Forefront-PRVS: 0611A21987 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(39860400002)(346002)(39380400002)(376002)(366004)(396003)(189003)(13464003)(199004)(5660300001)(76176011)(478600001)(53546011)(16526019)(316002)(66066001)(42882007)(6916009)(966005)(229853002)(50466002)(6666003)(7736002)(72206003)(59450400001)(16586007)(2950100002)(33896004)(6116002)(45080400002)(33716001)(97736004)(2906002)(386003)(93886005)(305945005)(186003)(8676002)(25786009)(26005)(47776003)(81156014)(8936002)(23726003)(54906003)(1076002)(3846002)(55016002)(81166006)(33656002)(106356001)(6306002)(52116002)(68736007)(53936002)(8656006)(6246003)(105586002)(4326008)(9686003)(6496006)(58126008)(18370500001)(21314002)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR07MB2518; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CO2PR07MB2518; 23:BJfW/Z6eBRLcPw/vSBEmVELiR4RYB1RRvpPlmw8TX?= =?us-ascii?Q?03h1P5WtDmc1xSrhf5lp3Wgs9kDvpGDa1Oz/xx1zliKyDBN9Hie4FQJ7QEcX?= =?us-ascii?Q?c2j6asi3mOXxMrGwPdY2+M1mRiGksu4d/n9mZXc+zBKoI7Q0/4r8MvjxUYle?= =?us-ascii?Q?ONSWRWaOEPHDvg69QHssP3VpW0HIaq1WkGjITtj6syxGKnDNomrsk0ILluWL?= =?us-ascii?Q?d/ZJBCz+ZGPL03Tl+m/PLmKbpjcUoS8LiWApyL/B8x04MDRqfNuBFcSlZpXw?= =?us-ascii?Q?7+Nq6AambECH/CquHH1Z0MZDWzpOUAx5XANzzJGpRMu/AQhwzIj69JrfAYPA?= =?us-ascii?Q?+WBmautWmmIjFqaYSHDrI1RVW8Rqn3iyhHQvehVibcxYt9S3jRY4RRCEX0i/?= =?us-ascii?Q?9+qgEBcIIdzZeSkmjvhtwjBnuO2FwagKps5HOuSc15EfWKaABdNN/LNdKGL4?= =?us-ascii?Q?nPQ1KtdOG52qw4GKTymLxTQE5DnsG/yu5UV+Psc91SRNuE8IH91Jbe6JQBMx?= =?us-ascii?Q?sEazERcpulns+LHskGyvDKocHgo7RpNNLNTlgMwu25rqfQKNoB8w5UqcOY8j?= =?us-ascii?Q?v6vDVYXBfuVlJosSx9y+Ua3mBL8wl0pSg27Lt/O6hIyGIJAtWtoUR0IbyjuL?= =?us-ascii?Q?d8ExtptO3cAsSzo7rlGk6zr+/+UPMCZ+G3MpFqZh4US5CdxPVpIt5ti5K6Jd?= =?us-ascii?Q?j6Q53IxsGzgs0ijIOUJO3H4zdMFKQskmu5yF0L0GLuoRqglMefm+snqDNKqa?= =?us-ascii?Q?2cdWcfGB7b3/dD3l2yP45eN/dd/FDI5By/jEHC5JAT/Ew5LS1uj1fQJDb/aF?= =?us-ascii?Q?gh53iE5jrYy0OnY6urGWRrSqcE5HJEQyj0OH+K3xvxG1eoKaWLXgESy0awpU?= =?us-ascii?Q?Q6rAC2YuUac6HEyJhn/rakPXb6ExXNbhvgsJkex2/oeGyxzqitXDEc3Ioy18?= =?us-ascii?Q?enNt1O4WBP2fhELhlCIQ0apfv8B2FRkvo88B0m5dTwFZ5qDSjTHjkpwpukbq?= =?us-ascii?Q?SJ/Yo5n94ouyG3/n/Z3wZs7qYEag7vrD9OyK6YV/WATsG4mTGeR4HzSjzUro?= =?us-ascii?Q?2pD7y8rUOZA8TjdbBYvgWRpLOUuf+ARf66zr7ciBhj3CbA/dWechDW1p7mHi?= =?us-ascii?Q?ct0ofbeucI26G9soFFWCOgoS87O9CgsOeuabixEBJs+5pMNSaitTIJ1vhAbZ?= =?us-ascii?Q?/xZ/RjpV8bzBJcySS9D9+Rt8kI6utq7Wb8SVc+I/kZdKbbkXaDUlPyaFOsqo?= =?us-ascii?Q?3HqsvjPslWnDcB0FENq8lrAHp53nLVjWTvWswKDkFXnNf5rdbFFU9QtxAEq9?= =?us-ascii?Q?KZe6C8mDWYu1R34OeGFrYN395xEdrivi/T2Ek35YTci6A5QwaxBGjwVO3Th7?= =?us-ascii?Q?sjec0g798AJVRBzJ/GaOyXqJ4oLkkRLNDuHrcZV7BtZ4k9JYoA+FW07if4mC?= =?us-ascii?Q?K/wmKOx4XIobuC5pYNoJLxLfF2aXF2Y+bo+dkr7Df0fCNzCMryI7f6kaB33d?= =?us-ascii?Q?zMUQYunqmaccDJXqMrticQ+XYPYynSFmPKDCsCbeCGX7yWwJnMYSRVrYnsN9?= =?us-ascii?Q?UNwv1LdOzolbh85qw=3D=3D?= X-Microsoft-Antispam-Message-Info: +2zIkFDhk/OkO/7de43ChoMOsHPPq6+AuBlVVDlUPtX2PYztq464qglI0PWBF305QG023bQKND5mgt7vYGEoq6IxSh1OQZJ0IegtC+yPoZpNdU1dXXBxyEnjYkptXUryKS9ZErazPw0zLDhMF8ZH9B7i/Tvj/eKyTFFTBlAI/Iw7GDH4nFRQDAHLDg3TJpLq X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2518; 6:1r6kPnV2ngehproRMhnZpfcFXOgiwE4oPbEK7kPL4ZuGeyEfwzUYCou/v4/usXeWLROWvWUKAMVrqb7vnb/tIGDmz1TJPWMeVC2I+s3ci0In/0bVMsYzb6o+7O0NYP7ODEyig9qBhYWP5aTC3QfcuGwgfVrQ+W23OKMcJJ0Me4y9p0bvpm/EmyEnR4KMFck2tqNNNJ4y6I34zm1SzslYjUNYgtiHg/PjNYCulc3nhPKjOqWVNxvs+g/BDlRSSHv8pDzJIxMYNWQCQN1xNmmIQ9JZsbpXa7e4wQ8jEjRe0eyWzHak0Kncbz/OhEz/uNi9q4soZXMl6xZQ1CIVVRGBSIOTyzT+0/O8aP5TizfUs34=; 5:KJ5YpfZ0ZsoOJhB9yAPKWZ96fd2hJ+siGfl/GWYc/gQ+WPe5e9ZCKiO8e8woDkc5jmGZokEe3omGFkxUtD1pDXXXKjfMXpV7qVMqKw60WFRHIFeR6LzF0GOZNYEuYmurwYSz3FPZLQfwiRTqN/W/G47AybXB//jjf/0UG3gudqY=; 24:Sz92nJQvmzU8AelgRCFFhQzSTOFIbW0t/JdDke80TrUHuhg5abthiEW4Rryt46kfFb+EWa08D2eoM0APZ2QQwZdnQ3g/LheoStsLnYoVReA=; 7:llrmkJtHIjmSco6FD9UPy0krdVJTJsYLzX+iyNyzCN0nWi4kuk8311m34WUuARdwdpXC9VCmiE2EUd/od9dSu3TjQ79Se1irKabZTQJYoPOcz8D4Z86GQOpy8DLhQvVkWlN2Mm2xIYIzx2ECo8lAGnIcRKaowGnfzEe4IUQEAc6affuPdYy/KjtdvKeC+vRXDAtS19uPZJcWwjGsDn7GkiEmXJW0rjdti1oOBDiU6INmA21lR9A2MZT+A+22FGAq SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2018 17:50:15.8192 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9b2654b7-6ecc-4555-1330-08d589d40cb8 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2518 Subject: Re: [dpdk-dev] Sharing Common libs between PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 17:50:23 -0000 -----Original Message----- > Date: Wed, 14 Mar 2018 17:38:14 +0000 > From: Shreyansh Jain > To: "Trahe, Fiona" , "Richardson, Bruce" > , Jerin Jacob > CC: Liron Himi , "dev@dpdk.org" , > "Jozwiak, TomaszX" > Subject: RE: [dpdk-dev] Sharing Common libs between PMDs > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Trahe, Fiona > > Sent: Wednesday, March 14, 2018 9:41 PM > > To: Richardson, Bruce ; Jerin Jacob > > > > Cc: Liron Himi ; dev@dpdk.org; Trahe, Fiona > > ; Jozwiak, TomaszX > > Subject: Re: [dpdk-dev] Sharing Common libs between PMDs > > > > > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > > > Sent: Wednesday, March 14, 2018 3:05 PM > > > To: Jerin Jacob > > > Cc: Liron Himi ; dev@dpdk.org > > > Subject: Re: [dpdk-dev] Sharing Common libs between PMDs > > > > > > On Wed, Mar 14, 2018 at 08:25:45PM +0530, Jerin Jacob wrote: > > > > -----Original Message----- > > > > > Date: Wed, 14 Mar 2018 09:34:40 +0000 > > > > > From: Liron Himi > > > > > To: "dev@dpdk.org" > > > > > CC: Liron Himi > > > > > Subject: [dpdk-dev] Sharing Common libs between PMDs > > > > > > > > > > Hi, > > > > > > > > > > We have several PMDs in DPDK that are using the same underlying > > common libraries. > > > > > In addition, we have plans to add some new common service into > > DPDK that already introduces too > > > much complexity with the way that the code is written now. > > > > > Therefore, we would like to move all our common functions calls > > into one shared/common folder in > > > DPDK and we need to find proper place for this purpose. > > > > > > > > > > Can you suggest on such a place? > > > > > > > > There was an attempt to create "driver/common" but latter the > > common code > > > > for NXP HW device got moved to drivers/bus/dpaa/. Linux kernel has > > > > something called "driver/soc", I think, "driver/soc" may be more > > appropriate. > > > > > > > > Currently DPDK's driver build dependency is in the following order > > > > (bus, mempool, net, crypto, event). > > > > Other than driver/common or driver/soc, one option could be to > > > > - Move the common code to bus or mempool > > > > and > > > > - Across the drivers, include the header files through CFLAGS if > > the common code > > > > is in header file > > > > > > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpdk. > > org%2Fbrowse%2Fdpdk%2Ftree%2Fdrivers%2Fevent%2Focteontx%2FMakefile%23n1 > > 3&data=02%7C01%7Cshreyansh.jain%40nxp.com%7Cfa7ba7a1dfd94b9336c008d589c > > 63dd7%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636566406955506340&s > > data=MkxFJUuHPuBFIqAgjmUzUcgRms9WTsxkkMQah4kGAlM%3D&reserved=0 > > > > > > > Given that this seems to be a recurring problem, I think having a > > > drivers/common folder may not be a bad thing. > > > > > > /Bruce > > We've been grappling with the same problem for QAT driver. > > A variant we were about to propose was to rename drivers/bus to > > drivers/lib. > > And possibly move drivers/mempool to drivers/lib > > As the rest of the drivers/xxx are actually PMDs, while mempool and bus > > are libs > > on which other drivers depend. > > I'm ok with adding a drivers/common instead, but the above seems > > cleaner. > > In my opinion, I think we should add a common/ without modifying the bus/mempool structure. I agree that bus/mempool are not standalone PMDs themselves, but they are not libraries either in true sense - they /plug/ into the eal framework and *may* provide service to drivers. > > As for common/ - that gets a +1 from me. +1 for drivers/common