From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id C7B0F6CA2 for ; Fri, 16 Mar 2018 16:51:44 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Mar 2018 08:51:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,316,1517904000"; d="scan'208";a="26278795" Received: from silpixa00399777.ir.intel.com (HELO silpixa00399777.ger.corp.intel.com) ([10.237.222.236]) by orsmga006.jf.intel.com with ESMTP; 16 Mar 2018 08:51:40 -0700 From: Ferruh Yigit To: John McNamara , Marko Kovacevic Cc: dev@dpdk.org, Ferruh Yigit , Thomas Monjalon , shahafs@mellanox.com, Patil, Harish Date: Fri, 16 Mar 2018 15:51:38 +0000 Message-Id: <20180316155138.125423-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <44e451f86e4582815767cf75b4e0f01f5cc60b5f.1507104596.git.shahafs@mellanox.com> References: <44e451f86e4582815767cf75b4e0f01f5cc60b5f.1507104596.git.shahafs@mellanox.com> Subject: [dpdk-dev] [PATCH] doc: update new ethdev offload API description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Mar 2018 15:51:46 -0000 Don't mandate API to pass port offload configuration during queue setup, this is unnecessary for devices that support only port level offloads. Fixes: 81ac560dc1b4 ("doc: add details on ethdev offloads API") Cc: shahafs@mellanox.com Signed-off-by: Ferruh Yigit --- Cc: Patil, Harish Btw, this expectation from API should be clear from source code and API documentation (doxygen comments in header file) instead of documentation. Am I missing something or we are doing something wrong here? --- doc/guides/prog_guide/poll_mode_drv.rst | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/doc/guides/prog_guide/poll_mode_drv.rst b/doc/guides/prog_guide/poll_mode_drv.rst index e5d01874e..3247f309f 100644 --- a/doc/guides/prog_guide/poll_mode_drv.rst +++ b/doc/guides/prog_guide/poll_mode_drv.rst @@ -303,9 +303,7 @@ Supported offloads can be either per-port or per-queue. Offloads are enabled using the existing ``DEV_TX_OFFLOAD_*`` or ``DEV_RX_OFFLOAD_*`` flags. Per-port offload configuration is set using ``rte_eth_dev_configure``. Per-queue offload configuration is set using ``rte_eth_rx_queue_setup`` and ``rte_eth_tx_queue_setup``. -To enable per-port offload, the offload should be set on both device configuration and queue setup. -In case of a mixed configuration the queue setup shall return with an error. -To enable per-queue offload, the offload can be set only on the queue setup. +Per-port offloads should be set on the port configuration. Queue offloads should be set on the queue configuration. Offloads which are not enabled are disabled by default. For an application to use the Tx offloads API it should set the ``ETH_TXQ_FLAGS_IGNORE`` flag in the ``txq_flags`` field located in ``rte_eth_txconf`` struct. -- 2.13.6