DPDK patches and discussions
 help / color / mirror / Atom feed
From: Chas Williams <3chas3@gmail.com>
To: dev@dpdk.org
Cc: skhare@vmware.com, Chas Williams <chas3@att.com>, stable@dpdk.org
Subject: [dpdk-dev] [PATCH] net/vmxnet3: keep link state consistent
Date: Sat, 17 Mar 2018 21:45:52 -0400	[thread overview]
Message-ID: <20180318014552.16703-1-3chas3@gmail.com> (raw)

From: Chas Williams <chas3@att.com>

The vmxnet3 never attempts link speed negotiation.  As a virtual device
the link speed is vague at best.  However, it is important for certain
applications, like bonding, to see a consistent link_status.  802.3ad
requires that only links of the same cost (link speed) be enslaved.
Keeping the link status consistent in vmxnet3 avoids races with bonding
enslavement.

Author: Thomas Monjalon <thomas@monjalon.net>
Date:   Fri Jan 5 18:38:55 2018 +0100

Fixes: 1e3a958f40b3 ("ethdev: fix link autonegotiation value")
Cc: stable@dpdk.org

Signed-off-by: Chas Williams <chas3@att.com>
---
 drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index 426008722..48a4d4f98 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -1105,7 +1105,7 @@ __vmxnet3_dev_link_update(struct rte_eth_dev *dev,
 		link.link_status = ETH_LINK_UP;
 	link.link_duplex = ETH_LINK_FULL_DUPLEX;
 	link.link_speed = ETH_SPEED_NUM_10G;
-	link.link_autoneg = ETH_LINK_AUTONEG;
+	link.link_autoneg = ETH_LINK_FIXED;
 
 	return rte_eth_linkstatus_set(dev, &link);
 }
-- 
2.13.6

             reply	other threads:[~2018-03-18  1:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-18  1:45 Chas Williams [this message]
2018-03-20 14:12 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2018-03-20 14:42   ` Chas Williams
2018-04-05 10:03   ` Thomas Monjalon
2018-04-05 15:01     ` Chas Williams
2018-04-17 19:25       ` Ferruh Yigit
2018-04-17 20:24         ` Thomas Monjalon
2018-04-18 16:23           ` Ferruh Yigit
2018-04-18 16:59           ` Yong Wang
2018-04-20  0:10 ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180318014552.16703-1-3chas3@gmail.com \
    --to=3chas3@gmail.com \
    --cc=chas3@att.com \
    --cc=dev@dpdk.org \
    --cc=skhare@vmware.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).