From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0052.outbound.protection.outlook.com [104.47.32.52]) by dpdk.org (Postfix) with ESMTP id D7E072BF1 for ; Tue, 20 Mar 2018 08:01:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NRSXAr4TeGw5rRAuZtLoCe2kO40eypTSWWX+peDXA9k=; b=WVuBI0guCEyc2iP3pEU7kxHA7n66HrIWH2WV9fbYxIS0OOSGwSiySdxBfkU0Sqhso7L/82cs9FhumHnw87MIJ1MpHjky7ok01UjIDg5xwGMwrJHmruhcyGRdDFuKAS3tnj97chsiGe5h4WIsVw/TMqmQk5UEgXUxZAphLBmOtWs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (111.93.218.67) by BN3PR07MB2513.namprd07.prod.outlook.com (2a01:111:e400:7bbf::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.588.14; Tue, 20 Mar 2018 07:01:35 +0000 Date: Tue, 20 Mar 2018 12:31:20 +0530 From: Jerin Jacob To: "Van Haaren, Harry" Cc: "Eads, Gage" , "dev@dpdk.org" Message-ID: <20180320070119.GA31671@jerin> References: <1520549742-12893-1-git-send-email-gage.eads@intel.com> <1520866522-13942-1-git-send-email-gage.eads@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: PN1PR01CA0090.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:1::30) To BN3PR07MB2513.namprd07.prod.outlook.com (2a01:111:e400:7bbf::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7d3b0ee1-9897-499c-59d7-08d58e306c47 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:BN3PR07MB2513; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 3:duQ3mYq+EkKC+ZzHQiFawSYhakgpu8roAOuj9BoG8meScU2hyXMulf5G8lclVwZchD9ttBivthc96oeqiZ+pY62xNVPjyVQNeS5aQ/XlhzyTZMmK6S/zqovCnU4bJllAYWM2UcrmUov8Px24RflzRiW0ZXzOVNn90U62wU3Z3eDtto0Iug5Sw0CRVrc0ENRkj5qcOwyQspUOjWEbXmvP4Pn82a5x4IBzLmh62C7rOOz3aVbKlrYZ/z7/mro2tT17; 25:vS5AspwzWCm4AByi9sxn0nVPTX6aRXslKf5beG0lpLXJ8C+VRrhrqACmDeG4zCy7AejmTR/pvuNJhwITVDwPzSSjD5i0AmwSvP6pFqFV0QCT09bx24YUIVGNIUD+MQFxz6ebEvy3Yj7AODE0PLrSHQv3XrQddPnGb7aSKlywpQU1gB9RuotM50fIOTqDlqfqOc+Ih8KU3eurTHjnCBWRZzkaP9RUMKPIa/Z+2VGgsIKINn346keuJMpihYkx3TinTXhm7ytTyaXtgb4+Fw7YlqX78HXo+XKZ89og1GY5Slo6cXWtOWKqJrNDiJ6aY5Yl8ivhT3lsoHtU9y8v5ZViMg==; 31:bMPCrK7Wnq33hJIbUjKf3Gx5Pz0g1vOYPtRaeknbdDh9HNLl/5oRmTv6Ybg/iJwVGLOupoklEP7prgfz78S2QkqCPm39kRC0TBIUigUcKNrPMPNNBAi/Ji9oHsKeaHgrs/BHROz966RkCYbm8Gzvl5pXMjC3jNrDNLIOZOq24KiEUWIoHE5AkUqVci96v1mjwiy8b5SrbN5csBaCjwyFOYgRvZCK11BgkuBZhciU6PY= X-MS-TrafficTypeDiagnostic: BN3PR07MB2513: X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 20:SeZ0edpsqRLcE4QrVQUzTQ1VTLheo4fJHAnKdS0UCRYNwzq+2K1cLk1EbLkO/ljjFEeaz6j9//ybRk84EaxHAoDF094Ub9/+7ndNaUDFCz15mO8gRyKOYVXfS/3av50SFqNrq5+tSs9USnHE9FTjd/uZd+657k/b0WaeW7hL+rtsGddKv2e6/F8pOok+k3TyFM3fG3xhLcslF6QdLPuT4HVSCgQykKlK6nscG0CkcZa7NpyAuTNr6hCpTahx6RC0WI6RCr0ay3eS7QfnNgqU4oeCPCRPfKoacrf7uPTMlSlFQXibmzogCBzrp8fCdbreL8uuXLvkWuf4pmW8lzh3vZWKKrK69cVSxIqafUc+dXt6utVp3V7QCaWWDJA+jdNsSC7TaEOsBXPNa+DcgqfhWVzgFA6lg9c+BXYeqqP5VLn5sAv7KPK605rOBtng4XWCOtVv9G3gOY4lyG73eZFG67nWHGjw9zbS2sDltfO4s9X3MKN+o80GshkLIwHwmNCkYHoNL9n515Ph6Kj7BJLvnPHCFVXXmB8NkMfjTQGd2w4f0uSOVG2uCH4WKx95C56fieJyluG2FM2h2lLIMqAcW2l6IafdOrQDnwP7GBUzhik=; 4:pbddOoGYsYdjMRoS/ov6JRqFuTZ2B1i7lO2hNk8Z2ohYtPskaXjBzO9oSJsPVl7EBc1Hcwo4EeeuHsbEKeRNyGCuKK22+Y1gRryCysMBIhAtKgbUvqJEPzMfNi1cKLFpbXZSSscBHN3eK1e6fxDOmGnTHGz5a3RmyNp551sdwMie2Qxs0HdRfxPsW35YI1chDD2Ugw5WgLJ/y+bbVA2FY9AvVcOigSE42klaRRJop1EWyqPYDIprIQ4MmEoR8gEPMQt13lvjna2fpkANl9X0RRYxe1metrld0OO+YVmHAchtey2lm4LKOunnhOiM/MSB X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(3231221)(944501308)(52105095)(10201501046)(6041310)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(6072148)(201708071742011); SRVR:BN3PR07MB2513; BCL:0; PCL:0; RULEID:; SRVR:BN3PR07MB2513; X-Forefront-PRVS: 061725F016 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(396003)(366004)(39380400002)(39850400004)(13464003)(199004)(51914003)(189003)(54906003)(2906002)(8936002)(59450400001)(16526019)(186003)(33896004)(52116002)(6666003)(50466002)(16586007)(97736004)(81156014)(316002)(4326008)(68736007)(26005)(229853002)(53546011)(106356001)(76176011)(6496006)(386003)(23726003)(3846002)(6116002)(1076002)(55016002)(33656002)(478600001)(5009440100003)(6916009)(9686003)(42882007)(105586002)(5660300001)(2950100002)(66066001)(58126008)(47776003)(72206003)(305945005)(25786009)(53936002)(7736002)(33716001)(81166006)(6246003)(8676002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR07MB2513; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR07MB2513; 23:Yap2sgpqJxwVllTLu6ZcDXBBOqq59z5eY41g7GC52?= =?us-ascii?Q?vYkc3LwOe0gRz4rUWS/4lEwhGEAZ3C1jFHDTHsFY7Pbyue8T/inF/LDOjbQ+?= =?us-ascii?Q?lxLKd2PkAUlQPG9T5vDXtg7o+E1khYNyti8Frj6D6TAovUn3l2EB4Rruyj1e?= =?us-ascii?Q?RPqXq+L+zaodOxhYVNy71HXfXPjm77Woe9bGLJ0rXYWXDyFSqetEuaH1sVbl?= =?us-ascii?Q?Z/bPA/gnkld0UP9/a+DGlcldOhGoJ1kMyI3k0iz/tF6kQpY2+bMVtqwSKnij?= =?us-ascii?Q?a6mwUyaoFxbG8+gAGoJiHWLm5h+aJP3Vp8jsdAtti81oIYXj24Y5tBZeLm0+?= =?us-ascii?Q?9i+5nt1PNgSnsA4aiflQHKO1R2ir1BAZYJ89DGOxe/zTb7rgz4t8gSroAGRz?= =?us-ascii?Q?rG0QorsHHq3RQoPxsp72XKXQmmab6uo/gdkUApGOY2vJAhIBrUNamEfypv+M?= =?us-ascii?Q?6Qw//6TvUnzsps8e9zZJWbNE43Uyz7k1C80UIzKda89WomxNcr9gdmSFCum+?= =?us-ascii?Q?sC4MI95qjCahr2VpZW6b9glW09ySJkjelcp769qt6vD4dKXyFhzVmDTBLw3v?= =?us-ascii?Q?cu7YPYv8YJvlajeJiitv9x1LkzM0ajM2Psc1CaLDi3axCRiL/f+atvOum4Oc?= =?us-ascii?Q?8V9uG+e9aASxuv0I/fsmjdld0o6XvFCG3E6h3BqhXzPLlyFsg7B2S62LOu2+?= =?us-ascii?Q?hYQmtnSZgESsYJi4jnOc3iQ3ltm41Vr1Zos5R73Qw6G0JtPY5Z3yKRHaDuaE?= =?us-ascii?Q?KFtNoiV8R3OAnd53HcbQVzjePovTc9nHBnKF5Yvmh8B42IcaFDO9kTz+0lMk?= =?us-ascii?Q?xpCmHOMRa5VAbuJZ76gRyPCN8ABb5/gh4Wr5NDGO1g8i+R+1ykxpNFAEKgR4?= =?us-ascii?Q?vCgvIYufOSHmpZJX03hMRyjijmW4yAOZX15B7TNDtOKRTTiwNJCEDhvNbxVc?= =?us-ascii?Q?XFvk7cKyHXRKIdmYmjVE7cqsg1XejoMG0qQS3pqv2gzHpBLkTXRuEnIgIaDK?= =?us-ascii?Q?S98eyBC/nAM+Z9iOwX9kWBOWPS5OZ39p7N7DpetbzJVxf1SkSM0zL/Jwa1g4?= =?us-ascii?Q?7813jEFha1G+sVXz8Voyd9Y6Sg9t+/5x6zXdTAYxSZGz1bTc454Qq+suwuW0?= =?us-ascii?Q?VFfAFgpsTz6qU5YyJiIzOXDKlz5eeJ4uGrcig4etnwbQDx/Xbdi1egMtxGvF?= =?us-ascii?Q?VgoFgefuOJgn2qhJkAMCdbJUHqWof1l25QH03UWGJ0JzaZ/gzVRbVIJDN3+z?= =?us-ascii?Q?DhJLC3GdBKPEJZxHlRrVvipSzJd0fwXd9Jb+bkKOq1A7/mOZlY2nPR4kgkRW?= =?us-ascii?Q?TU0zDeRfipvLZyHcN/j6ESIVEBO2MIKc2U5FeJVRiFvBYjpc/JF1wINTG9jP?= =?us-ascii?Q?TlSd0E9+PzL7xzbyzCWTdERPIw=3D?= X-Microsoft-Antispam-Message-Info: y88NwUmPhLU84CICqZ5S3L4jiZce0k/c0OEp03d1knMDHvFE/LatjbKT/WDUaUFl/U+YBnPJpJ12tDDW5fFxH9+OVVGADdNC3Er+G4pz5cwl2riduEL0Q5v0UjxGyQV5t5WwLeLOi3dsSfllzY2JwMSm/4L/kpeVLwhxwNq0WjbEL35+2Rpp4XnTlWiy3zCK X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 6:h+PUBjYPy5ogjwX9hm/CMnrHSsQyWdjUJw5N4rlI10rvtKIoZfPsdU76BWodJMPR8zjix0qf/FNQVT1BMUzxNqvy8A1DF86/A63ora6o+4MvTS6LK3mI4a++Ht0HIPIDZF9bTVoQXeRt8fQVsWgrQdIDRlRJ7GiERlF1GSbL2kaG0rGjamrjs2eRUL5Scdm1C4SoKrFm3vHTOIqOAPFhj8EF/XEklGnaZv8BKrc/Upagtllxq/3tV0ihWKPldxiLJp2DlOsZtdwRw5+ic0G6QvB0/35Ho6KQhAzggABH5ci3pLz7jeDBEcw1GdiuDO3+eQZJXNrvashT/9EpDbSMnqLFqbDpvoIoIRS2lwVAhLI=; 5:qgYWx4nvIFNrJvpK3wUtvT4tvh/tsCXHiUCX6Nutxxf2JXGIOAbEiVc94qbjJFmyV6y0dX48idog1vSCQh/C2u+qdqLA+V35fk3Bv1h2IwlFkoJM9ZXIE9yWhiUKY5tgKaI0dws6odFWcAcIxxwDG0wGPxrRbEomRuyUBrdH4S8=; 24:HwEocWr1MG+NCgeDIeydtM23MqP2oVVTD4TQUUPHSDPlen4xViFGQwaKixKw8LOYZjZ8oaj3QNokQOKAQJGf4GaqcxKC+AYyY3LXzg8oqCI=; 7:eivqq8lCaklbsy475zWGklPDxH/44hDWPu3J9gR8qO1vTKs2auJTBdAVA8w2mPzu6SIMT5CbsEs+e0NSOYYoDzkRaYGVxH0OFEHk/uUHpWJH3idM41w7GapFotbr4wpdJWf2EtD2p8PFwIT4k/pqAt/wegYUR7xQDACruoi4w2XP/MAPijwuUjA5wsZ4/VLrCyz8NYnv/2//jAE2wkBkyz5TQRKllGM2VLtaegn7KEx6/Ruhutx8KHwCAL6FjzYk SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2018 07:01:35.1377 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7d3b0ee1-9897-499c-59d7-08d58e306c47 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2513 Subject: Re: [dpdk-dev] [PATCH v2] event/sw: perform partial burst enqueues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2018 07:01:39 -0000 -----Original Message----- > Date: Tue, 13 Mar 2018 14:08:20 +0000 > From: "Van Haaren, Harry" > To: "Eads, Gage" , "dev@dpdk.org" > CC: "jerin.jacob@caviumnetworks.com" > Subject: RE: [PATCH v2] event/sw: perform partial burst enqueues > > > From: Eads, Gage > > Sent: Monday, March 12, 2018 2:55 PM > > To: dev@dpdk.org > > Cc: jerin.jacob@caviumnetworks.com; Van Haaren, Harry > > > > Subject: [PATCH v2] event/sw: perform partial burst enqueues > > > > Previously, the sw PMD would enqueue either all or no events, depending on > > if enough inflight credits were available for the new events in the burst. > > If a port is enqueueing a large burst (i.e. a multiple of the credit update > > quanta), this can result in suboptimal performance, and requires an > > understanding of the sw PMD implementation (in particular, its credit > > scheme) to tune an application's burst size. > > > > This affects software that enqueues large bursts of new events, such as the > > ethernet event adapter which uses a 128-deep event buffer, when the input > > packet rate is sufficiently high. > > > > This change makes the sw PMD enqueue as many events as it has credits, if > > there are any new events in the burst. > > > > Signed-off-by: Gage Eads > > > Agree that making forward progress by enqueuing what we have credits for > makes sense for the application. > > No performance degradation here, thanks for the patch: > > Acked-by: Harry van Haaren Applied to dpdk-next-eventdev/master. Thanks.