From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 95B415F34 for ; Wed, 21 Mar 2018 08:28:05 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Mar 2018 00:28:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,339,1517904000"; d="scan'208";a="25741689" Received: from dpdk51.sh.intel.com ([10.67.110.184]) by fmsmga007.fm.intel.com with ESMTP; 21 Mar 2018 00:28:03 -0700 From: Qi Zhang To: thomas@monjalon.net, konstantin.ananyev@intel.com Cc: dev@dpdk.org, beilei.xing@intel.com, jingjing.wu@intel.com, wenzhuo.lu@intel.com, Qi Zhang Date: Wed, 21 Mar 2018 15:28:04 +0800 Message-Id: <20180321072807.268266-1-qi.z.zhang@intel.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180212045314.171616-1-qi.z.zhang@intel.com> References: <20180212045314.171616-1-qi.z.zhang@intel.com> Subject: [dpdk-dev] [PATCH v3 0/3] runtime queue setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 07:28:06 -0000 According to exist implementation,rte_eth_[rx|tx]_queue_setup will always return fail if device is already started(rte_eth_dev_start). This can't satisfied the usage when application want to deferred setup part of the queues while keep traffic running on those queues already be setup. example: rte_eth_dev_config(nb_rxq = 2, nb_txq =2) rte_eth_rx_queue_setup(idx = 0 ...) rte_eth_rx_queue_setup(idx = 0 ...) rte_eth_dev_start(...) /* [rx|tx]_burst is ready to start on queue 0 */ rte_eth_rx_queue_setup(idx=1 ...) /* fail*/ Basically this is not a general hardware limitation, because for NIC like i40e, ixgbe, it is not necessary to stop the whole device before configure a fresh queue or reconfigure an exist queue with no traffic on it. The patch let etherdev driver expose the capability flag through rte_eth_dev_info_get when it support deferred queue configuraiton, then base on these flag, rte_eth_[rx|tx]_queue_setup could decide continue to setup the queue or just return fail when device already started. v3: - not overload deferred start. - rename deferred setup to runtime setup. - remove unecessary testpmd parameters (patch 2/4 of v2) - add offload support to testpmd queue setup command line - i40e fix: return fail when required rx/tx function conflict with exist setup. v2: - enhance comment in rte_ethdev.h *** BLURB HERE *** Qi Zhang (3): ether: support runtime queue setup app/testpmd: add command for queue setup net/i40e: enable runtime queue setup app/test-pmd/cmdline.c | 128 ++++++++++++++++++++++++++++ doc/guides/nics/features.rst | 8 ++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 ++ drivers/net/i40e/i40e_ethdev.c | 4 + drivers/net/i40e/i40e_rxtx.c | 64 ++++++++++++++ lib/librte_ether/rte_ethdev.c | 30 ++++--- lib/librte_ether/rte_ethdev.h | 7 ++ 7 files changed, 236 insertions(+), 12 deletions(-) -- 2.13.6