DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yongseok Koh <yskoh@mellanox.com>
To: "Hanoch Haim (hhaim)" <hhaim@cisco.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] mlx5 reta size is dynamic
Date: Wed, 21 Mar 2018 14:47:50 -0700	[thread overview]
Message-ID: <20180321214749.GA53128@yongseok-MBP.local> (raw)
In-Reply-To: <1b6a9384a5604f15948162766cde90a9@XCH-RTP-017.cisco.com>

On Wed, Mar 21, 2018 at 06:56:33PM +0000, Hanoch Haim (hhaim) wrote:
> Hi mlx5 driver expert,
> 
> DPDK: 17.11
> Any reason mlx5 driver change the rate table size dynamically based on the rx-
> queues# ?

The device only supports 2^n-sized indirection table. For example, if the number
of Rx queues is 6, device can't have 1-1 mapping but the size of ind tbl could
be 8, 16, 32 and so on. If we configure it as 8 for example, 2 out of 6 queues
will have 1/4 of traffic while the rest 4 queues receives 1/8. We thought it was
too much disparity and preferred setting the max size in order to mitigate the
imbalance.

> There is a hidden assumption that the user wants to distribute the packets
> evenly which is not always correct.

But it is mostly correct because RSS is used for uniform distribution. The
decision wasn't made based on our speculation but by many request from multiple
customers.

> /* If the requested number of RX queues is not a power of two, use the
>           * maximum indirection table size for better balancing.
>           * The result is always rounded to the next power of two. */
>           reta_idx_n = (1 << log2above((rxqs_n & (rxqs_n - 1)) ?
>                                            priv->ind_table_max_size :
>                                            rxqs_n));

Thanks,
Yongseok

  reply	other threads:[~2018-03-21 21:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-21 18:56 Hanoch Haim (hhaim)
2018-03-21 21:47 ` Yongseok Koh [this message]
2018-03-22  6:52   ` Hanoch Haim (hhaim)
2018-03-22  8:54     ` Nélio Laranjeiro
2018-03-22  9:02       ` Hanoch Haim (hhaim)
2018-03-22  9:27         ` Nélio Laranjeiro
2018-03-22 10:00           ` Hanoch Haim (hhaim)
2018-03-22 10:45             ` Nélio Laranjeiro
2018-03-22 10:59               ` Hanoch Haim (hhaim)
2018-03-22 12:29                 ` Nélio Laranjeiro
2018-03-22 12:33                   ` Hanoch Haim (hhaim)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180321214749.GA53128@yongseok-MBP.local \
    --to=yskoh@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=hhaim@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).