From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 359864D3A for ; Fri, 23 Mar 2018 13:58:18 +0100 (CET) Received: by mail-wm0-f65.google.com with SMTP id i75so3417152wmf.0 for ; Fri, 23 Mar 2018 05:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0PkH/umcJVjXp/kzzU4kuZCr/2QpIl5tB1o/gkg98wI=; b=FsykSGa0VcBSk6UH6bLV+ojg5Gea/k5VHjH2QO3AHGnEPSHHW+EwW7gtegny6a6ivs dhPu/AkaiuE/5kjbtu30PF3kWN+KpTEBPhJ+wSgr66KZusjypXoTW3BBf7Ubt79/I1Et O5vDIaLyR3qAFQp1ftvJB2wz7YZIRPNOTUFuB2VUHGgMPIIjRgKg04G1Nt5mQ8SRDzfA Yh9Ij3LbYr2bfvlyJVbcqD2Fl9t4wjVGWkUyI6dCuqjisd3ZbsQedq/xBUxAHmZbFtiD gvMHTUuQy4/iOabMZtvSbQwphv6xRjtGMYvwNqpGJbxwsqfkfnY2fja2WuEp+1fCOCez ciUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0PkH/umcJVjXp/kzzU4kuZCr/2QpIl5tB1o/gkg98wI=; b=WtRtDcpsMN54thkaWeKNFiwhd4TFkUk0bo1/Uvw8MkmZVq7a19Slk96JlaTSK3YG8a 9mxVWcJIvhPkt+ghm0GFmqabkAysXKXSIE6Rt1TLA3I98Sp9/fGbZ6vPqOVOacJzNHo4 3hfshaXUHLdrrfOZr5Z7cgbPJbU9kUgBxr8qgAV1OALQ8SjToV/Rmg6iXEaJtJvPv4Vu pI7skmKr03+Vf20Y2s2rwDSHKOhmSpnXtBjiczNcPmOdycNHcpeig6rKBQQiQF8NKmer jGbX/Ql23Kn7wiKaLAIKZAFElplAxlAqwqW3xQEm8wv0bDhN2YPKScjL95AKDAk5DPUh vnmw== X-Gm-Message-State: AElRT7GH6qIZUD3nmNaeZIY3MZPFYzmv4jgtlQI9SsfPOHRqk1Oo+h0m FIyBiigL8cJh1UTcTFBGaWp3dzDk X-Google-Smtp-Source: AG47ELsZ7LvGPH+AMPk/j0FNg68pQUhxYgSpWEi0R3llEDroAFIiy1VVsTIQnnoNItmL3zXWwvIhLA== X-Received: by 10.28.144.134 with SMTP id s128mr7871454wmd.4.1521809897855; Fri, 23 Mar 2018 05:58:17 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id y42sm12437009wry.97.2018.03.23.05.58.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Mar 2018 05:58:17 -0700 (PDT) Date: Fri, 23 Mar 2018 13:58:03 +0100 From: Adrien Mazarguil To: dev@dpdk.org Cc: stable@dpdk.org, Shahaf Shuler Message-ID: <20180323124725.15806-2-adrien.mazarguil@6wind.com> References: <20180323124725.15806-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180323124725.15806-1-adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH v1 1/9] net/mlx4: fix RSS resource leak in case of error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Mar 2018 12:58:18 -0000 When memory cannot be allocated for a flow rule, its RSS context reference is not dropped. Fixes: 078b8b452e6b ("net/mlx4: add RSS flow rule action support") Cc: stable@dpdk.org Signed-off-by: Adrien Mazarguil Cc: Shahaf Shuler --- drivers/net/mlx4/mlx4_flow.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c index 2d55bfe03..a3b4480b4 100644 --- a/drivers/net/mlx4/mlx4_flow.c +++ b/drivers/net/mlx4/mlx4_flow.c @@ -820,11 +820,14 @@ mlx4_flow_prepare(struct priv *priv, }, }; - if (!mlx4_zmallocv(__func__, vec, RTE_DIM(vec))) + if (!mlx4_zmallocv(__func__, vec, RTE_DIM(vec))) { + if (temp.rss) + mlx4_rss_put(temp.rss); return rte_flow_error_set (error, -rte_errno, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, "flow rule handle allocation failure"); + } /* Most fields will be updated by second pass. */ *flow = (struct rte_flow){ .ibv_attr = temp.ibv_attr, -- 2.11.0