From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id B8EAD5F22 for ; Mon, 26 Mar 2018 13:19:22 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id x4so2395894wmh.5 for ; Mon, 26 Mar 2018 04:19:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=wwnxh2jrtTHIID16Ggl9QGACtOOFF70VP1we7nLtIYs=; b=0fP51bznuzezMKJhL97KIKurX068b/Z8q27FDFo44nnDh1LIqcSsOI+AWYZPOwnhAJ iBav39AfaSlSc+iR0AIOtvQprF8XK81gHejraQifUpiuBeflRR7xtHw2Var9008frHjo y4fvIz3/PcJ3BDKlS1WKljUrcH2FgJlK+ptZfz7KDFg/2MREVziGXw5ninz+aMsXIaZ6 PANfsWYsL3tyvSzJzqpRokMnnFjAzsSVqAAT43ev2CwmrKy4QcVkGUKOJekvvF7nXH1F C8MGjnIgGihrDYb+Etr4QW4Xe+3j3jLuw6E48gBT3blNMtcznqovsws/HKWjztPo/8FH spzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=wwnxh2jrtTHIID16Ggl9QGACtOOFF70VP1we7nLtIYs=; b=CYZcwtWxRsrWSczGlIQxdUqRAebweOT//GEgM6LPGwYTHD/K9/MO2IJ07BpkuBNjJn v6IcL7MJMDj9NkqtqPlpxuuxDmVrIzzeHNY8zZ7FYWNxl4ny1j24/aNicYcYfOBjjeKl LWS9jq8QGx5A2wJwT7+qTUYNLKH4hPy5EHXYTRfQYyDVohMeh+lBC6RFLAm9hNkhiUYa GvXu1b3DlmoFiiVuoh/mn6rX2qQ4Ob0ysrYUIT8F7S+ylWWj/B2I90z4Hy9jKsDwAOKZ Cfy74n/ECeTpBybgFCqjimrXaOK3FAz1tsnjpbBdvTWjy9pdep+ZG6swbEq12JusnWFS vK1w== X-Gm-Message-State: AElRT7Hxmg2ym1d5Q+KpsaPYNWDVIMlRyTtaY/w1oYQyQmcXeQ7OjaK3 JFd85P/ePaBV1v7URou9KvCg X-Google-Smtp-Source: AIpwx48T0Ek96TddHXjzMC0IhQmdoUk2CHacSonF+Gmsau2XVD6lqwfpIkPTN9mb0f6NNailLMcI7A== X-Received: by 10.28.216.69 with SMTP id p66mr1229685wmg.84.1522063162288; Mon, 26 Mar 2018 04:19:22 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id n190sm16077238wmb.15.2018.03.26.04.19.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Mar 2018 04:19:21 -0700 (PDT) Date: Mon, 26 Mar 2018 13:17:55 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Shahaf Shuler Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20180326111755.wmr2gzvvrujc3jco@laranjeiro-vm.dev.6wind.com> References: <20180326101219.91229-1-shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180326101219.91229-1-shahafs@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx5: enforce RSS key length limitation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2018 11:19:22 -0000 On Mon, Mar 26, 2018 at 01:12:18PM +0300, Shahaf Shuler wrote: > RSS hash key must be 40 Bytes long. > > Cc: stable@dpdk.org > > Signed-off-by: Shahaf Shuler > --- > drivers/net/mlx5/mlx5_ethdev.c | 3 ++- > drivers/net/mlx5/mlx5_rss.c | 7 +++++++ > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c > index f5511ce70..365101af9 100644 > --- a/drivers/net/mlx5/mlx5_ethdev.c > +++ b/drivers/net/mlx5/mlx5_ethdev.c > @@ -329,7 +329,8 @@ mlx5_dev_configure(struct rte_eth_dev *dev) > if (use_app_rss_key && > (dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key_len != > rss_hash_default_key_len)) { > - /* MLX5 RSS only support 40bytes key. */ > + DRV_LOG(ERR, "port %u RSS key len must be %zu Bytes long", > + dev->data->port_id, rss_hash_default_key_len); > rte_errno = EINVAL; > return -rte_errno; > } > diff --git a/drivers/net/mlx5/mlx5_rss.c b/drivers/net/mlx5/mlx5_rss.c > index 5ac650163..ceaa570ef 100644 > --- a/drivers/net/mlx5/mlx5_rss.c > +++ b/drivers/net/mlx5/mlx5_rss.c > @@ -48,6 +48,13 @@ mlx5_rss_hash_update(struct rte_eth_dev *dev, > return -rte_errno; > } > if (rss_conf->rss_key && rss_conf->rss_key_len) { > + if (rss_conf->rss_key_len != rss_hash_default_key_len) { > + DRV_LOG(ERR, > + "port %u RSS key len must be %zu Bytes long", > + dev->data->port_id, rss_hash_default_key_len); > + rte_errno = ENOTSUP; Should be EINVAL when values are incorrect. > + return -rte_errno; > + } > priv->rss_conf.rss_key = rte_realloc(priv->rss_conf.rss_key, > rss_conf->rss_key_len, 0); > if (!priv->rss_conf.rss_key) { > -- > 2.12.0 Thanks, -- Nélio Laranjeiro 6WIND