From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 200A77289 for ; Mon, 26 Mar 2018 13:35:08 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id v21so14769024wmc.1 for ; Mon, 26 Mar 2018 04:35:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=8b1ghcGJ4daFFWjDPeV62HPMAvaFL7ruKvGqDXiqsLw=; b=tshMUYpjP0Sd39MeiHf0sBWFS4Cm/UCqNhcv++DmbLcXmaxj97yZyUIFzIbr/4NoK9 vd9P1mfNlzEKuvxqB3ADZt1G8tdEYDWQYZmVC1i+G1AQH4FVafT+a+Ri9Yr7ac4KmLDF R5YyaRg+3Ic6c2nydq6pUap805JyaNc7zqCF4n4y/l5BSifSPbHkE45nl6odsBbsaXZn qzrvjvDNSGfnZ4BOowed4wXYbTsOxwT++w6qlVCRTXaqD6B+OhJlP9R/ncJ0mgc0dgjl gKQwX+iyd3wVHFfACAdy5dtXqqfGkdtRbZoUujdEBFtOR13Otd99Qj1WEXbZrrjIVGxJ sUOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=8b1ghcGJ4daFFWjDPeV62HPMAvaFL7ruKvGqDXiqsLw=; b=kUL3zZOJL5Znbh0Gr2N0dkc0vfCD1ArSlPl1yKy8bhTqVdtYQr5UKM+MaZuyLlFIEB IAmaAkbyLA1raQlO142/yqMw1ydGQhKuTpBklzcJOi1BtskZMxLRzWMvb1hEpV61msUj BJzNorb7hblUFlrHIMZ4WS/CXGtvj8FkqXcWI3uMl8+l5T84/z0bosr1G1eNM3aoxBks 610Blu5jyXn1DFQ4rAWYTX1+wpp6mrAIOB7NoHJhXs5pfAnQog+aDSo45QESsK1bAHQz MZZsj0jO4wtKBpzuRvhYonr+0kuovCzv8rjSR9dPpJqZmhWRAuUJZp8E5TXw+h5nt+zK 2xvQ== X-Gm-Message-State: AElRT7Et0BG/LQezctNrOoNUswXqR8lV7ftE2YmV0+Zz4htgp6Cw8Y2U ON3jAwggTpU4A9y0/xx6B2j2 X-Google-Smtp-Source: AG47ELtjhGUcYrdQ2v4jz1138ooN/uHWQqZjTt31b4BTOaSJr3ksdu0RUpLWogyWVwBqlmEF5Oj8Qg== X-Received: by 10.28.245.9 with SMTP id t9mr15996601wmh.33.1522064108585; Mon, 26 Mar 2018 04:35:08 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id c57sm14122007wrg.84.2018.03.26.04.35.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Mar 2018 04:35:08 -0700 (PDT) Date: Mon, 26 Mar 2018 13:33:42 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Shahaf Shuler Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20180326113342.t673b6tgzy5qjuqu@laranjeiro-vm.dev.6wind.com> References: <20180326101219.91229-1-shahafs@mellanox.com> <20180326101219.91229-2-shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180326101219.91229-2-shahafs@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix RSS key len query X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2018 11:35:09 -0000 On Mon, Mar 26, 2018 at 01:12:19PM +0300, Shahaf Shuler wrote: > The RSS key length returned by rte_eth_dev_info_get command was taken > from the > PMD private structure. This structure initialization was done only after > the port configuration. > > Considering Mellanox device supports only 40B long RSS key, reporting > the fixed number instead. > > Fixes: 29c1d8bb3e79 ("net/mlx5: handle a single RSS hash key for all protocols") > Cc: stable@dpdk.org > Cc: nelio.laranjeiro@6wind.com > > Signed-off-by: Shahaf Shuler > --- > drivers/net/mlx5/mlx5_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c > index 365101af9..b6f5101cf 100644 > --- a/drivers/net/mlx5/mlx5_ethdev.c > +++ b/drivers/net/mlx5/mlx5_ethdev.c > @@ -428,7 +428,7 @@ mlx5_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info) > info->if_index = if_nametoindex(ifname); > info->reta_size = priv->reta_idx_n ? > priv->reta_idx_n : config->ind_table_max_size; > - info->hash_key_size = priv->rss_conf.rss_key_len; > + info->hash_key_size = rss_hash_default_key_len; > info->speed_capa = priv->link_speed_capa; > info->flow_type_rss_offloads = ~MLX5_RSS_HF_MASK; > } > -- > 2.12.0 Acked-by: Nelio Laranjeiro Regards, -- Nélio Laranjeiro 6WIND