From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id 912235F22 for ; Mon, 26 Mar 2018 13:55:06 +0200 (CEST) Received: by mail-wr0-f196.google.com with SMTP id u46so18606091wrc.11 for ; Mon, 26 Mar 2018 04:55:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dqradJebA8QsjYG/VwEw0EeDBamnia5ovz6FgIq8+Tg=; b=VSKx70d1e6I6WdFZdjIQzR6RbjdAVL/oACe81X/s+y20csgbAZtQhuuzRXUEyBhOZn oeZuLcSkOUeZq5MY3P3irkYTXQvVGba4jJD7VtPT2s03hPHj47cy7/GGwRKusQ0dDkFZ bK0C4hPh9bTfVJ5f3JGPwGbFNNwKc5S+AZ6AS41mYW+JO4QZ0G3RWmVPW3Z0N7oktuYV jDVH03a5h011KovPetEklyML2DPeeudpj9JjLZRKQAsOu1+iqof7BWn7ziJCMfa8PbI6 xmHq7WIU8BaTCxEycjvRkx0bMtXusxCCDotOeUTMU7T9Z2bSk3qCzTGPpxSJ9NNH6vmu VA1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dqradJebA8QsjYG/VwEw0EeDBamnia5ovz6FgIq8+Tg=; b=WuUbrt3htLQJYsxKwYunox461tI5flhGM+mjGkltwe3uwMFugWVrdxrSmmkrcB3Ro9 /63BQled3eN7O3qYmizitCva7nysyhuASUlNCzjIJ9I76ZAdGRTw9VddptLHDDWEaU3m l5y/IfDRohrgcVZxxdAekUWo4lhofhOxAfOqhp9VfITr83Vp3fPl+0iz5Gq0tDn1Jpb8 /eo3MmrcpJHj/Lg25vD+eguFkDzs5ILRE5EJep79OU5BnnNmkLvZcd0MChpPR+LFldxA DIaSUPjfkakz8SRGyCH6v743OrF2VYqoIJykYbRe4m9JtbZbsDpDMHw9Bf5OrfYGWYnS pbbw== X-Gm-Message-State: AElRT7Hh8ruhHk/zHy7Gg9f1Md7s26plr5cXHu0bhHw+OmbiEvf+MaUZ wu0xRTI/3GtFI+Oft7A6bjdGgI+E X-Google-Smtp-Source: AG47ELsTcpRAoQhX1Hbs/C5JtH55zxqPVBqecw1P1frpgNt7nDMsj+TJguYAAxdMSHunnRbf20oW4Q== X-Received: by 10.223.155.2 with SMTP id b2mr28867262wrc.185.1522065306279; Mon, 26 Mar 2018 04:55:06 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id p14sm32034231wrc.30.2018.03.26.04.55.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Mar 2018 04:55:05 -0700 (PDT) Date: Mon, 26 Mar 2018 13:54:52 +0200 From: Adrien Mazarguil To: Ferruh Yigit Cc: Ophir Munk , dev@dpdk.org, Thomas Monjalon , Olga Shern , Shahaf shuler Message-ID: <20180326115452.GF4011@6wind.com> References: <1521477410-8936-1-git-send-email-ophirmu@mellanox.com> <1522009169-13860-1-git-send-email-ophirmu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2018 11:55:06 -0000 On Mon, Mar 26, 2018 at 12:38:22PM +0100, Ferruh Yigit wrote: > On 3/25/2018 9:19 PM, Ophir Munk wrote: > > Previous to this commit mlx4 CRC stripping was executed by default and > > there was no verbs API to disable it. > > Are you aware of the discussion about CRC [1]? Is this patch compatible with plans? > > [1] > https://dpdk.org/dev/patchwork/patch/36415/ I wasn't aware of this notice. Looks like it makes this patch unnecessary since mlx4 always strip by default; this patch makes it configurable at will and only exposes the capability when HW supports its configuration (i.e. the ability to leave CRC inside mbuf). We'd just need mlx4 to not expose DEV_RX_OFFLOAD_CRC_STRIP at all in mlx5_get_rx_queue_offloads() in order to fully comply. I leave it up to you, I don't mind if we include this patch only to revert it later when we finally get rid of DEV_RX_OFFLOAD_CRC_STRIP. > > Signed-off-by: Ophir Munk > > --- > > v1: initial version > > v2: following internal reviews > > v3: following dpdk.org mailing list reviews > > <...> -- Adrien Mazarguil 6WIND