From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f178.google.com (mail-wr0-f178.google.com [209.85.128.178]) by dpdk.org (Postfix) with ESMTP id 3F3F75F2D for ; Tue, 27 Mar 2018 09:16:57 +0200 (CEST) Received: by mail-wr0-f178.google.com with SMTP id z73so21266913wrb.0 for ; Tue, 27 Mar 2018 00:16:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=gL8nAjNEg+GIYyiUtsVSAdozVDboZxNWhqWv0ZXmG+A=; b=qmHDodJnu/Oj1hmC+1Dvay6FsKHdT7905u6+m+pM78F9Q3tT7ZxS1uFH7ZZ3ZsICDr rhOESzV3d8FQ0cbIQ8hLCl2FcRKYfIb48GO5xt523KoJgXogfg7QZcq36QIgXIINWLr6 1RZYMspbREXJzRi4UuAqqz2lng0YsPLOPOnpS0VaPSLGm9jZmcvpmcinl33a7lG0aHKz ujIvzORKZhIsQyDU7bTyCLZVCRYbJHEajewzKn4UGTCoS03Xwj5TcO+L1lCwKNxZS/16 U811uosX2BEJhSeWGMS+mIDT2BsQwFKNe7xvlpLtg4KgPVEZwMBjGucxzhrQyCcz28sD JfIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=gL8nAjNEg+GIYyiUtsVSAdozVDboZxNWhqWv0ZXmG+A=; b=ndjPLd+vFe86ar7e/bsH1lQXOuEEEubDVP3B5uxbLshlXLAorVpgoqtHDoAZoTDvcH sBZ0tyDVKap/JF3yLjeDZBli1MLaMd/cIq9J7jvGzdoSG1qkWRmo6tNdJfcHidJUv9j6 chSnfaxPBe/qOPAA6qCU+4dnZAvJbEnDP3j6g2a9EvAtwIhpFBWd0C9Ek5iWRhzgHouZ SkH3xIgDOfT14kImBSiLAeo8keGzORVXxHKMfDm0KQ34t2wc3NV5aYIplW4VoWeA42XS PpdD7oGZKKC/kcU8vRgjwQvf/YzL0sBoLX1BZEjRpK8ZhUbTfAbBtKFSpjaDdrWQYzd/ TWfw== X-Gm-Message-State: AElRT7EkB8ifkMR03casSe6td5lri4hxyPv/t/i0VBkwKD9aw8WR9I3E He1VggBSLu0Gkc2K9SaBqItv X-Google-Smtp-Source: AG47ELtwtnwczvyfuPzDXxxIp9g0d6BZPukDyCo1VtSCnzQln3CmEbBCAuyjtAtRVssGPuSAAMjfAg== X-Received: by 10.223.224.130 with SMTP id c2mr31998110wri.220.1522135017019; Tue, 27 Mar 2018 00:16:57 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id u127sm788294wmd.30.2018.03.27.00.16.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Mar 2018 00:16:56 -0700 (PDT) Date: Tue, 27 Mar 2018 09:15:32 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Shahaf Shuler Cc: Adrien Mazarguil , Yongseok Koh , "dev@dpdk.org" , "stable@dpdk.org" Message-ID: <20180327071532.bae3pu523uydybgt@laranjeiro-vm.dev.6wind.com> References: <20180326101219.91229-1-shahafs@mellanox.com> <20180326111755.wmr2gzvvrujc3jco@laranjeiro-vm.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx5: enforce RSS key length limitation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 07:16:57 -0000 On Tue, Mar 27, 2018 at 05:55:32AM +0000, Shahaf Shuler wrote: > Monday, March 26, 2018 2:18 PM, Nélio Laranjeiro: > > On Mon, Mar 26, 2018 at 01:12:18PM +0300, Shahaf Shuler wrote: > > > @@ -48,6 +48,13 @@ mlx5_rss_hash_update(struct rte_eth_dev *dev, > > > return -rte_errno; > > > } > > > if (rss_conf->rss_key && rss_conf->rss_key_len) { > > > + if (rss_conf->rss_key_len != rss_hash_default_key_len) { > > > + DRV_LOG(ERR, > > > + "port %u RSS key len must be %zu Bytes > > long", > > > + dev->data->port_id, > > rss_hash_default_key_len); > > > + rte_errno = ENOTSUP; > > > > Should be EINVAL when values are incorrect. > > OK. > > Considering it is the only comment in this series, are you OK with me > changing it while applying to next-net-mlx? Sure, Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND