From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 4DF1D5F32 for ; Tue, 27 Mar 2018 10:49:28 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id s18so21518956wrg.9 for ; Tue, 27 Mar 2018 01:49:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=KPdiEeu6ZWHBNSk2PCaF7plU0O4k+J3N0UlUgmonb88=; b=GcnUZ7Yj2VOswJlTSBn85YDDL8Eqr0cYsUlYmMzTQh/0zDSIyHZji7//rgv8ZxHEXN ZZ4by/+CqRsxcCQF2zEJDQTl4Hnh9X+q+fgRgBYr0aRAbsZGrtXu9vwkFJEGJWS3WXSz k3NOIJtqEzkCBCr5spe24Q7oVxbQyCWR4sdNX6SHaGfE9NNgSLtzmscmuNHFOIeWUEwP wgyk1zM4jefxAIUecjv9iNWnRX7GtzFsTaAqv6aj/n8Nj5HPFTtI21HpkQFQEssr8yrQ DhcHiatjyhbDBcP66/fRIfYNjxHLOxMyhi5Ng8G2rzEP7hoekJwQ/4ZioHBWHYxg5bUM 4u8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=KPdiEeu6ZWHBNSk2PCaF7plU0O4k+J3N0UlUgmonb88=; b=itFsMKILRFDRAgsmnkewMHBafpwqlk56bADpKzsbkrKsQIXJlpXmX2wefKl3OGMPiG 3xs6ivWEqYJodGbj+YM1kItqbsI8Ls1mJIMLgVQ9uyAhC8m+CLdXL7KyVo16qL97U3L6 kXMVMkgKosr5OIIHA1bVf97QN95EeEKZDX5hg8h9wL/b1ENFgZWEyDP83M4k2WB7dtz7 gB6K+6Tn8RyCI9Cd2czuEMakV90sFu9f/rbd6ok2L+XhTL1S52toddZPJBwBLi7MgEot g9BEQoksPK9jS4OrkDbkC0Z1CQ09TALtOyGN4emW3VkTjpn3HqV214SZYJMM/O2ZxHPL YPKQ== X-Gm-Message-State: AElRT7HnCTNJLHxOTXott5AJcsds3sIsxGKNnnc5inOLRsaS3548OPsY 9qQE8DIjF64c0O1MiwnUHqQjlA== X-Google-Smtp-Source: AG47ELv9vKi/JZaQC7zlrbQ83SZcoloGk0XyJIbKqqFvUS31ozjeLOxgOnuY0b6dSVwpsrEbbMFBdA== X-Received: by 10.223.154.47 with SMTP id z44mr30556562wrb.239.1522140568109; Tue, 27 Mar 2018 01:49:28 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id f84sm1460226wmh.44.2018.03.27.01.49.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Mar 2018 01:49:27 -0700 (PDT) Date: Tue, 27 Mar 2018 10:49:13 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Shreyansh Jain Cc: dev@dpdk.org Message-ID: <20180327084913.a6oplvp25ovtnju3@bidouze.vm.6wind.com> References: <63ecbe92f158267aaf817c3183644d0fe39f6e9b.1522105876.git.gaetan.rivet@6wind.com> <21a2a39b-a8a7-195b-49b8-b24d8026c9b2@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <21a2a39b-a8a7-195b-49b8-b24d8026c9b2@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v3 06/20] eal/class: register destructor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 08:49:29 -0000 Hi Shreyansh, On Tue, Mar 27, 2018 at 02:12:51PM +0530, Shreyansh Jain wrote: > On 3/27/2018 4:48 AM, Gaetan Rivet wrote: > > Signed-off-by: Gaetan Rivet > > --- > > lib/librte_eal/common/include/rte_class.h | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/lib/librte_eal/common/include/rte_class.h b/lib/librte_eal/common/include/rte_class.h > > index 59b578e3e..95107d937 100644 > > --- a/lib/librte_eal/common/include/rte_class.h > > +++ b/lib/librte_eal/common/include/rte_class.h > > @@ -112,6 +112,11 @@ static void classinitfn_ ##nm(void) \ > > {\ > > (cls).name = RTE_STR(nm);\ > > rte_class_register(&cls); \ > > +} \ > > +RTE_FINI_PRIO(classfinifn_ ##nm, CLASS); \ > > +static void classfinifn_ ##nm(void) \ > > +{ \ > > + rte_class_unregister(&cls); \ > > } > > #ifdef __cplusplus > > > > I think this can be merged with the Patch 05/20 - isn't it? Absolutely, I only separated it as I wasn't sure for the dtor patch itself. If the dtors are accepted, this patch can be merged with the previous patch. -- Gaëtan Rivet 6WIND