From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E588C4CBB for ; Tue, 27 Mar 2018 11:12:50 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2018 02:12:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,366,1517904000"; d="scan'208";a="41578365" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.52]) by fmsmga001.fm.intel.com with SMTP; 27 Mar 2018 02:12:21 -0700 Received: by (sSMTP sendmail emulation); Tue, 27 Mar 2018 10:12:20 +0100 Date: Tue, 27 Mar 2018 10:12:20 +0100 From: Bruce Richardson To: Gaetan Rivet Cc: dev@dpdk.org Message-ID: <20180327091220.GA23992@bricha3-MOBL.ger.corp.intel.com> References: <996543406679ba5e61341a71c030f06dd83f4ccf.1522105876.git.gaetan.rivet@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <996543406679ba5e61341a71c030f06dd83f4ccf.1522105876.git.gaetan.rivet@6wind.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3 02/20] kvargs: build before EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 09:12:51 -0000 On Tue, Mar 27, 2018 at 01:18:26AM +0200, Gaetan Rivet wrote: > Signed-off-by: Gaetan Rivet > --- > lib/Makefile | 3 +-- > lib/librte_eal/common/Makefile | 2 +- > lib/librte_kvargs/Makefile | 2 +- > lib/librte_kvargs/rte_kvargs.c | 3 +-- > lib/{librte_eal/common/include => librte_kvargs}/rte_string_fns.h | 0 > 5 files changed, 4 insertions(+), 6 deletions(-) > rename lib/{librte_eal/common/include => librte_kvargs}/rte_string_fns.h (100%) > Don't forget to update the meson.build file. You need to move kvargs before EAL in the list of libraries, and modify the special case for default dependencies for non-EAL libs. /Bruce