DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] ethdev: return diagnostic when setting MAC address
Date: Wed, 28 Mar 2018 10:24:27 +0200	[thread overview]
Message-ID: <20180328082427.4agrvcn3hgywwlbu@platinum> (raw)
In-Reply-To: <b06a8115-11c3-20f6-d3c5-88aaf68400f2@intel.com>

Hi Ferruh,

On Mon, Mar 26, 2018 at 07:39:00PM +0100, Ferruh Yigit wrote:
> On 2/27/2018 3:11 PM, Olivier Matz wrote:
> > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a
> > return code is added to notify the caller (librte_ether) if an error
> > occurred in the PMD.
> > 
> > The new default MAC address is now copied in dev->data->mac_addrs[0]
> > only if the operation is successful.
> > 
> > The patch also updates all the PMDs accordingly.
> > 
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

[...]

> ethdev part looks good to me.
> Are you planning to have another version for mrvl and sfc comments?
> 
> PMD maintainers, please check and provide feedback for your PMD, otherwise the
> patch will go in as it is.

Yes, I'll send a new version adressing the comments as soon as possible.

Thanks,
Olivier

  reply	other threads:[~2018-03-28  8:24 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-27 15:11 Olivier Matz
2018-03-05 10:29 ` Adrien Mazarguil
2018-03-06  9:37 ` Tomasz Duszynski
2018-03-16 15:41 ` Andrew Rybchenko
2018-03-26 18:39 ` Ferruh Yigit
2018-03-28  8:24   ` Olivier Matz [this message]
2018-04-03 12:41 ` [dpdk-dev] [PATCH v2] " Olivier Matz
2018-04-03 13:02   ` Andrew Rybchenko
2018-04-03 14:57   ` Adrien Mazarguil
2018-04-03 16:26     ` Olivier Matz
2018-04-03 16:19   ` Ferruh Yigit
2018-04-03 16:25     ` Olivier Matz
2018-04-04  8:19   ` Shreyansh Jain
2018-04-06 15:21   ` [dpdk-dev] [PATCH] " Olivier Matz
2018-04-06 15:34     ` Olivier Matz
2018-04-09  8:57     ` Nélio Laranjeiro
2018-04-06 15:34   ` [dpdk-dev] [PATCH v3] " Olivier Matz
2018-04-06 16:03     ` Ferruh Yigit
2018-04-10 13:19       ` Thomas Monjalon
2018-04-11 16:32     ` [dpdk-dev] [PATCH v4] " Olivier Matz
2018-04-11 19:30       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180328082427.4agrvcn3hgywwlbu@platinum \
    --to=olivier.matz@6wind.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).