DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: hemant.agrawal@nxp.com, shreyansh.jain@nxp.com,
	Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-dev] [PATCH 6/6] drivers/dpaa*: reduce meson dependency lists
Date: Thu, 29 Mar 2018 14:54:36 +0100	[thread overview]
Message-ID: <20180329135436.92878-7-bruce.richardson@intel.com> (raw)
In-Reply-To: <20180329135436.92878-1-bruce.richardson@intel.com>

Meson build currently tracks the dependencies between libraries, which
can often make things easier, but has the side-effect of slowing down
the initial meson run if too many duplicated dependencies are provided.
Therefore, we remove dependencies from the dpaa items where other
dependencies already depend on those. This provides a noticable speed-up
in meson configuration runs when lots of sample apps are included in the
build.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/bus/dpaa/meson.build         | 2 +-
 drivers/bus/fslmc/meson.build        | 2 +-
 drivers/crypto/dpaa2_sec/meson.build | 2 +-
 drivers/event/dpaa/meson.build       | 2 +-
 drivers/event/dpaa2/meson.build      | 2 +-
 drivers/mempool/dpaa2/meson.build    | 2 +-
 drivers/net/dpaa/meson.build         | 2 +-
 drivers/net/dpaa2/meson.build        | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/bus/dpaa/meson.build b/drivers/bus/dpaa/meson.build
index f5c6d7bb6..d10b62c03 100644
--- a/drivers/bus/dpaa/meson.build
+++ b/drivers/bus/dpaa/meson.build
@@ -5,7 +5,7 @@ if host_machine.system() != 'linux'
         build = false
 endif
 
-deps += ['ethdev', 'eventdev']
+deps += ['eventdev']
 sources = files('base/fman/fman.c',
 		'base/fman/fman_hw.c',
 		'base/fman/netcfg_layer.c',
diff --git a/drivers/bus/fslmc/meson.build b/drivers/bus/fslmc/meson.build
index e94340eae..d743f710b 100644
--- a/drivers/bus/fslmc/meson.build
+++ b/drivers/bus/fslmc/meson.build
@@ -5,7 +5,7 @@ if host_machine.system() != 'linux'
         build = false
 endif
 
-deps += ['ethdev', 'eventdev', 'kvargs']
+deps += ['eventdev', 'kvargs']
 sources = files('fslmc_bus.c',
 		'fslmc_vfio.c',
 		'mc/dpbp.c',
diff --git a/drivers/crypto/dpaa2_sec/meson.build b/drivers/crypto/dpaa2_sec/meson.build
index 0fb4d961e..01afc5877 100644
--- a/drivers/crypto/dpaa2_sec/meson.build
+++ b/drivers/crypto/dpaa2_sec/meson.build
@@ -5,7 +5,7 @@ if host_machine.system() != 'linux'
         build = false
 endif
 
-deps += ['bus_fslmc', 'security', 'mempool_dpaa2']
+deps += ['security', 'mempool_dpaa2']
 sources = files('dpaa2_sec_dpseci.c',
 		'mc/dpseci.c')
 
diff --git a/drivers/event/dpaa/meson.build b/drivers/event/dpaa/meson.build
index 9bbd6c2a1..0914f858e 100644
--- a/drivers/event/dpaa/meson.build
+++ b/drivers/event/dpaa/meson.build
@@ -4,7 +4,7 @@
 if host_machine.system() != 'linux'
 	build = false
 endif
-deps += ['mempool_dpaa', 'bus_dpaa', 'pmd_dpaa']
+deps += ['pmd_dpaa']
 sources = files('dpaa_eventdev.c')
 
 allow_experimental_apis = true
diff --git a/drivers/event/dpaa2/meson.build b/drivers/event/dpaa2/meson.build
index 835460c5d..de7a46155 100644
--- a/drivers/event/dpaa2/meson.build
+++ b/drivers/event/dpaa2/meson.build
@@ -4,7 +4,7 @@
 if host_machine.system() != 'linux'
 	build = false
 endif
-deps += ['mempool_dpaa2', 'bus_fslmc', 'bus_vdev', 'pmd_dpaa2']
+deps += ['bus_vdev', 'pmd_dpaa2']
 sources = files('dpaa2_hw_dpcon.c',
 		'dpaa2_eventdev.c')
 
diff --git a/drivers/mempool/dpaa2/meson.build b/drivers/mempool/dpaa2/meson.build
index dee3a88ab..08e753060 100644
--- a/drivers/mempool/dpaa2/meson.build
+++ b/drivers/mempool/dpaa2/meson.build
@@ -5,5 +5,5 @@ if host_machine.system() != 'linux'
         build = false
 endif
 
-deps += ['mbuf', 'bus_fslmc']
+deps += ['bus_fslmc']
 sources = files('dpaa2_hw_mempool.c')
diff --git a/drivers/net/dpaa/meson.build b/drivers/net/dpaa/meson.build
index a4c40a680..62dec7b04 100644
--- a/drivers/net/dpaa/meson.build
+++ b/drivers/net/dpaa/meson.build
@@ -4,7 +4,7 @@
 if host_machine.system() != 'linux'
 	build = false
 endif
-deps += ['bus_dpaa', 'mempool_dpaa']
+deps += ['mempool_dpaa']
 
 sources = files('dpaa_ethdev.c',
 		'dpaa_rxtx.c')
diff --git a/drivers/net/dpaa2/meson.build b/drivers/net/dpaa2/meson.build
index ad1724d44..c9bd97a69 100644
--- a/drivers/net/dpaa2/meson.build
+++ b/drivers/net/dpaa2/meson.build
@@ -5,7 +5,7 @@ if host_machine.system() != 'linux'
         build = false
 endif
 
-deps += ['bus_fslmc', 'mempool_dpaa2']
+deps += ['mempool_dpaa2']
 sources = files('base/dpaa2_hw_dpni.c',
 		'dpaa2_ethdev.c',
 		'dpaa2_rxtx.c',
-- 
2.14.3

  parent reply	other threads:[~2018-03-29 13:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29 13:54 [dpdk-dev] [PATCH 0/6] enable easier app compilation testing with meson Bruce Richardson
2018-03-29 13:54 ` [dpdk-dev] [PATCH 1/6] examples: add empty meson files for unsupported examples Bruce Richardson
2018-03-29 13:54 ` [dpdk-dev] [PATCH 2/6] examples/l2fwd-cat: make build dependent on pqos library Bruce Richardson
2018-03-29 13:54 ` [dpdk-dev] [PATCH 3/6] examples: disable unsupported examples on BSD Bruce Richardson
2018-03-29 13:54 ` [dpdk-dev] [PATCH 4/6] examples: allow building all examples as part of meson build Bruce Richardson
2018-03-29 13:54 ` [dpdk-dev] [PATCH 5/6] examples: improve error report for missing meson deps Bruce Richardson
2018-03-29 13:54 ` Bruce Richardson [this message]
2018-04-02 10:02   ` [dpdk-dev] [PATCH 6/6] drivers/dpaa*: reduce meson dependency lists Hemant Agrawal
2018-04-06 12:10 ` [dpdk-dev] [PATCH 0/6] enable easier app compilation testing with meson Van Haaren, Harry
2018-04-09 13:50   ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180329135436.92878-7-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=shreyansh.jain@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).