From: Jasvinder Singh <jasvinder.singh@intel.com>
To: dev@dpdk.org
Cc: cristian.dumitrescu@intel.com
Subject: [dpdk-dev] [PATCH 1/2] ip_pipleine: fix load balance table action
Date: Fri, 30 Mar 2018 15:15:28 +0100 [thread overview]
Message-ID: <20180330141529.149612-1-jasvinder.singh@intel.com> (raw)
Fix bug in load balance action for pipeline table.
Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
examples/ip_pipeline/action.c | 42 ++++++++++++++++++++++++++++++++++++++++++
examples/ip_pipeline/cli.c | 9 ++++-----
2 files changed, 46 insertions(+), 5 deletions(-)
diff --git a/examples/ip_pipeline/action.c b/examples/ip_pipeline/action.c
index 2cedb24..77a04fe 100644
--- a/examples/ip_pipeline/action.c
+++ b/examples/ip_pipeline/action.c
@@ -186,6 +186,48 @@ table_action_profile_create(const char *name,
((params->action_mask & (1LLU << RTE_TABLE_ACTION_FWD)) == 0))
return NULL;
+ if ((params->action_mask & (1LLU << RTE_TABLE_ACTION_LB)) &&
+ (params->lb.f_hash == NULL)) {
+ switch (params->lb.key_size) {
+ case 8:
+ params->lb.f_hash = hash_default_key8;
+ break;
+
+ case 16:
+ params->lb.f_hash = hash_default_key16;
+ break;
+
+ case 24:
+ params->lb.f_hash = hash_default_key24;
+ break;
+
+ case 32:
+ params->lb.f_hash = hash_default_key32;
+ break;
+
+ case 40:
+ params->lb.f_hash = hash_default_key40;
+ break;
+
+ case 48:
+ params->lb.f_hash = hash_default_key48;
+ break;
+
+ case 56:
+ params->lb.f_hash = hash_default_key56;
+ break;
+
+ case 64:
+ params->lb.f_hash = hash_default_key64;
+ break;
+
+ default:
+ return NULL;
+ }
+
+ params->lb.seed = 0;
+ }
+
/* Resource */
ap = rte_table_action_profile_create(¶ms->common);
if (ap == NULL)
diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c
index 433f644..357d0ae 100644
--- a/examples/ip_pipeline/cli.c
+++ b/examples/ip_pipeline/cli.c
@@ -2314,8 +2314,7 @@ cmd_pipeline_table_stats(char **tokens,
* priority <priority>
* ipv4 | ipv6 <sa> <sa_depth> <da> <da_depth>
* <sp0> <sp1> <dp0> <dp1> <proto>
- * | array
- * pos
+ * | array <pos>
* | hash
* raw <key>
* | ipv4_5tuple <sa> <da> <sp> <dp> <proto>
@@ -2845,15 +2844,15 @@ parse_table_action_balance(char **tokens,
tokens++;
n_tokens--;
- if (n_tokens < RTE_TABLE_ACTION_LB_KEY_SIZE_MAX)
+ if (n_tokens < RTE_TABLE_ACTION_LB_TABLE_SIZE)
return 0;
- for (i = 0; i < RTE_TABLE_ACTION_LB_KEY_SIZE_MAX; i++)
+ for (i = 0; i < RTE_TABLE_ACTION_LB_TABLE_SIZE; i++)
if (parser_read_uint32(&a->lb.out[i], tokens[i]) != 0)
return 0;
a->action_mask |= 1 << RTE_TABLE_ACTION_LB;
- return 1 + RTE_TABLE_ACTION_LB_KEY_SIZE_MAX;
+ return 1 + RTE_TABLE_ACTION_LB_TABLE_SIZE;
}
--
2.9.3
next reply other threads:[~2018-03-30 14:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 14:15 Jasvinder Singh [this message]
2018-03-30 14:15 ` [dpdk-dev] [PATCH 2/2] ip_pipeline: add ecmp route example Jasvinder Singh
2018-03-30 14:31 ` [dpdk-dev] [PATCH v2 1/2] ip_pipleine: fix load balance table action Jasvinder Singh
2018-03-30 14:31 ` [dpdk-dev] [PATCH v2 2/2] ip_pipeline: add ecmp route example Jasvinder Singh
2018-03-30 15:38 ` Dumitrescu, Cristian
2018-03-30 15:38 ` [dpdk-dev] [PATCH v2 1/2] ip_pipleine: fix load balance table action Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180330141529.149612-1-jasvinder.singh@intel.com \
--to=jasvinder.singh@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).