Re: [dpdk-dev] [PATCH v3 2/2] octeontx: move mbox to common folder

[Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>]

Hi Thomas,

Thanks for the comments, will send out v4 soon addressing the comments.
I have verified static and shared builds already and everything seems to be
good.

Pavan

On Tue, Mar 27, 2018 at 06:15:56PM +0200, Thomas Monjalon wrote:
> Hi,
>
> 26/03/2018 09:53, Pavan Nikhilesh:
> > Move commonly used functions across mempool, event and net devices to a
> > common folder in drivers.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
> >  drivers/common/Makefile                            |  4 ++
> >  drivers/common/meson.build                         |  1 +
> >  drivers/common/octeontx/Makefile                   | 24 ++++++++
> >  drivers/common/octeontx/meson.build                |  6 ++
> >  .../{mempool => common}/octeontx/octeontx_mbox.c   | 65 +++++++++++++++++-----
> >  .../{mempool => common}/octeontx/octeontx_mbox.h   | 14 +++++
> >  .../octeontx/rte_common_octeontx_version.map       |  9 +++
> >  drivers/event/octeontx/Makefile                    |  4 +-
> >  drivers/event/octeontx/meson.build                 |  5 +-
> >  .../{mempool => event}/octeontx/octeontx_ssovf.c   | 20 ++++++-
> >  drivers/mempool/octeontx/Makefile                  |  5 +-
> >  drivers/mempool/octeontx/meson.build               |  6 +-
> >  drivers/mempool/octeontx/octeontx_fpavf.c          |  4 --
> >  drivers/mempool/octeontx/octeontx_pool_logs.h      |  9 ---
> >  .../octeontx/rte_mempool_octeontx_version.map      |  6 --
> >  drivers/net/octeontx/Makefile                      |  3 +-
>
> You need to update MAINTAINERS for this new directory.
>
> > --- a/mk/rte.app.mk
> > +++ b/mk/rte.app.mk
> > @@ -217,6 +217,10 @@ endif # CONFIG_RTE_LIBRTE_DPAA_BUS
> >
> >  endif # CONFIG_RTE_LIBRTE_CRYPTODEV
> >
> > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF)$(CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL),yy)
> > +_LDLIBS-y += -lrte_common_octeontx
> > +endif
> > +
> >  ifeq ($(CONFIG_RTE_LIBRTE_EVENTDEV),y)
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_EVENTDEV) += -lrte_pmd_skeleton_event
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SW_EVENTDEV) += -lrte_pmd_sw_event
>
> It is strange to insert common lib in the middle of PMDs after crypto
> and before eventdev, in the "static-only" section.
> I think it should be just after bus libs.
>
> Please test static and shared library compilation.
>
> Thanks
>
>