DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
To: jerin.jacob@caviumnetworks.com,
	santosh.shukla@caviumnetworks.com, thomas@monjalon.net,
	anatoly.burakov@intel.com, lironh@marvell.com,
	bruce.richardson@intel.com, fiona.trahe@intel.com,
	shreyansh.jain@nxp.com, hemant.agrawal@nxp.com
Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Subject: [dpdk-dev]  [PATCH v4 1/2] drivers: add common folder
Date: Mon,  2 Apr 2018 14:39:59 +0530	[thread overview]
Message-ID: <20180402091000.9208-1-pbhagavatula@caviumnetworks.com> (raw)
In-Reply-To: <20180319092726.10153-1-pbhagavatula@caviumnetworks.com>

Add driver/common folder and skeleton makefile for adding commonly used
functions across mempool, event and net devices.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
 v4 Changes:
 - modified dependency order i.e common before bus.
 - updated MAINTAINERS file.
 - moved linking common lib in rte.app.mk above bus.

 v3 Changes:
 - Fix common lib naming scheme.

 v2 Changes:
 - Removed dependency on bus.

 Based on discussion on ml
 http://dpdk.org/ml/archives/dev/2018-March/092822.html
 http://dpdk.org/ml/archives/dev/2018-March/093271.html

 drivers/Makefile           | 13 +++++++------
 drivers/common/Makefile    |  7 +++++++
 drivers/common/meson.build |  6 ++++++
 drivers/meson.build        | 11 ++++++-----
 4 files changed, 26 insertions(+), 11 deletions(-)
 create mode 100644 drivers/common/Makefile
 create mode 100644 drivers/common/meson.build

diff --git a/drivers/Makefile b/drivers/Makefile
index a1fa8b917..3d9f86b00 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -3,18 +3,19 @@

 include $(RTE_SDK)/mk/rte.vars.mk

+DIRS-y += common
 DIRS-y += bus
 DIRS-y += mempool
-DEPDIRS-mempool := bus
+DEPDIRS-mempool := common bus
 DIRS-y += net
-DEPDIRS-net := bus mempool
+DEPDIRS-net := common bus mempool
 DIRS-$(CONFIG_RTE_LIBRTE_BBDEV) += baseband
-DEPDIRS-baseband := bus mempool
+DEPDIRS-baseband := common bus mempool
 DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto
-DEPDIRS-crypto := bus mempool
+DEPDIRS-crypto := common bus mempool
 DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event
-DEPDIRS-event := bus mempool net
+DEPDIRS-event := common bus mempool net
 DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += raw
-DEPDIRS-raw := bus mempool net event
+DEPDIRS-raw := common bus mempool net event

 include $(RTE_SDK)/mk/rte.subdir.mk
diff --git a/drivers/common/Makefile b/drivers/common/Makefile
new file mode 100644
index 000000000..192066307
--- /dev/null
+++ b/drivers/common/Makefile
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Cavium, Inc
+#
+
+include $(RTE_SDK)/mk/rte.vars.mk
+
+include $(RTE_SDK)/mk/rte.subdir.mk
diff --git a/drivers/common/meson.build b/drivers/common/meson.build
new file mode 100644
index 000000000..ab774b8ef
--- /dev/null
+++ b/drivers/common/meson.build
@@ -0,0 +1,6 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Cavium, Inc
+
+std_deps = ['eal']
+config_flag_fmt = 'RTE_LIBRTE_@0@_COMMON'
+driver_name_fmt = 'rte_common_@0@'
diff --git a/drivers/meson.build b/drivers/meson.build
index b41a0f18e..b146f09c5 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -2,11 +2,12 @@
 # Copyright(c) 2017 Intel Corporation

 # Defines the order in which the drivers are buit.
-driver_classes = ['bus',
-	       'mempool', # depends on bus.
-	       'net',     # depends on bus and mempool.
-	       'crypto',  # depenss on bus, mempool (net in future).
-	       'event']   # depends on bus, mempool and net.
+driver_classes = ['common',
+	       'bus',
+	       'mempool', # depends on common and bus.
+	       'net',     # depends on common, bus and mempool.
+	       'crypto',  # depends on common, bus and mempool (net in future).
+	       'event']   # depends on common, bus, mempool and net.

 foreach class:driver_classes
 	drivers = []
--
2.16.2

  parent reply	other threads:[~2018-04-02  9:10 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-19  9:27 [dpdk-dev] [PATCH " Pavan Nikhilesh
2018-03-19  9:27 ` [dpdk-dev] [PATCH 2/2] octeontx: move mbox to " Pavan Nikhilesh
2018-03-19 10:35 ` [dpdk-dev] [PATCH 1/2] drivers: add " Shreyansh Jain
2018-03-20 14:38   ` Pavan Nikhilesh
2018-03-20 14:40 ` [dpdk-dev] [PATCH v2 " Pavan Nikhilesh
2018-03-20 14:40   ` [dpdk-dev] [PATCH v2 2/2] octeontx: move mbox to " Pavan Nikhilesh
2018-03-20 15:01     ` Hemant Agrawal
2018-03-20 16:00       ` Pavan Nikhilesh
2018-03-20 15:45   ` [dpdk-dev] [PATCH v2 1/2] drivers: add " Thomas Monjalon
2018-03-20 16:06     ` Pavan Nikhilesh
2018-03-20 17:01       ` Bruce Richardson
2018-03-20 17:27         ` Thomas Monjalon
2018-03-20 19:25           ` Trahe, Fiona
2018-03-26  7:53 ` [dpdk-dev] [PATCH v3 " Pavan Nikhilesh
2018-03-26  7:53   ` [dpdk-dev] [PATCH v3 2/2] octeontx: move mbox to " Pavan Nikhilesh
2018-03-27 16:15     ` Thomas Monjalon
2018-03-30 17:23       ` Pavan Nikhilesh
2018-03-27 16:11   ` [dpdk-dev] [PATCH v3 1/2] drivers: add " Thomas Monjalon
2018-04-02  9:09 ` Pavan Nikhilesh [this message]
2018-04-02  9:10   ` [dpdk-dev] [PATCH v4 2/2] octeontx: move mbox to " Pavan Nikhilesh
2018-04-04  3:29     ` Jerin Jacob
2018-04-04  5:06       ` santosh
2018-04-04  9:23     ` Thomas Monjalon
2018-04-03  6:57   ` [dpdk-dev] [PATCH v4 1/2] drivers: add " Hemant Agrawal
2018-04-04  3:08     ` Jerin Jacob
2018-04-04  5:01   ` santosh
2018-04-04 14:30 ` [dpdk-dev] [PATCH v5 " Pavan Nikhilesh
2018-04-04 14:30   ` [dpdk-dev] [PATCH v5 2/2] octeontx: move mbox to " Pavan Nikhilesh
2018-04-04 14:37     ` Thomas Monjalon
2018-04-04 21:20     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180402091000.9208-1-pbhagavatula@caviumnetworks.com \
    --to=pbhagavatula@caviumnetworks.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=lironh@marvell.com \
    --cc=santosh.shukla@caviumnetworks.com \
    --cc=shreyansh.jain@nxp.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).