From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0064.outbound.protection.outlook.com [104.47.33.64]) by dpdk.org (Postfix) with ESMTP id 4C1D71B3CA for ; Tue, 3 Apr 2018 00:26:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=mfUHIPcaJExqrXEnHiLJKF3GT43ZOCxtDeRp5XmCZtQ=; b=jUpVoASA6Dwdxht/g6m/W4L1xHmsOT/rDB0kmPAPQkO4vnpqcQPBwWN9sVx5gf0dZS0pno6xPo/p4fV6pFBh0n9D/TFd2o2fr5xi/wR7OIPbx3EAKdPRJqmii6ay76A1fiBFUGFUfeFmEWQ1KdToLcVKr6l/30f1WgImzGOhUag= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (106.201.49.151) by CY1PR07MB2524.namprd07.prod.outlook.com (2a01:111:e400:c636::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.631.10; Mon, 2 Apr 2018 22:26:50 +0000 Date: Tue, 3 Apr 2018 03:56:31 +0530 From: Jerin Jacob To: "Ananyev, Konstantin" Cc: "'dev@dpdk.org'" Message-ID: <20180402222630.GA1501@jerin> References: <1520472602-1483-1-git-send-email-konstantin.ananyev@intel.com> <1520472602-1483-6-git-send-email-konstantin.ananyev@intel.com> <20180313140155.GC564@jerin> <2601191342CEEE43887BDE71AB9772589E28F57F@irsmsx105.ger.corp.intel.com> <2601191342CEEE43887BDE71AB977258A0AB693D@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2601191342CEEE43887BDE71AB977258A0AB693D@irsmsx105.ger.corp.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [106.201.49.151] X-ClientProxiedBy: MAXPR0101CA0019.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:c::29) To CY1PR07MB2524.namprd07.prod.outlook.com (2a01:111:e400:c636::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f28341e6-42d0-4d02-0962-08d598e8d506 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:CY1PR07MB2524; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2524; 3:74Dd57r96eFG74ep+P9Dai0qHOad+HTDgmsDlISpXrZXRGinJ3qk0JqsHYKj3yP7Kp0mqEBYuw+fn9MWvBonre1MU4wOjcKy+8VkU15nTce/N4Ng2V/AmCTHiGTGJeFc7+Q8lGP9GcjMnZR90/FRu7CX29LwL8KQciWlbRlcwI/AcURAE6Q9llyGSTKsurpsShTV8KALt/RF7wP81N8KFbXHa5xWrqC9ywzhoc3kWOVPxMDNdDWc3iHvJIqkzt1/; 25:8nGNrxbrxwt+a6a6LXqab4LQ/ujb/e2RQnTw2knVHjTtrAwyBsHxGsSXx77f5imAq5AcnY/zx1m3jEVlVfrHS+C1s14NePlYIc4DZkw0rh9mcn4AhDGLSbPNhlm4csDZPcd5BTGARa6HFpStZXjbsgV+VFBs6fGhaJvXYkQBaABLP6gJCbORsokaQyH8V8PTQfhQbZF7D1OG2Hxco8sWEpp5RXNEkKqIkFLshTrwAIEBLFlrN/GKiSDFwqDyzmRC7+lKPjKskktz45kckR9w4ejdB3kBbaUEotmt9W2WrfiSy+/B4FGhD1sqE/ExmIFSAzIJ+8M7YX27TRlMVjUEww==; 31:D75+WnHBf3dFvdHKB0CiOwjGI11nneGjwZ7PfQEEPbUtQ5/xBLXW5wgUkdXt+SXjJ+lwo9zSH8Gthp5NnegyPRVyE35acQjZRaj4l23ohjc3zUp8I7KZEjOYAaIsLtcxu/Ow3v8zunNu6IqwpCM/iQFDlEENt46IH4CavHdPPD5skbFd41AyrRZBuIq8lMfRo+lrQtgv0zZVTTu2XQJ8oLKozY2BkC6V1VkMOFUvQM0= X-MS-TrafficTypeDiagnostic: CY1PR07MB2524: X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2524; 20:Hf6SNC3+cDz6TghruGTJ7y/j/DomL1RedziLBbFg8ObZws9BAr6e7QO8mt2N1lUAYJrZDY5amZlUXRU1jriKldGO/xyrd8W5xApaU97JlU1dRzUNhr7Ev+UhQQX7Fahz6HHzGzkMLKqU8kLLrZk4XHg6uj0RYVOldwUSvK2uGtFtFktEJQERJUQ8DkdLuOCq6+J1K/Kz5/fFrImhX9Ai491mTEvRFPUhwpybGUCvvo/cNdDemWuJ27hyK0AMubEbFPjB3ievwnLroRK3ySqq+HJVXWrV3ToUJhvyJwUn7BF3+kR7kqzJY3LNV2BEKx9BUscfJfUD/0f5z1NcZLAsPA/K0axWR3txmFApEBxQi+V0HeLlk9k9zbH9kbZfjHs92rhYerRG+9IPtNULuNsWgh9jlHE1cJsHQMYvzinx60Fyee7WyRPr43KwSgk2Qw2sMqzoLkDOGml9itMdB2WGwLa//OFQPVStaKQ1x8LGh508MU4r8dcSgSxEKSNJ9E77p7MkHmrQfMTMLPqLQhpDC6Tqrc+vcFxtA9zShu3nX9vA9SFonSfxAZT+gK2fbt8tDn9b5Hy0KFTcG2BeiZqocaTxR+JMjyUfRFU3HOrgpIA= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699)(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501327)(52105095)(93006095)(10201501046)(3002001)(6041310)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:CY1PR07MB2524; BCL:0; PCL:0; RULEID:; SRVR:CY1PR07MB2524; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2524; 4:u2VQImTVoP78O2CqIBNaHUroHe9+69qvHPqnz2Vnwlr3MgCblU0x5upSLcA9N+BA7JF9fqdohRIfW5+1bd5US+JTE6Kuf+6IzPFy9P6vV447SoXxIFnY5HVsTPg2b3adD7BwN0Kj4iyABe3jhkqZX8Jm0hEg7dRAr6dj17JjnTNKch+LIMQf9zytdOhaevr5hESobEABWcMZdZNrjHYp/isvBLiPcwYSVAtVdX99CzPJMuxvMi68jdO3cBSjuPBSbbhE4JLIgIG+g1FalSNA/QWRHpRNAXRvvAiIG9BK2VtDXjvfniNHItL2qpEauKFbiYp5UfQPgKf57o85YWqAEUGx19T9gH6O8xZCK9n2i+0= X-Forefront-PRVS: 0630013541 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(366004)(39860400002)(396003)(346002)(39380400002)(376002)(13464003)(189003)(199004)(6496006)(5660300001)(72206003)(305945005)(33656002)(25786009)(7736002)(105586002)(186003)(16526019)(26005)(50466002)(66066001)(478600001)(47776003)(33716001)(53936002)(6246003)(55016002)(9686003)(2906002)(23726003)(1076002)(446003)(386003)(93886005)(6666003)(6916009)(52116002)(68736007)(59450400001)(33896004)(76176011)(956004)(486005)(316002)(106356001)(229853002)(486005)(55236004)(81156014)(42882007)(81166006)(8936002)(8676002)(16586007)(58126008)(5009440100003)(11346002)(476003)(3846002)(97736004)(4326008)(6116002)(18370500001)(217873001)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB2524; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB2524; 23:q8sI2n1BQVGYVw3eSnAgTmCtpjTSVNAnB9x5BbuqB?= =?us-ascii?Q?Vg60e9e4oMD1hfwq+eBNTYZu1O1J7CXF9Xo0ObI6HYkAVRbwWckGA5llN2G/?= =?us-ascii?Q?D0r7u/cJ0U88A5w8bm3I3Egwb/isWu16LOtcJje/gF+Q/TEecxzuWSqr9/R2?= =?us-ascii?Q?4h1xH8YrjQ6LrO8A6ZA8yTpLaRjFJUup4NX1ojMYz0rf1k7wrMGBo90Fk2GK?= =?us-ascii?Q?BEKHdRgSQ2ahQCOuUdGCe47TM9u3TcP/O9hCGOpphlr7CScN/tQgDdm+ylIN?= =?us-ascii?Q?xdYJDWewF9gU8tln9GrgJDMXvTRQ/2VRKNyxin4b03+H498TqdvMPYM9l1Io?= =?us-ascii?Q?jGjS2uf8Hu9kdghmGphBF1q6oaXAYCotzIhcIxSIdLmx1prvUfkkwrgRDNqn?= =?us-ascii?Q?o8E4WkVtDNSSI6ys8GCHgIchtBJ7dQ0XrLqUBVydGXN5qz+8R9Gped+rR/He?= =?us-ascii?Q?gG+K4SSiED5zrM/atgwRAugLFVRO2zKrQ6NO4CQLkAjHG1+wEuHrwueHueoZ?= =?us-ascii?Q?yERRc/yeFYC0eAT55SqBhZb+WK9vZpLhC5zby6l44ebahHukXLRf3xOqxWBi?= =?us-ascii?Q?iMKgMXsamy2GhfJ35HnSrXpMkPmzrR8KFpvV5++Iu1ReG5hxtwXVbsZdfiiD?= =?us-ascii?Q?ZugHlDAgAAz3OdoeCXKofdgC+ejf61kCNsTQ4fMUcmpc9J+dcD9h2wcIZ9DE?= =?us-ascii?Q?5GgZ/PJKeBnBoTa6beKAaoc5f+EqAy4YKm6yyQ9KGCUe0dzEzEN35H3BdfsM?= =?us-ascii?Q?/fmlV1Bg7FJRAXr5IXz/dewoGmoHCJR9Ov190yjzbCzrlywKKSfNLxafZ3Zq?= =?us-ascii?Q?9Btik4C2tbTxnY7uMN8hwennao1fkVKUC8efWjYkO3hQcqYgtnmGIeW88uT5?= =?us-ascii?Q?/BeTVKVuEpABAd2nRAcQU5+GHGBcXiMt4Z+avxBZdTBhRLMBTldwnLj8gdia?= =?us-ascii?Q?58GgA7uq4P5ZVClShQRxU3nHJKd0kM0XTd6vdVhi2NqhAvj2OJXc8rcpjTE3?= =?us-ascii?Q?a4WA41ulfpW+xbzR6/ejaEDAJnJRVIIczT8VfDSHKgaWh+FZC7QiZ1aQNKfi?= =?us-ascii?Q?mIvyfMTbQViHkoSg1sjkMpVUUmnCM/evi62F1lMLbwuaAoJN/JvoCQuwURWU?= =?us-ascii?Q?l+KXrb5ikIiwwfizH+9a6nZXevAlf9ueXKTxADzRV5fZVVJN/1sL0PEtKxFi?= =?us-ascii?Q?Pc5SSFZw0Y6ZPWDIHnIvYzD+pwcMVwaftOs4U5yz3KyvAby5piFWt6HScmWT?= =?us-ascii?Q?PYLapIiCIYYcg7Gly4WIr+dXJiCu5rOZd2VKK8NHN6iqNRAiHfPq9eWGzjFo?= =?us-ascii?Q?n4qCNSuKvearZdAd9hzhedR/Pv2EGMhsw4WmmtBd2X/F+uSRPMx2SOTiAfbS?= =?us-ascii?Q?uJePd0viqJ3k9KCnMyGp19//BA4kogGQeMN6T+R/1YJhCFlqO0t7zuJJBSSX?= =?us-ascii?Q?oroaJdyurjK1zi44z9DSCTgVX6MXzddW8ua9p4ZCAx3iwFXsobvcAbNK+jOj?= =?us-ascii?Q?LcBvgIYaA/c3fyaVjtgC0t7AYPcXQC+TdtKmFTmgCBxJht4luzG69XVHvf6G?= =?us-ascii?Q?1oAz7lilPpoSLQCRg=3D=3D?= X-Microsoft-Antispam-Message-Info: EavxLAS6xdsLy575eGWYeXD2JOBkpU11ihh/h4zKL0JbmwhrOP8IEQeU1TpmZA44MSBRd24CjMa3Oh0JGzrQfRxQhb9nKRwPqC6MvF897NPZlDQznIU8zh000cBGu9QZ4GvdPSBdvU6UvYTWgQzDLUJsISmN+BuEsJC655KyA0C2fgLlp5p9zG0DoflkOT0h X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2524; 6:gOX/gxbe06rf/RhNHq71EHeovYlJHoFryrTGmAyUGFvRDgcprGWDQWS18zNdduP9h53MaxM7DKA3XeEsJdTYfcTrG02KcOgtBtTxSHZliIvA1j/RfQIqvtI3JxCVBA2VHRtDkym+yTbCW4Cm0mMNCQtpdtzoIwnKp1tyvQ5JxLGOpk/k5Xy4xq9P/kHiERPc8M68lSWDpMegvl8IAnW3E5tEqIQjRtJ9Z1qosvgdBu7kb93+gtwKHzx+0GcFtNTZmu1BShiu5rrqv9JQZOzVut0yuBjA4ka4L3fnYYGXXIrGeaNXJoeIhCmcweX0gFz7L6zEmFKv/qSkKoMYQbplcID4ONBrluEfd1YWIgn4btktMMc/wXhas708EBcybIKFQ/4BOwHcumYC4AOVh368XEKN5umeRg7FNRiQlRFNEWDprKpJePrsXnLJnB+SlvzTDqWkzbFciuyGdnsDqIJ+1w==; 5:FYx8eyMa9xYwU39LuQLdAbTfO5bzWpRoJvlju6xFKbZBLobjhgj2XBWkRMHYpflMielwbfbqBX3F6srK0ip9CmeavaiDuZCUPUFiBSj0hWINpfr28bs7UtGJUimpJ7LECzL/ZmFmAlClGthwKGhS9cIq91vkcWxgo0LT4szsxbY=; 24:yhwx4Iu4ff4geeU2qTSRyk7lJoLexrzHO+SjrZCJ9hTSzPdfc+/xzDim4ZEr4e675k7tERW/fRd/wy9P3dsfGHkzSEUoSfhRKuXMVn4DZQU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2524; 7:5faoipVYxHOFVXdv7QjXL2qZs+/mfYIJcYNazvf107obkS+UFzaQyjIkR3PV2H1fpeX1QJCW8sySOk5JE69EfwD8eLL8P2lQMpP5sfYUAIrY9Y7nfWwPEtyKU3yJ2DtY+ommhiVD4gqdNgHzrWXpj3NBcG6VHZKuMwWiuHd6mxi6vF0vAsIzr9BslSpurrDe6JY4ptodz7U/49AOBaN6SkC41kYIxoaI9Lg5iXmEChqGCzQizA/SDKdtZ2iciEFc X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2018 22:26:50.6101 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f28341e6-42d0-4d02-0962-08d598e8d506 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2524 Subject: Re: [dpdk-dev] [RFC PATCH 5/5] test: add few eBPF samples X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Apr 2018 22:26:53 -0000 -----Original Message----- > Date: Fri, 30 Mar 2018 17:42:22 +0000 > From: "Ananyev, Konstantin" > To: 'Jerin Jacob' > CC: "'dev@dpdk.org'" > Subject: RE: [dpdk-dev] [RFC PATCH 5/5] test: add few eBPF samples > > Hi Jerin, > > > > Add few simple eBPF programs as an example. > > > > > > > > Signed-off-by: Konstantin Ananyev > > > > diff --git a/test/bpf/mbuf.h b/test/bpf/mbuf.h > > > > new file mode 100644 > > > > index 000000000..aeef6339d > > > > --- /dev/null > > > > +++ b/test/bpf/mbuf.h > > > > @@ -0,0 +1,556 @@ > > > > +/* SPDX-License-Identifier: BSD-3-Clause > > > > + * Copyright(c) 2010-2014 Intel Corporation. > > > > + * Copyright 2014 6WIND S.A. > > > > + */ > > > > + > > > > +/* > > > > + * Snipper from dpdk.org rte_mbuf.h. > > > > + * used to provide BPF programs information about rte_mbuf layout. > > > > + */ > > > > + > > > > +#ifndef _MBUF_H_ > > > > +#define _MBUF_H_ > > > > + > > > > +#include > > > > +#include > > > > +#include > > > > > > Is it worth to keep an copy of mbuf for standalone purpose? > > > Since clang is already supported, I think, if someone need mbuf then > > > they can include DPDK headers. Just thinking in maintainability > > > perspective. > > > > That would be ideal. > > I made a snippet just to avoid compiler errors for bpf target. > > Will try to address it in next version. > > > > I looked at it a bit more and it seems that it wouldn't be that straightforward as I thought. > There are things not supported by bpf target (thread local-storage and simd related definitions) > inside include chain. > So to fix it some changes in our core include files might be needed . > The simplest way would probably be to move struct rte_mbuf and related macros definitions into a separate > file (rte_mbuf_common.h or so). I think, rte_mbuf_common.h should be the way to go. IMO, KNI also benefited with that. I guess, There is NO ABI change if we move the generic stuff to rte_mbuf_common.h. But if you think, it is quite controversial change then we could postpone to next release.(Only my worry is that, once it is postponed it may not happen). I am fine with either way. > Though it is quite controversial change and I think it is better to postpone it till a separate patch and > probably next release. > So for now I left a snipper test/bpf/mbuf.h in place. > Konstantin