From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id B6B961BC48 for ; Wed, 4 Apr 2018 09:30:06 +0200 (CEST) Received: by mail-wr0-f196.google.com with SMTP id s18so20950563wrg.9 for ; Wed, 04 Apr 2018 00:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=M8ou3oTo+jN14U0uxlqaIR00FVraB3FwobJPYw8iesA=; b=SEeRj/+27U3hBi+wT4AV9xRsFJvP9nu3asbZ9nNoNW9h9JdYbYAK3fjOkV3QzKpH/P 9K+h3qJx9drsUiDr8Sg46OKTArk90RG+cQGHdqzP7DCF5y1/HR+Ep1H+8asJUNujqsWW 7oR9WT1oSQglShptAX5C/I1rUlj/7RJzRDE/0+PlZC5cPg8C2Adqzrn54dhSWJiu6Sb2 M7PFsTE9hvnOklZs2fFLPeffE8sXrGAsjmkTmGzcBza7Q89TbrJhRcvb2Z9KIOPa454j lGpy0wezCRpP4FyEqvc53IuVqgYP+l6BXdaIlHlP9Me1vUOrx+u4cHMpbGFqKVEraZaS 2p2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=M8ou3oTo+jN14U0uxlqaIR00FVraB3FwobJPYw8iesA=; b=QhgCA7DIGnMZOpvXdneOWn0rpI5co+6QplAzc+kZoZ4Qd3nVw58oxE9qLY6PGHYfz7 CyjzT7Ehsma7erDr/h0abFyvfSII79XdhQwGQfe77lPzbLaNYat2Zwi7ZVsxpdzC6Z9x KZF9BNgAN6I4r6hhv+SltwPwfHAYSb805nq5MoQuDRc71WtbsmSPHIF508u8NUL5JSG5 qAinkXTrmxbggiYK4qiC2TsL21TS9JKuh++oc/1FzMd/7jIwYVtGFZnDBGWIggoa5QVe tdY/aZCFGaCrM6anwQmZx9x/LAJAqIbGkwy8IS2PlbLQGK48ICgPBdte8lMt1NqiJOOf I8ig== X-Gm-Message-State: AElRT7GXBnWHix79/IyHAmYmU6DM8zK0rLLSohA8isj4eLybJCkWnLva 3MTKRlsefJ6A5DR1z+mXDGL5EBTqAQ== X-Google-Smtp-Source: AIpwx4/Ws+LvmEYmwkWbwAZQ1XEO+dkK9OxqWMBacP+vjaRVbifv2tiwijaI8OSml1VmldEiYofIeg== X-Received: by 10.223.134.47 with SMTP id 44mr11505954wrv.114.1522827006409; Wed, 04 Apr 2018 00:30:06 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id b34sm10432876wra.21.2018.04.04.00.30.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Apr 2018 00:30:05 -0700 (PDT) Date: Wed, 4 Apr 2018 09:30:09 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Shahaf Shuler Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org Message-ID: <20180404073009.zgqu3yrj26trwdfr@laranjeiro-vm.dev.6wind.com> References: <20180403044817.27457-1-shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180403044817.27457-1-shahafs@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix link status initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 07:30:06 -0000 On Tue, Apr 03, 2018 at 07:48:17AM +0300, Shahaf Shuler wrote: > Following commit 7ba5320baa32 ("net/mlx5: fix link status behavior") > > The initial link status is no longer set as part of the port start. > This may cause application to query the link as down while in fact it was > already up before the DPDK application start. There is something wrong in this explanation, the application should query the link using this same callback, why the PMD should call it? > Fixes: 7ba5320baa32 ("net/mlx5: fix link status behavior") > Cc: nelio.laranjeiro@6wind.com > > Signed-off-by: Shahaf Shuler > Acked-by: Yongseok Koh > --- > drivers/net/mlx5/mlx5.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c > index 7d58d66bb9..f954ea2862 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -961,6 +961,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, > DRV_LOG(DEBUG, "port %u forcing Ethernet interface up", > eth_dev->data->port_id); > mlx5_set_link_up(eth_dev); > + mlx5_link_update(eth_dev, 1); > /* Store device configuration on private structure. */ > priv->config = config; > continue; > -- > 2.12.0 -- Nélio Laranjeiro 6WIND