From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 60AC41C4BC for ; Wed, 4 Apr 2018 15:10:37 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Apr 2018 06:10:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,406,1517904000"; d="scan'208";a="40620509" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga003.jf.intel.com with SMTP; 04 Apr 2018 06:10:32 -0700 Received: by (sSMTP sendmail emulation); Wed, 04 Apr 2018 14:10:31 +0100 Date: Wed, 4 Apr 2018 14:10:31 +0100 From: Bruce Richardson To: Arnon Warshavsky Cc: thomas@monjalon.net, anatoly.burakov@intel.com, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, ferruh.yigit@intel.com, dev@dpdk.org Message-ID: <20180404131030.GA30584@bricha3-MOBL.ger.corp.intel.com> References: <1522841257-11826-1-git-send-email-arnon@qwilt.com> <1522841257-11826-2-git-send-email-arnon@qwilt.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1522841257-11826-2-git-send-email-arnon@qwilt.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH 01/13] crypto: replace rte_panic instances in crypto driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 13:10:37 -0000 On Wed, Apr 04, 2018 at 02:27:25PM +0300, Arnon Warshavsky wrote: > Signed-off-by: Arnon Warshavsky > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +++++--- > drivers/crypto/dpaa_sec/dpaa_sec.c | 8 +++++--- > 2 files changed, 10 insertions(+), 6 deletions(-) > > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > index 784b96d..37a5727 100644 > --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > @@ -2861,9 +2861,11 @@ struct rte_security_ops dpaa2_sec_security_ops = { > RTE_CACHE_LINE_SIZE, > rte_socket_id()); > > - if (cryptodev->data->dev_private == NULL) > - rte_panic("Cannot allocate memzone for private " > - "device data"); > + if (cryptodev->data->dev_private == NULL) { > + RTE_LOG(ERR, PMD, "%s() Cannot allocate memzone for " > + "private device data", __func__); > + return -1; > + } > } This is the right change to make, but can you please avoid wrapping literal strings across lines. It means that the error message cannot be grepped. Just put the __func__ on the second line. Checkpatch and similar tools should ignore long lines if the long line is simply caused by a literal string. /Bruce