From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 37AD51C704 for ; Wed, 4 Apr 2018 16:58:01 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id t67so22245972wmt.0 for ; Wed, 04 Apr 2018 07:58:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0PkH/umcJVjXp/kzzU4kuZCr/2QpIl5tB1o/gkg98wI=; b=yWAPQT/NY008KJqIJ4QWcSkBMv2HmxaNIApThC86UHXu4gJSv0oj9IRdN2Z/4HMU55 hZFapF1FyEkO4dgLK5NjCWTPdIuxg5wCRc+8waOsGT82me5V26gBX3y+u+9myihc1Kq/ QYgXKzSxIy7GoSOZMAPvGR9VEhGPmm3KRy3/MzqcGZRpU/RxJYPRY8TPnjKKVkJVimPX Jkb9RzDqoywX80Ku1fbyE4h6xYz+dNk6zpSoEJVb4ToiSfhNEdAqgNNNM5w0qTWdOZEq gvW1U35fSceznOCxduZ97JYsuMw10DHTUErMRTdujlGSM1bdAXO8/xnN4tgpMeK8PW7W Y1Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0PkH/umcJVjXp/kzzU4kuZCr/2QpIl5tB1o/gkg98wI=; b=L9PnzneiafI0AJitMHrvoG3dp8MzmtF5nYzB4Uc1dGMUFG5Ndi8FBI4Oi5WBtZZo2n hg/Edk5lpkfMKWkpEbNxL/IJTQbj8VlVxeA1i9ShAV8SYuqQ1aTejmEFTnB3s8/n0n1j k55YbbNMPVSn9wX+TP2rAn3ltwcjn1b3P5Ff8CPaBkRy1/dBQSaj3Ph6xTQMUUVK2jqb kA62fKxDVjAONJFGMr8bBBT0Trn4M0PC2kbHeib5kK5XlqK9ea3xecmzB4JCYK6/gqP6 ckVoBa/QQuBRruNoIEcpN7zu9PFNXiZtMWyFIyAO/qPZhMNIjPAyeGPOX/xXLMXwndoy BqFw== X-Gm-Message-State: ALQs6tC2hh9Jyzoi3RBEJAYZRgE7IScRdpxcn4xwV3NQCnbSG4f0NTJf 8PpdSqaJQLUgJkRlZhqfeSv5/K0l X-Google-Smtp-Source: AIpwx499XZDWwaUSiN/usAz89+cmZdviDpab9v6rs8Vxirec4/BGVwLBKzHRwtAFIsQhzxjTnORQ4g== X-Received: by 10.28.141.85 with SMTP id p82mr7090222wmd.19.1522853880897; Wed, 04 Apr 2018 07:58:00 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id a205sm3348664wmf.18.2018.04.04.07.58.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Apr 2018 07:58:00 -0700 (PDT) Date: Wed, 4 Apr 2018 16:57:47 +0200 From: Adrien Mazarguil To: dev@dpdk.org Cc: stable@dpdk.org, Shahaf Shuler Message-ID: <20180404144805.11966-2-adrien.mazarguil@6wind.com> References: <20180323124725.15806-1-adrien.mazarguil@6wind.com> <20180404144805.11966-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180404144805.11966-1-adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH v2 01/13] net/mlx4: fix RSS resource leak in case of error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 14:58:01 -0000 When memory cannot be allocated for a flow rule, its RSS context reference is not dropped. Fixes: 078b8b452e6b ("net/mlx4: add RSS flow rule action support") Cc: stable@dpdk.org Signed-off-by: Adrien Mazarguil Cc: Shahaf Shuler --- drivers/net/mlx4/mlx4_flow.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c index 2d55bfe03..a3b4480b4 100644 --- a/drivers/net/mlx4/mlx4_flow.c +++ b/drivers/net/mlx4/mlx4_flow.c @@ -820,11 +820,14 @@ mlx4_flow_prepare(struct priv *priv, }, }; - if (!mlx4_zmallocv(__func__, vec, RTE_DIM(vec))) + if (!mlx4_zmallocv(__func__, vec, RTE_DIM(vec))) { + if (temp.rss) + mlx4_rss_put(temp.rss); return rte_flow_error_set (error, -rte_errno, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, "flow rule handle allocation failure"); + } /* Most fields will be updated by second pass. */ *flow = (struct rte_flow){ .ibv_attr = temp.ibv_attr, -- 2.11.0