From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id DAAE61C70E for ; Wed, 4 Apr 2018 16:58:04 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id p9so41778418wmc.3 for ; Wed, 04 Apr 2018 07:58:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=D/NOV/8XjgMl0gzmwXUQp1oYjPvtX0NZ2G2bGdk0oO8=; b=NzOXzYjDJ6ydEUlRQqs9YQSeSRdpoy6JmhnrIsn+kpBnAjKEEQo4HuTjHgYdji5Lfb viX5aX3lGBiTXwbtpRbQ+s5tg3KwkQbKzwxPw84l73MDvEDV40FojE4/rxUeUqZ0GTnI RC6Er1lbZHVlcIFbLUEM7sk5EPR7ZXnQ6uu2f/T7QlqZG30lA0EyuQkWey8aoZ5qDyDQ UXTEfLuqFJso/aYLsbNt/5HhKhZPb8rhgE4P6MazfpXYGE2KdJ5vPNZ8x84WLdt7SEX8 p3spY28XSH4Kkfncw+Ady+ST9IpmfuHFZg4hNF+YKDw4ZYmQqiWTr6Wj0ekbqw6Sk9R3 bs8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=D/NOV/8XjgMl0gzmwXUQp1oYjPvtX0NZ2G2bGdk0oO8=; b=mwJ+0lfkcUIQvlYvUuMFeSXw9zHYaWpX5ggboZHDDOMUVNS6uA80rAUFAtJz6oP/3T 2Sysd2Vp27C6tMCCDSQmlFSxy3DnvyjPum6JInh1iP6+/6ZMfIlsmvtIi1q/RTAE4PNU Z07HpG/EZKgOZ4V+nRwZax9fnun3/Vwf0Yocd3Ud42E7d5WwT0R1OfHC87O05llG8L/5 Q5E5CgsRA/kg5a+2UGsu0KqHjYQAYi78fG4cGcI+Hvan8OkPNhctOniFzCQXOoKUPSaJ 4p6R3qhMk2AegjDlfSODDCXN9yiod/yR9+OFQowftizhbnL27KMdHCpiFB37Iza3YIbJ hbnw== X-Gm-Message-State: ALQs6tBDZa1FHKOzDAa0SorDfyHRWsWt0yMDbmt5ELFM7VBxah6ZXCXH cHeKl0x9RwXpTBHRXgDNNx92YuFB X-Google-Smtp-Source: AIpwx4/nCwgEQM34BSaFL+lGWjXk59/s+NRHW0/gzcU2Q4DLALYN/2G1iP9u7taO6ewPZtkRvzXwkA== X-Received: by 10.28.238.141 with SMTP id j13mr5007821wmi.50.1522853884442; Wed, 04 Apr 2018 07:58:04 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id v75sm5703197wrc.90.2018.04.04.07.58.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Apr 2018 07:58:03 -0700 (PDT) Date: Wed, 4 Apr 2018 16:57:50 +0200 From: Adrien Mazarguil To: dev@dpdk.org Cc: stable@dpdk.org, Nelio Laranjeiro Message-ID: <20180404144805.11966-4-adrien.mazarguil@6wind.com> References: <20180323124725.15806-1-adrien.mazarguil@6wind.com> <20180404144805.11966-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180404144805.11966-1-adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH v2 03/13] net/mlx5: fix RSS flow action bounds check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 14:58:05 -0000 The number of queues provided by the application is not checked against parser's supported maximum. Fixes: 3d821d6fea40 ("net/mlx5: support RSS action flow rule") Cc: stable@dpdk.org Cc: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index e6af3243d..f051fbef5 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -16,6 +16,7 @@ #pragma GCC diagnostic error "-Wpedantic" #endif +#include #include #include #include @@ -713,6 +714,14 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev, return -rte_errno; } } + if (rss->num > RTE_DIM(parser->queues)) { + rte_flow_error_set(error, EINVAL, + RTE_FLOW_ERROR_TYPE_ACTION, + actions, + "too many queues for RSS" + " context"); + return -rte_errno; + } for (n = 0; n < rss->num; ++n) { if (rss->queue[n] >= priv->rxqs_n) { rte_flow_error_set(error, EINVAL, -- 2.11.0