Re: [dpdk-dev] [PATCH v2] build: clean up building kernel modules using meson

[Bruce Richardson <bruce.richardson@intel.com>]

On Wed, Apr 04, 2018 at 04:47:25PM +0000, Hemant Agrawal wrote:
> Just checked. Your V2 got build without any warnings for me.
> 
> Regards,
> Hemant
>
Thanks.

/Bruce
 
> > -----Original Message-----
> > From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> > Sent: Wednesday, April 04, 2018 9:27 PM
> > To: Hemant Agrawal <hemant.agrawal@nxp.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [PATCH v2] build: clean up building kernel modules using meson
> > Importance: High
> > 
> > On Wed, Apr 04, 2018 at 04:53:32PM +0100, Bruce Richardson wrote:
> > > The meson.build files for building the kernel modules directory could
> > > be improved now that it is extracted from the EAL. For example, no
> > > global processing is necessary inside the kernel folder, just need to
> > > subdir to the appropriate bsd or linux folder to do the actual work.
> > >
> > > To avoid potential race conditions with the BSD module builds when the
> > > kernel build system is creating the dev_if.h and other files, we
> > > serialize the kernel module builds (all 2 of them!) by setting up each
> > > module to depend on all the previous.
> > >
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > > Tested-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > >
> > > ---
> > > v2: serialize the BSD module builds to try and resolve the
> > >     warnings seen about bus_if.h/dev_if.h/etc. in some cases.
> > >     Issue reported by Hemant.
> > > ---
> > 
> > Hi Hemant,
> > 
> > I haven't been able to reproduce reliably the issue you reported, but the above
> > fixes what I *think* to be the issue causing the error print. If you get a chance,
> > can you do a quick re-test and see if it re-occurs for you.
> > If not, I'll apply this version - otherwise I might just apply V1, since the error
> > itself appears harmless, as you say.
> > 
> > /Bruce