From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 7007F1C8DE for ; Thu, 5 Apr 2018 08:57:11 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id u189so2892627wmd.1 for ; Wed, 04 Apr 2018 23:57:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=VO0TTIGfzISg5HZTd2GPf5oaLn5mIIB+AqIBvtNFcjI=; b=mEhCpavoYfJdGAPogNlyomKTbUe+tPY5whSXU3aFsQzCxZV6kvq638tV3ZjpY9iG1c NIjEH70EwDMwwc+beruMr8JIKzylVV0DRcdvbHFpZSN16ZE3Jhz67j0imJjlYrsTfqR7 GEi0DeqtHwf7q0rmbaZRCboyU3gllY2ogAdnMjCmmiEwnDrNEzFlQ3btfLVkTndaGpzo iGnxdI5Fn3q7UCSYxRSIJ7xIewM2pW8j8sdbPADzfer2Lt275oWy5aRCTlPiu3ccxpMv 68NrObBvDP7lXazgtZyjBTAE2HFTPZcNnH6iINiOuBG3fCPUmMicHG+eTMKtbzyLpWcE P9/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=VO0TTIGfzISg5HZTd2GPf5oaLn5mIIB+AqIBvtNFcjI=; b=HzS/0T9OVDlvBaMmUEh66eXb9MY4zYT+B5F2+0s7/xe6GJq/4wCyhdsPN1//743XI9 DYPjmtVvEifFcwN0h+nbcR0kqMMxtlCo4vuluCX/XpL0xoyc9i2uWD3Odv5SKepSrZOA cbPDAUywZHgup2XZ7fdBK4eL5Ylh0mQKsUx0L5+0MtNcypNK3I9jzxttfLLOzG+9Ofpi TYS//SRhoRmK4qjgggdvlOtTCQweGLNGwWEOo7GIkAnOgttGj9msSU5WFahLrEAl2AOZ 7UqtgTeRxNGJIcWuJ5mdolRQ7ZKtCKOZES6o/fPqpci8NE/e+OX4HnNWj/tnab401dVz g9dA== X-Gm-Message-State: AElRT7FXZlQuEZx3d1f/QrawcaoFBsAUTqy2svE560XTdnLrwclTXczm MyuleqeXapMTg8WJh080gwTjDOFj8A== X-Google-Smtp-Source: AIpwx48hhhYiKQlUoZ9ImcV5Jeuh3Pubq8euywKJEBe9hLXh3ah1tdZDlA7FP4TCuBicaarqAs14hA== X-Received: by 10.28.125.194 with SMTP id y185mr10961426wmc.160.1522911431116; Wed, 04 Apr 2018 23:57:11 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 59sm7856249wro.35.2018.04.04.23.57.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Apr 2018 23:57:10 -0700 (PDT) Date: Thu, 5 Apr 2018 08:57:16 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Adrien Mazarguil Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20180405065716.yabae4tmtpbfjotj@laranjeiro-vm.dev.6wind.com> References: <20180323124725.15806-1-adrien.mazarguil@6wind.com> <20180404144805.11966-1-adrien.mazarguil@6wind.com> <20180404144805.11966-4-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180404144805.11966-4-adrien.mazarguil@6wind.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 03/13] net/mlx5: fix RSS flow action bounds check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2018 06:57:11 -0000 On Wed, Apr 04, 2018 at 04:57:50PM +0200, Adrien Mazarguil wrote: > The number of queues provided by the application is not checked against > parser's supported maximum. > > Fixes: 3d821d6fea40 ("net/mlx5: support RSS action flow rule") > Cc: stable@dpdk.org > Cc: Nelio Laranjeiro > > Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_flow.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index e6af3243d..f051fbef5 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -16,6 +16,7 @@ > #pragma GCC diagnostic error "-Wpedantic" > #endif > > +#include > #include > #include > #include > @@ -713,6 +714,14 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev, > return -rte_errno; > } > } > + if (rss->num > RTE_DIM(parser->queues)) { > + rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ACTION, > + actions, > + "too many queues for RSS" > + " context"); > + return -rte_errno; > + } > for (n = 0; n < rss->num; ++n) { > if (rss->queue[n] >= priv->rxqs_n) { > rte_flow_error_set(error, EINVAL, > -- > 2.11.0 -- Nélio Laranjeiro 6WIND