From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 013431C96D for ; Thu, 5 Apr 2018 08:59:31 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id d1so26524162wrj.13 for ; Wed, 04 Apr 2018 23:59:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=lcqoLrR6Vdss7o3KEh/EsUfN2VueGI6TkuGU4/Pu88g=; b=UC6Zv/5SDJqIxhA36BVDx5DPmHhLIF6PlRHYS12o+9343bi6SAaAbRbeyiieWkYSAV Wxgw5xXpPRvQk2X6v1ZHryWfCd0oNVWa2TsoRAZBjg7gt1svzFD99QXVoSv9udMks9FU Sq7lzd/6OjlqxR1rwjOuY1wHZtebl4dqmYzRdB00uk+/4suWWSP7BKwLa6JdqnmWpCrO lguFkmEhhJb8AHq1RND+Dbd3ckyjdW0i5ZsQ+znQwLGmZFn7yqutHZTQZhWh5mntD6qD F6iagMzbgAjfWLFgWMeoDONyZpwSzSiLfrImN00FkqfpwsBBpkUQ+LzsEzuSHwP2lPef b6FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=lcqoLrR6Vdss7o3KEh/EsUfN2VueGI6TkuGU4/Pu88g=; b=hoM7f+iMsMHDR7ASBeBECLxTMVKKMRrRJstSYN9SBrPb+NBb/AOBB0kD1CUhXvR1k0 zVegsdkxqWKN/CMtYo3zkLWnLme+qZ0l295JnB1YsNOTQHCJIDXS57fh2XbrsBL92DgB qRm5KrXJKUmgMfJdfPpVo2lI4zPgPTlAUf8p0aZtkud2CvYvekBl49YE9j+8dvxwTm86 zB12gmiJPPy7/1hNEEfHJjcoKs8BuuF9JD57YshST9tkFaRZyPt0LDtwF6Nhpm/G0fKL UQJRUbt0+NR5+ljA38PkwgmrbDfpcVPTyv3sXAasT9RSNiMLvOjwQruFz40xV+X3dD4B rHuA== X-Gm-Message-State: AElRT7FQ1CgfQwaphdOtQk81Vpbi3xMZoZFeG9fXNlKQy0H5hD4yuWui AbDhDWaGxkhkPJ/HT8ikNMTVXzekgQ== X-Google-Smtp-Source: AIpwx4+YFPgPHm4Zrn6imQX4HG8q8f+oLC7ZP8USzVNoHK63Nom3DSIcgdAqJ9BkTfptEAJ8U2x9Fg== X-Received: by 10.223.226.15 with SMTP id j15mr14337316wri.235.1522911566784; Wed, 04 Apr 2018 23:59:26 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k28sm1976153wrk.96.2018.04.04.23.59.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Apr 2018 23:59:26 -0700 (PDT) Date: Thu, 5 Apr 2018 08:59:32 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Adrien Mazarguil Cc: dev@dpdk.org, stable@dpdk.org, Wenzhuo Lu , Jingjing Wu Message-ID: <20180405065932.ehphf52wz6cmkv62@laranjeiro-vm.dev.6wind.com> References: <20180323124725.15806-1-adrien.mazarguil@6wind.com> <20180404144805.11966-1-adrien.mazarguil@6wind.com> <20180404144805.11966-8-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180404144805.11966-8-adrien.mazarguil@6wind.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 07/13] app/testpmd: fix lack of flow action configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2018 06:59:32 -0000 On Wed, Apr 04, 2018 at 04:57:58PM +0200, Adrien Mazarguil wrote: > Configuration structure is not optional with flow rule actions that expect > one; this pointer is not supposed to be NULL and PMDs should not have to > verify it. > > Like pattern item spec/last/mask fields, it is currently set when at least > one configuration parameter is provided on the command line. This patch > sets it as soon as an action is created instead. > > Fixes: 7a91969ad35e ("app/testpmd: add various actions to flow command") > Cc: stable@dpdk.org > > Signed-off-by: Adrien Mazarguil > Cc: Wenzhuo Lu > Cc: Jingjing Wu Acked-by: Nelio Laranjeiro > --- > app/test-pmd/cmdline_flow.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index 9cac8e9bf..c2cf415ef 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -1909,6 +1909,7 @@ parse_vc(struct context *ctx, const struct token *token, > return -1; > *action = (struct rte_flow_action){ > .type = priv->type, > + .conf = data_size ? data : NULL, > }; > ++out->args.vc.actions_n; > ctx->object = action; > @@ -1989,7 +1990,6 @@ parse_vc_conf(struct context *ctx, const struct token *token, > void *buf, unsigned int size) > { > struct buffer *out = buf; > - struct rte_flow_action *action; > > (void)size; > /* Token name must match. */ > @@ -1998,14 +1998,9 @@ parse_vc_conf(struct context *ctx, const struct token *token, > /* Nothing else to do if there is no buffer. */ > if (!out) > return len; > - if (!out->args.vc.actions_n) > - return -1; > - action = &out->args.vc.actions[out->args.vc.actions_n - 1]; > /* Point to selected object. */ > ctx->object = out->args.vc.data; > ctx->objmask = NULL; > - /* Update configuration pointer. */ > - action->conf = ctx->object; > return len; > } > > -- > 2.11.0 -- Nélio Laranjeiro 6WIND